Re: Patch for new email features
Felipe Vargas Rigo <
felipe@...>
2006-12-01 17:42:46 GMT
To checkout the 1.0 dev version you should have subversion installed,
so just run:
svn checkout http://svn.flyspray.org/flyspray/trunk
[]'s
Felipe V. Rigo
-----Original Message-----
From: flyspray-bounces@...
[mailto:flyspray-bounces@...] On Behalf Of Fry, Joseph
Sent: Friday, December 01, 2006 11:54 AM
To: Flyspray: The bug killer!
Subject: Re: [Flyspray] Patch for new email features
Flo,
Thanks for looking it over, I would love to hear your complaints about
my implementation so future submissions are a bit more "production
ready".
I will be happy to test it once it's in SVN... Is 1.0 currently being
developed, or is it waiting until 0.9.9 is stable before development
begins. If it is currently under development, how do I check it out of
SVN?
Joe
> -----Original Message-----
> From: flyspray-bounces@...
> [mailto:flyspray-bounces@...] On Behalf Of Florian Schmitz
> Sent: Friday, December 01, 2006 10:07 AM
> To: Flyspray: The bug killer!
> Subject: Re: [Flyspray] Patch for new email features
>
> Hi.
>
> I had a look at your patch now. While I dislike most of how
> it is done,
> I don't mind implementing such features for 1.0. So please
> help testing
> this feature when it's done (check commit messages) since I
> am not going
> to use it for myself.
>
> Regards,
> Flo
>
> -----Original Message-----
> Fry, Joseph hat folgendes geschrieben:
> >>> Hello everyone! Please be patient with me... This is the
> >> first patch I
> >>> have ever submitted to any project.
> >>>
> >> looks fine, except your are unnedesly modifiyint third party code (
> >> class.phpmailer.php) and the "notifications" stuff will be
> rewritten
> >> soon, so, I'll add a similar feature to 1.0.
> >
> > Thanks for your consideration of my patch.
> >
> > I had to modify the third party code in order to add a header to the
> > message. It looks like the project is in the process of moving from
> > phpmailer to swiftmailer, and as such I did not want to access
> > swiftmailer's addHeader method directly. I probably could have done
> > this relatively easily if I were willing to bypass the
> > phpmailer/swiftmailer compatability stub.
> >
> > Please, do try and incorporate the features my patch
> included in release
> > 1.0... It is one feature I have not found on any issue
> tracking system
> > that I think is under appreciated. Right now I have my mail client
> > forwarding any message with the word "urgent", "immediate",
> or "flash"
> > in the Priority: header I added. I also use the %a flag in
> the subject
> > line so that I can tell at a glance what caused the message to be
> > generated... Without the in-reply-to / Message-Thread
> headers, I could
> > not view these messages threaded by bug id.
> >
> > Thanks again!
> > _______________________________________________
> > flyspray mailing list
> > flyspray@...
> > http://lists.rocks.cc/listinfo.cgi/flyspray-rocks.cc
> >
>
>
_______________________________________________
flyspray mailing list
flyspray@...
http://lists.rocks.cc/listinfo.cgi/flyspray-rocks.cc
--
No virus found in this incoming message.
Checked by AVG Free Edition.
Version: 7.5.430 / Virus Database: 268.15.3/562 - Release Date: 12/1/2006
1:12 PM
--
--
No virus found in this outgoing message.
Checked by AVG Free Edition.
Version: 7.5.430 / Virus Database: 268.15.3/562 - Release Date: 12/1/2006
1:12 PM