Re: [PATCH V3 1/5] i.mx: introduce the armv7/imx-common folder

On Fri, Nov 25, 2011 at 8:18 AM, Jason Liu <jason.hui <at> linaro.org> wrote:

> +static char *get_reset_cause(void)
> +{
> +       u32 cause;
> +       struct src *src_regs = (struct src *)SRC_BASE_ADDR;
> +
> +       cause = readl(&src_regs->srsr);
> +       writel(cause, &src_regs->srsr);

Isn´t this writel unneeded?

Regards,

Fabio Estevam
_______________________________________________
U-Boot mailing list
U-Boot <at> lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [PATCH V3 2/5] i.mx: add the initial support for freescale i.MX6Q processor

On Fri, Nov 25, 2011 at 8:18 AM, Jason Liu <jason.hui <at> linaro.org> wrote:

> +u32 get_cpu_rev(void)
> +{
> +       int system_rev = 0x61000 | CHIP_REV_1_0;

Can´t we do this from reading from a chip location?

This way we don´t need to change when new silicon version shows up.

Regards,

Fabio Estevam
_______________________________________________
U-Boot mailing list
U-Boot <at> lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [PATCH V3 1/5] i.mx: introduce the armv7/imx-common folder

On Thu, Dec 1, 2011 at 8:04 AM, Fabio Estevam <festevam <at> gmail.com> wrote:
> On Fri, Nov 25, 2011 at 8:18 AM, Jason Liu <jason.hui <at> linaro.org> wrote:
>
>> +static char *get_reset_cause(void)
>> +{
>> +       u32 cause;
>> +       struct src *src_regs = (struct src *)SRC_BASE_ADDR;
>> +
>> +       cause = readl(&src_regs->srsr);
>> +       writel(cause, &src_regs->srsr);
>
> Isn´t this writel unneeded?

Some bits in this register is w1c, so clear it here.

>
> Regards,
>
> Fabio Estevam

Re: [PATCH V3 2/5] i.mx: add the initial support for freescale i.MX6Q processor

On Thu, Dec 1, 2011 at 8:07 AM, Fabio Estevam <festevam <at> gmail.com> wrote:
> On Fri, Nov 25, 2011 at 8:18 AM, Jason Liu <jason.hui <at> linaro.org> wrote:
>
>> +u32 get_cpu_rev(void)
>> +{
>> +       int system_rev = 0x61000 | CHIP_REV_1_0;
>
> Can´t we do this from reading from a chip location?
>
> This way we don´t need to change when new silicon version shows up.

The questions is that which location and encode schema we need follow,
take a look at mx5, it is different with mx51 and mx53, so before the new
tapout of i.mx6q, I don't have a clear vision about it.

>
> Regards,
>
> Fabio Estevam

Re: [PATCH 1/2] nds32: add linkage support

Hi Mike,

2011/12/1 Mike Frysinger <vapier <at> gentoo.org>

> On Wednesday 30 November 2011 03:06:42 Macpaul Lin wrote:
> > Add linkage support.
>
> let's add this to our linux/linkage.h:
> #ifndef __ALIGN
> #define __ALIGN     .align 4
> #define __ALIGN_STR ".align 4"
> #endif
>
> i think most arches will be this way
> -mike
>

I'm not sure for this because I've found there exists different
configurations for other
architectures in Linux.
For example,
../../../arch/arm/include/asm/linkage.h:4:#define __ALIGN .align 0
../../../arch/arm/include/asm/linkage.h:5:#define __ALIGN_STR ".align 0"
../../../arch/avr32/include/asm/linkage.h:4:#define __ALIGN .balign 2
../../../arch/avr32/include/asm/linkage.h:5:#define __ALIGN_STR ".balign 2"
../../../arch/score/include/asm/linkage.h:4:#define __ALIGN .align 2
../../../arch/score/include/asm/linkage.h:5:#define __ALIGN_STR ".align 2"

--

-- 
Best regards,

Re: [PATCH 1/2] nds32: add linkage support

On Wednesday 30 November 2011 21:29:02 Macpaul Lin wrote:
> 2011/12/1 Mike Frysinger <vapier <at> gentoo.org>
> > On Wednesday 30 November 2011 03:06:42 Macpaul Lin wrote:
> > > Add linkage support.
> > 
> > let's add this to our linux/linkage.h:
> > #ifndef __ALIGN
> > #define __ALIGN     .align 4
> > #define __ALIGN_STR ".align 4"
> > #endif
> > 
> > i think most arches will be this way
> 
> I'm not sure for this because I've found there exists different
> configurations for other
> architectures in Linux.

more than half will use ".align 4".  for the few that do not, they can still 
define __ALIGN themselves, and thus the "#ifndef __ALIGN" i quoted above will 
keep it from executing.
-mike

_______________________________________________
U-Boot mailing list
U-Boot <at> lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [PATCH 1/2] nds32: add linkage support

Hi Mike,

> more than half will use ".align 4".  for the few that do not, they can
> still
> define __ALIGN themselves, and thus the "#ifndef __ALIGN" i quoted above
> will
> keep it from executing.
> -mike
>

Good! I will fix this up ASAP. 

--

-- 
Best regards,
Macpaul Lin

_______________________________________________
U-Boot mailing list
U-Boot <at> lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

use mx5 ehci usb support patch, but just 1 port detected

 I see wolfgang patch for mx51 usb support, i use it at mx51-bbg platform. i run usb start at u-boot command
line, it ouput:

(Re)start USB...
USB:  
will, usb init....
Register 10011 NbrPorts 1
USB EHCI 1.00
scanning bus for devices... New Device 0
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x100 index 0x0 length 0x40
set address 1
usb_control_msg: request: 0x5, requesttype: 0x0, value 0x1 index 0x0 length 0x0
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x100 index 0x0 length 0x12
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x200 index 0x0 length 0x9
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x200 index 0x0 length 0x19
get_conf_no 0 Result 25, wLength 25
if 0, ep 0
##EP epmaxpacketin[1] = 8
set configuration 1
usb_control_msg: request: 0x9, requesttype: 0x0, value 0x1 index 0x0 length 0x0
new device strings: Mfr=1, Product=2, SerialNumber=0
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x300 index 0x0 length 0xFF
USB device number 1 default language ID 0x1
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x301 index 0x1 length 0xFF
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x302 index 0x1 length 0xFF
Manufacturer u-boot
Product      EHCI Host Controller
SerialNumber
USB hub found
usb_control_msg: request: 0x6, requesttype: 0xA0, value 0x2900 index 0x0 length 0x4

[PATCH v2] linkage.h: move from blackfin to common includes

1. Add linkage.h support from blackfin to common include,
   which is a reduced version from Linux.
2. Add architecture part support of linkage.h into blackfin
3. Fix include path of in blackfin related to linkage.h
   due to header file movement.

Signed-off-by: Macpaul Lin <macpaul <at> andestech.com>
---
Changes for v2:
  - add default value of align is 4.
  - remove architecture related define of align.
  - remain this empty file for the compilation necessary.
  - squash 3 patches into one to avoid bisect problem.

 arch/blackfin/cpu/cache.S                          |    2 +-
 arch/blackfin/include/asm/blackfin_local.h         |    2 +-
 arch/blackfin/include/asm/cache.h                  |    2 +-
 arch/blackfin/include/asm/linkage.h                |   50 +-------------------
 arch/blackfin/lib/__kgdb.S                         |    2 +-
 arch/blackfin/lib/outs.S                           |    2 +-
 .../include/asm => include/linux}/linkage.h        |    1 +
 7 files changed, 8 insertions(+), 53 deletions(-)
 copy {arch/blackfin/include/asm => include/linux}/linkage.h (98%)

diff --git a/arch/blackfin/cpu/cache.S b/arch/blackfin/cpu/cache.S
index 6ed655a..1e468ee 100644
--- a/arch/blackfin/cpu/cache.S
+++ b/arch/blackfin/cpu/cache.S
 <at>  <at>  -8,9 +8,9  <at>  <at> 
  * Licensed under the GPL-2 or later.

[PATCH v2 1/2] nds32: add linkage support

Add linkage support.

Signed-off-by: Macpaul Lin <macpaul <at> andestech.com>
---
Changes for v2:
  - remove architecture related define of align.
  - remain this empty file for the compilation necessary.

 arch/nds32/include/asm/linkage.h |   28 ++++++++++++++++++++++++++++
 1 files changed, 28 insertions(+), 0 deletions(-)
 create mode 100644 arch/nds32/include/asm/linkage.h

diff --git a/arch/nds32/include/asm/linkage.h b/arch/nds32/include/asm/linkage.h
new file mode 100644
index 0000000..6d4493a
--- /dev/null
+++ b/arch/nds32/include/asm/linkage.h
 <at>  <at>  -0,0 +1,28  <at>  <at> 
+/*
+ * U-boot - linkage.h
+ *
+ * Copyright (c) 2005-2007 Analog Devices Inc.
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.