Re: [PATCH v2 3/4] EHCI: adjust for mx5

> Add macros and structures needed by Efika USB support code.
> Move shared offset and bits definitions into common header file.
> 
> Signed-off-by: Jana Rapava <fermata7 <at> gmail.com>
> Cc: Marek Vasut <marek.vasut <at> gmail.com>
> Cc: Remy Bohmer <linux <at> bohmer.net>
> Cc: Stefano Babic <sbabic <at> denx.de>
> Cc: Igor Grinberg <grinberg <at> compulab.co.il>
> ---
> Changes for v2:
> 	- whitespace and coding style changes (no actual changes)

Do you see the contradiction here ?

M

Re: Conflicting definitions of flush_dcache

On 11/01/2011 02:32 AM, Mike Frysinger wrote:
> On Monday 31 October 2011 03:56:25 Stefan Kristiansson wrote:
>> so my gut feeling is that nios2 and the 2 ethernet drivers should be
>> changed to use for example flush_dcache_range(?)
>
> correct

Thanks. I will fix the nios2 and the two net drivers to use 
flush_dcache_range(?).

- Thomas

>
>> Perhaps cmd_cache.c should also be fixed to use flush_dcache_all()?
>> flush_icache() ofcourse suffer from the same problem.
>
> that sounds reasonable.  the prototypes also need to get added to
> include/common.h ...
> -mike
>
>
>
> _______________________________________________
> U-Boot mailing list
> U-Boot <at> lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

Re: [PATCH] The type expected by %zd is ssize_t, but it was being passed a size_t.

This was necessary at one point, but I've been trying to get that warning
to happen again so I can add it to the change message and it won't. These
early patches were done 5 or 6 months ago with a different version of the
repository, a different compiler, on a different system, etc., so it'd be
tricky to figure out exactly what was triggering this before.

I think the changed version is genuinely more correct, but since I can't
get gcc to complain now it doesn't seem like that serious a problem. I'd
say take it or leave it as you see fit, and I'll try a few more things to
see if I can get it to happen again.

Gabe

On Fri, Oct 28, 2011 at 4:23 PM, Mike Frysinger <vapier <at> gentoo.org> wrote:

> generally the subject/changelog should be more of the form:
>
> cmd_nvedit: fix printf warning
>
> gcc warns when using %zd with size_t types since the correct format is %zu:
>  <insert gcc warning here>
>
> otherwise, the change (in theory) makes perfect sense to me ... i
> would ack if not for the commit summary/log ;)
> -mike
>

_______________________________________________
U-Boot mailing list

[PATCH] powerpc/85xx: Add support for Book-E MMU Arch v2.0

A few of the config registers changed definition between MMU v1.0 and
MMUv2.0.  The new e6500 core from Freescale implements v2.0 of the
architecture.

Specifically, how we determine the size of TLB entries we support in the
variable size (or TLBCAM/TLB1) array is specified in a new register
(TLBnPS - TLB n Page size) instead of via TLBnCFG.

Signed-off-by: Kumar Gala <galak <at> kernel.crashing.org>
---
 arch/powerpc/cpu/mpc85xx/tlb.c       |   12 ++++++++----
 arch/powerpc/include/asm/processor.h |    6 ++++++
 2 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/arch/powerpc/cpu/mpc85xx/tlb.c b/arch/powerpc/cpu/mpc85xx/tlb.c
index 01a3561..80ad04a 100644
--- a/arch/powerpc/cpu/mpc85xx/tlb.c
+++ b/arch/powerpc/cpu/mpc85xx/tlb.c
 <at>  <at>  -252,16 +252,20  <at>  <at>  setup_ddr_tlbs_phys(phys_addr_t p_addr, unsigned int memsize_in_meg)
 	unsigned int tlb_size;
 	unsigned int wimge = 0;
 	unsigned int ram_tlb_address = (unsigned int)CONFIG_SYS_DDR_SDRAM_BASE;
-	unsigned int max_cam = (mfspr(SPRN_TLB1CFG) >> 16) & 0xf;
+	unsigned int max_cam;
 	u64 size, memsize = (u64)memsize_in_meg << 20;

 #ifdef CONFIG_SYS_PPC_DDR_WIMGE
 	wimge = CONFIG_SYS_PPC_DDR_WIMGE;
 #endif
 	size = min(memsize, CONFIG_MAX_MEM_MAPPED);

Re: [PATCH 2/3] nds32: cache: define ARCH_DMA_MINALIGN for DMA buffer alignment

Hi Mike,

2011/10/31 Mike Frysinger <vapier <at> gentoo.org>:
> On Friday 28 October 2011 00:46:38 馬克泡 wrote:
> you've got a maintainer tree now:
>        http://git.denx.de/?p=u-boot/u-boot-nds32.git
>
> so you should be gathering all the NDS32 patches and pushing to wolfgang.
> please see the documentation here for the process:
>        http://www.denx.de/wiki/U-Boot/DevelopmentProcess
>
> short answer:
>        - fixes should get pushed at any time
>        - everything else should get pushed during merge window
> -mike
>

Thanks for your hint.
Will do patch collections soon.

--

-- 
Best regards,
Macpaul Lin
_______________________________________________
U-Boot mailing list
U-Boot <at> lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[PATCH] cmd_cache: use cache/invalidate functions available in common.h

flush_dcache()/flush_icache() aren't defined in common.h,
flush_dcache_all()/invalidate_icache_all() however are.

Let the icache and dcache commands use those instead.

Signed-off-by: Stefan Kristiansson <stefan.kristiansson <at> saunalahti.fi>
---
 common/cmd_cache.c |   16 ++++++++--------
 1 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/common/cmd_cache.c b/common/cmd_cache.c
index 9778d3b..360136c 100644
--- a/common/cmd_cache.c
+++ b/common/cmd_cache.c
 <at>  <at>  -30,10 +30,10  <at>  <at> 

 static int parse_argv(const char *);

-void __weak flush_icache(void)
+void __weak invalidate_icache_all(void)
 {
-	/* please define arch specific flush_icache */
-	puts("No arch specific flush_icache available!\n");
+	/* please define arch specific invalidate_icache_all */
+	puts("No arch specific invalidate_icache_all available!\n");
 }

 int do_icache ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 <at>  <at>  -45,7 +45,7  <at>  <at>  int do_icache ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 			break;

Re: [PATCH 1/3] nds32: Use getenv_ulong() in place of getenv(), strtoul

Hi Macpaul,

2011/10/24 Macpaul Lin <macpaul <at> andestech.com>:
> This changes the board code to use the new getenv_ulong() function.
>
> Signed-off-by: Macpaul Lin <macpaul <at> andestech.com>
> ---
>  arch/nds32/lib/board.c |   12 ++----------
>  1 files changed, 2 insertions(+), 10 deletions(-)

Applied to u-boot-nds32/master, thanks.

Best regards,
Macpaul Lin

Re: [PATCH 2/3] nds32: cache: define ARCH_DMA_MINALIGN for DMA buffer alignment

Hi Macpaul,

2011/10/25 Anton Staaf <robotboy <at> chromium.org>:
> On Mon, Oct 24, 2011 at 2:46 AM, Macpaul Lin <macpaul <at> andestech.com> wrote:
>> Add ARCH_DMA_MINALIGN definition to asm/cache.h
>>
>> Signed-off-by: Macpaul Lin <macpaul <at> andestech.com>
>
> Acked-by: Anton Staaf <robotboy <at> chromium.org>
>

Applied to u-boot-nds32/master, thanks.

Best regards,
Macpaul Lin

Re: [PATCH] Move the SC520 specific pci.h header into an sc520 directory.

Hi Gabe,

On Mon, Oct 31, 2011 at 4:23 PM, Gabe Black <gabeblack <at> google.com> wrote:
> Ok, never mind then. I'm using a script Simon Glass wrote to prepare patches
> for submission, so that option will probably need to be added there.
> Gabe

Yes he should probably add --find-renames to the script!

Regards,
Simon

>
> On Fri, Oct 28, 2011 at 9:00 PM, Graeme Russ <graeme.russ <at> gmail.com> wrote:
>>
>> Gabe,
>>
>> I have already submitted a patch for this:
>>
>> http://patchwork.ozlabs.org/patch/120011/
>>
>> Also, you patch does a delete then create rather than a file rename - When
>> you use git-format-patch, use the --find-renames option
>>
>> Regards,
>>
>> Graeme
>>
>> On 29/10/11 09:34, Gabe Black wrote:
>> > The arch/i386/include/asm/ic/pci.h header file include definitions which