headers
Frans Meulenbroeks | 1 Aug 2010 10:10
Picon

[PATCH] board/purple/flash.c: removed unneded variable

removed a variable that was not used

Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks <at> gmail.com>
---

This supersedes 0001-board-purple-flash.c-removed-unneded-test.patch submitted yesterday

 board/purple/flash.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/board/purple/flash.c b/board/purple/flash.c
index 37c7bec..5cee35e 100644
--- a/board/purple/flash.c
+++ b/board/purple/flash.c
 <at>  <at>  -448,7 +448,6  <at>  <at>  int	flash_erase (flash_info_t *info, int s_first, int s_last)
 	FPWV *addr;
 	int flag, prot, sect;
 	ulong start, now, last;
-	int rcode = 0;
 	FUNCPTR_WR absEntry;

 	load_cmd(IN_RAM_CMD_WRITE);
 <at>  <at>  -490,7 +489,7  <at>  <at>  int	flash_erase (flash_info_t *info, int s_first, int s_last)
 	last  = get_timer(0);

 	/* Start erase on unprotected sectors */
-	for (sect = s_first; sect<=s_last && rcode == 0; sect++) {
+	for (sect = s_first; sect<=s_last; sect++) {

 		if (info->protect[sect] != 0)	/* protected, skip it */
(Continue reading)

Permalink | Reply | 3 comments |
headers
Sergei Shtylyov | 1 Aug 2010 11:01

Re: [PATCH] board/purple/flash.c: removed unneded variable

Hello.

Frans Meulenbroeks wrote:

> removed a variable that was not used

> Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks <at> gmail.com>

[...]

> diff --git a/board/purple/flash.c b/board/purple/flash.c
> index 37c7bec..5cee35e 100644
> --- a/board/purple/flash.c
> +++ b/board/purple/flash.c
[...]
>  <at>  <at>  -490,7 +489,7  <at>  <at>  int	flash_erase (flash_info_t *info, int s_first, int s_last)
>  	last  = get_timer(0);
>  
>  	/* Start erase on unprotected sectors */
> -	for (sect = s_first; sect<=s_last && rcode == 0; sect++) {
> +	for (sect = s_first; sect<=s_last; sect++) {

    High time to insert space before and after <=...

WBR, Sergei
Permalink | Reply | 1 comment |
headers
Remy Bohmer | 1 Aug 2010 12:45

Re: [PATCH 4/5] usb_storage.c: change progress output in debug() message

Hi Wolfgang,

>> Turn the progress output into a debug message.
>>
>> Signed-off-by: Wolfgang Denk <wd <at> denx.de>
>> Cc: Remy Bohmer <linux <at> bohmer.net>
>> ---
>>  common/usb_storage.c |    6 +++---
>>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> Applied.
>
> Remy, I hope this is OK with you?

Fine with me.
Thanks.

Remy
Permalink | Reply | 0 comments |
headers
Remy Bohmer | 1 Aug 2010 12:46

Re: [PATCH 1/5] usb_storage.c: initialize device type

Hi,

2010/7/24 Wolfgang Denk <wd <at> denx.de>:
> Dear Wolfgang Denk,
>
> In message <1279532220-5848-2-git-send-email-wd <at> denx.de> you wrote:
>> The device type was left uninitialized which caused later tests
>> against DEV_TYPE_UNKNOWN to fail. In the result, "usb part" would
>> attempt to print information about non-existent devices like this:
>> Signed-off-by: Wolfgang Denk <wd <at> denx.de>
>> Cc: Remy Bohmer <linux <at> bohmer.net>
>>
>> ---
>>  common/usb_storage.c |    3 ++-
>>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> Applied.
>
> Remy, I hope this is OK with you?

OK with me.
Thanks.

Remy
Permalink | Reply | 0 comments |
headers
Remy Bohmer | 1 Aug 2010 13:06

Re: [PATCH 22/28] SPEAr : High speed support for designware peripheral

Hi,

2010/7/14 Vipin KUMAR <vipin.kumar <at> st.com>:
> From: Vipin KUMAR <vipin.kumar <at> st.com>
>
> This patch adds the support for usb device high speed for designware peripheral.
>
> Signed-off-by: Vipin Kumar <vipin.kumar <at> st.com>
> ---
>  drivers/usb/gadget/designware_udc.c |   13 +++++++++----
>  include/usb/designware_udc.h        |    3 +++
>  2 files changed, 12 insertions(+), 4 deletions(-)

Acked-by: Remy Bohmer <linux <at> bohmer.net>
Permalink | Reply | 0 comments |
headers
Remy Bohmer | 1 Aug 2010 13:08

Re: [PATCH 12/28] SPEAr : USB Device Controller driver support added

Hi,

2010/7/14 Vipin KUMAR <vipin.kumar <at> st.com>:
> From: Vipin KUMAR <vipin.kumar <at> st.com>
>
> The earlier usb device controller driver was specific to spear platforms. This
> patch implements the usb device controller driver as a generic controller which
> can be reused by other platforms using this peripheral.
>
> Signed-off-by: Vipin Kumar <vipin.kumar <at> st.com>
> ---
>  drivers/serial/usbtty.h                            |    4 +-
>  drivers/usb/gadget/Makefile                        |    2 +-
>  drivers/usb/gadget/{spr_udc.c => designware_udc.c} |   57 ++++++++++----------
>  include/configs/spear-common.h                     |    4 +-
>  include/usb/{spr_udc.h => designware_udc.h}        |    6 +-
>  5 files changed, 37 insertions(+), 36 deletions(-)
>  rename drivers/usb/gadget/{spr_udc.c => designware_udc.c} (94%)
>  rename include/usb/{spr_udc.h => designware_udc.h} (98%)

Acked-by: Remy Bohmer <linux <at> bohmer.net>
Permalink | Reply | 0 comments |
headers
Remy Bohmer | 1 Aug 2010 13:11

Re: [PATCH 17/28] SPEAr : USB device controller bugfixes

Hi,

2010/7/14 Vipin KUMAR <vipin.kumar <at> st.com>:
> From: Vipin KUMAR <vipin.kumar <at> st.com>
>
> This patch fixes a few bugs in USB device controller driver.
> The fixes are as follows
> 1. Adding error condition checks eg. NULL return
> 2. Endpoint other than endpoint 0 (control endpoint) are initialized
> only if usb state machine reaches STATE_ADDRESSED or above
> 3. Zero length packet handling corrected
> 4. Dead code removed
> 5. Bulk out endpoint returns after servicing 1 interrupt and returns
> back to service if more interrupts are pending
>
> Signed-off-by: Vipin Kumar <vipin.kumar <at> st.com>
> ---
>  drivers/usb/gadget/designware_udc.c |   59 ++++++++++++++++++++++------------
>  1 files changed, 38 insertions(+), 21 deletions(-)

Acked-by: Remy Bohmer <linux <at> bohmer.net>
Permalink | Reply | 0 comments |
headers
Remy Bohmer | 1 Aug 2010 13:16

Re: [PATCH 3/4 v2] musb: am35x: Workaround for fifo read issue

Hi,

2010/7/9 Ajay Kumar Gupta <ajay.gupta <at> ti.com>:
> AM35x supports only 32bit read operations so we need to have
> workaround for 8bit and 16bit read operations.
>
> Signed-off-by: Ajay Kumar Gupta <ajay.gupta <at> ti.com>
> ---
>  drivers/usb/musb/am35x.c     |   32 ++++++++++++++++++++++++++++++++
>  drivers/usb/musb/musb_core.c |    6 ++++++
>  2 files changed, 38 insertions(+), 0 deletions(-)

Acked-by: Remy Bohmer <linux <at> bohmer.net>
Permalink | Reply | 0 comments |
headers
Remy Bohmer | 1 Aug 2010 13:16

Re: [PATCH 2/4 v2] musb: MSC host support for AM35x

Hi,

2010/7/9 Ajay Kumar Gupta <ajay.gupta <at> ti.com>:
> Tested MSC Host on AM3517EVM.
>
> Signed-off-by: Ajay Kumar Gupta <ajay.gupta <at> ti.com>
> ---
>  drivers/usb/musb/Makefile   |    1 +
>  drivers/usb/musb/am35x.c    |  118 +++++++++++++++++++++++++++++++++++++++++++
>  drivers/usb/musb/am35x.h    |   94 ++++++++++++++++++++++++++++++++++
>  drivers/usb/musb/musb_udc.c |    2 +
>  include/usb.h               |    2 +-
>  5 files changed, 216 insertions(+), 1 deletions(-)
>  create mode 100644 drivers/usb/musb/am35x.c
>  create mode 100644 drivers/usb/musb/am35x.h

Acked-by: Remy Bohmer <linux <at> bohmer.net>
Permalink | Reply | 3 comments |
headers
Frans Meulenbroeks | 1 Aug 2010 13:31
Picon

Re: [PATCH] board/purple/flash.c: removed unneded variable

2010/8/1 Sergei Shtylyov <sshtylyov <at> mvista.com>

> Hello.
>
>
> Frans Meulenbroeks wrote:
>
>  removed a variable that was not used
>>
>
>  Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks <at> gmail.com>
>>
>
> [...]
>
>
>  diff --git a/board/purple/flash.c b/board/purple/flash.c
>> index 37c7bec..5cee35e 100644
>> --- a/board/purple/flash.c
>> +++ b/board/purple/flash.c
>>
> [...]
>
>   <at>  <at>  -490,7 +489,7  <at>  <at>  int flash_erase (flash_info_t *info, int s_first, int
>> s_last)
>>        last  = get_timer(0);
>>        /* Start erase on unprotected sectors */
>> -       for (sect = s_first; sect<=s_last && rcode == 0; sect++) {
>> +       for (sect = s_first; sect<=s_last; sect++) {
>>
(Continue reading)

Permalink | Reply | 0 comments |

Gmane