headers
Jerry Van Baren | 1 Jul 2009 02:01
Picon

Re: U-book and GPLv3? (fwd)

Jerry Van Baren wrote:
> The discussion has mostly been emotional to date.  Here are some 
> statistics (not necessarily perfect, but pretty close)...
> 
> Total number of files (after removing the .git files):
> $ find . -type f | wc -l
> 6055
> 
> Number of files that are identified as being copyrighted:
> $ grep -l -i -r 'Copyright' * | wc -l
> 5173
> 
> List of files with copyrights:
> $ grep -l -i -r 'Copyright' * | sort > ~/ucopy.txt
> 
> List of all files:
> $ find . -type f | sed 's/.\///' | sort > ~/ufiles.txt
> 
> List of files *WITHOUT* the string "copyright" in them:
> $ comm -3 ~/ufiles.txt ~/ucopy.txt > ~/nocopyright.txt
> 
> Of the above, 130 of the files have the GPL in the header but not the 
> string "copyright" - incomplete headers:
> for file in `cat ~/nocopyright.txt` ; do grep -il 'General Public 
> License' $file ; done | wc -l
> 130
> 
> ---------------------------------------------------------------------

Improving my fingerprinting (thanks, Scott):
(Continue reading)

Permalink | Reply | 0 comments |
headers
Alessio Centazzo | 1 Jul 2009 05:40
Picon
Favicon

[PATCH] ppc4xx: Fixed PPC4xx debug compilation error in uic.c


This patch fixes a debug compilation error for PPC4xx platforms, all
other architectures are not affected by this change.  The 'handler'
pointer was undefined.  The fix is exercised and has effect only if
DEBUG is defined.

Signed-off-by: Alessio Centazzo acpatin <at> yahoo.com
---
 cpu/ppc4xx/uic.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/cpu/ppc4xx/uic.c b/cpu/ppc4xx/uic.c
index a95d1cb..1a370b3 100644
--- a/cpu/ppc4xx/uic.c
+++ b/cpu/ppc4xx/uic.c
 <at>  <at>  -164,7 +164,7  <at>  <at>  void pic_irq_enable(unsigned int vec)
        else if (vec >= 96)
                mtdcr(uic3er, mfdcr(uic3er) | UIC_MASK(vec));

-       debug("Install interrupt for vector %d ==> %p\n", vec, handler);
+       debug("Enable interrupt vector %d\n", vec);
 }

 void pic_irq_disable(unsigned int vec)
--
1.6.0.4
Permalink | Reply | 1 comment |
headers
Alessio Centazzo | 1 Jul 2009 05:43
Picon
Favicon

[PATCH] ppc4xx: Fixed compilation warning in 4xx_enet.c


This patch fixes a compilation warning for some Ethernet PHY-less
PPC4xx platforms (440SPE based ones) and a potential compilation
error for 440SP platforms (use of undefined 'ethgroup' variable).
In the original code and in case of 440SPE platforms, 'ethgroup'
is initialized to -1 and never modified.  Later in the function,
within an #ifdef statement, an 'if statement' executes code only
if 'ethgroup' is set to 4, therefore it is harmless to avoid
executing the 'if statement' by removing the CONFIG_440SPE from
the affected #ifdefs.  In case of 440SP platforms  with on-board
Ethernet PHY, 'ethgroup' is undefined but used (there are not such
platforms in the repository yet). All other architectures are not
affected by this change.  This is the current warning message with
a Ethernet PHY-less 440SPE platform build (there is not such
platform in the repository yet):

4xx_enet.c: In function 'ppc_4xx_eth_init':
4xx_enet.c:880: warning: unused variable 'ethgroup'

Signed-off-by: Alessio Centazzo acpatin <at> yahoo.com
---
 drivers/net/4xx_enet.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/net/4xx_enet.c b/drivers/net/4xx_enet.c
index 587605d..c020048 100644
--- a/drivers/net/4xx_enet.c
+++ b/drivers/net/4xx_enet.c
 <at>  <at>  -870,7 +870,7  <at>  <at>  static int ppc_4xx_eth_init (struct eth_device *dev, bd_t * bis)
     defined(CONFIG_405EX)
(Continue reading)

Permalink | Reply | 1 comment |
headers
Magnus Lilja | 1 Jul 2009 07:48
Picon

Re: [PATCH v4 6/6] MX31: Add NAND SPL boot support to i.MX31 PDK board.

Hi

2009/6/30 Scott Wood <scottwood <at> freescale.com>:
> Jean-Christophe PLAGNIOL-VILLARD wrote:
>>>>>
>>>>> +ifeq ($(debug),1)
>>>>> +PLATFORM_CPPFLAGS += -DDEBUG
>>>>> +endif
>>>>
>>>> I do not think it's board specific
>>>
>>> And what does that comment mean? Should I remove this, move it to
>>> another file or what?
>>>
>> Personnaly I'll active it manually in the file not via a CPPFLAGS
>> as it will result to active all bebug
>>
>> Scott what do you think?
>
> I don't think we should do anything differently from the rest of U-Boot
> here.

Well, that's not easy since the rest of U-boot does it in different
ways, i.e. some boards have the debug stuff and some don't. As an
example all boards in nand_spl/board/{amcc,samsung}/* have that while
the rest don't have it.

Regards, Magnus Lilja
Permalink | Reply | 2 comments |
headers
Thomas Dörfler | 1 Jul 2009 07:58
Picon
Favicon

Re: U-book and GPLv3? (fwd)

Richard,

Richard Stallman wrote:

> 
> While I probably would not want to change my glucometer, the practice
> of designing hardware so that people cannot change it is becoming more
> and more of a threat to our freedom in general.

Can you be a bit more specific on this? Which devices are you aware of,
that use GPLv2 code and avoid an update? Except the once we were
discussing here where it is questionable wheter the user actual should
refrain from doing so, like medical devices and safety critical devices?

We heard about Tivo, but what other devices are there? Or are we talking
about a possibility which has already outworn itself (like DRM media,
which seem to be getting more and more unpolular)?

wkr,
Thomas.

--

-- 

--------------------------------------------
Embedded Brains GmbH
Thomas Doerfler        Obere Lagerstrasse 30
D-82178 Puchheim       Germany
email: Thomas.Doerfler <at> embedded-brains.de
Phone: +49-89-18908079-2
Fax:   +49-89-18908079-9
(Continue reading)

Permalink | Reply | 8 comments |
headers
Stefano Babic | 1 Jul 2009 08:33
Picon
Picon
Favicon

[PATCH] xscale: fix USB initialization for Trizepsiv module

Due to change in the usb_board_init() prototype, the USB for
the TrizepsIV was not correctly initialized.
Removed dummy print from usb_board_stop().

Signed-off-by: Stefano Babic <sbabic <at> denx.de>
---
 board/trizepsiv/conxs.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/board/trizepsiv/conxs.c b/board/trizepsiv/conxs.c
index 4249e3d..8c11456 100644
--- a/board/trizepsiv/conxs.c
+++ b/board/trizepsiv/conxs.c
 <at>  <at>  -55,7 +55,7  <at>  <at>  extern struct serial_device serial_stuart_device;
  * Miscelaneous platform dependent initialisations
  */

-void usb_board_init(void)
+int usb_board_init(void)
 {
 	UHCHR = (UHCHR | UHCHR_PCPL | UHCHR_PSPL) &
 		~(UHCHR_SSEP0 | UHCHR_SSEP1 | UHCHR_SSEP2 | UHCHR_SSE);
 <at>  <at>  -76,6 +76,8  <at>  <at>  void usb_board_init(void)

 	/* Set port power control mask bits, only 3 ports. */
 	UHCRHDB |= (0x7<<17);
+
+	return 0;
 }
(Continue reading)

Permalink | Reply | 2 comments |
headers
Stefano Babic | 1 Jul 2009 08:34
Picon
Picon
Favicon

[PATCH] xscale: add support for the polaris board

The Polaris board is based on the TrizepsIV module of
Keith & Koep (http://www.keith-koep.com).

Signed-off-by: Stefano Babic <sbabic <at> denx.de>
---
 MAINTAINERS                 |    5 +++++
 MAKEALL                     |    2 ++
 Makefile                    |    7 ++++++-
 board/trizepsiv/conxs.c     |   22 ++++++++++++----------
 include/configs/trizepsiv.h |   25 ++++++++++++++++++++++---
 5 files changed, 47 insertions(+), 14 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 9379c7e..7cc26db 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
 <at>  <at>  -500,6 +500,11  <at>  <at>  Rowel Atienza <rowel <at> diwalabs.com>

 	armadillo	ARM720T

+Stefano Babic <sbabic <at> denx.de>
+
+	polaris		xscale
+	trizepsiv	xscale
+
 Dirk Behme <dirk.behme <at> gmail.com>

 	omap3_beagle	ARM CORTEX-A8 (OMAP3530 SoC)
diff --git a/MAKEALL b/MAKEALL
index f4599d6..c127472 100755
(Continue reading)

Permalink | Reply | 0 comments |
headers
Stefan Roese | 1 Jul 2009 09:19
Picon
Picon
Favicon

Re: [PATCH] ppc4xx: Fixed PPC4xx debug compilation error in uic.c

On Wednesday 01 July 2009 05:40:53 Alessio Centazzo wrote:
> This patch fixes a debug compilation error for PPC4xx platforms, all
> other architectures are not affected by this change.  The 'handler'
> pointer was undefined.  The fix is exercised and has effect only if
> DEBUG is defined.

Unfortunately this still doesn't apply. Now I checked why this is the case 
(with such a "simple" patch). And it seems that you have a whitespace issue. 
Please see below.

> Signed-off-by: Alessio Centazzo acpatin <at> yahoo.com
> ---
>  cpu/ppc4xx/uic.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/cpu/ppc4xx/uic.c b/cpu/ppc4xx/uic.c
> index a95d1cb..1a370b3 100644
> --- a/cpu/ppc4xx/uic.c
> +++ b/cpu/ppc4xx/uic.c
>  <at>  <at>  -164,7 +164,7  <at>  <at>  void pic_irq_enable(unsigned int vec)
>         else if (vec >= 96)
>                 mtdcr(uic3er, mfdcr(uic3er) | UIC_MASK(vec));

Indentation done via spaces instead of tabs as done in the original file.

>
> -       debug("Install interrupt for vector %d ==> %p\n", vec, handler);
> +       debug("Enable interrupt vector %d\n", vec);

Again, indentation has to be done in tabs. Please fix and resubmit.
(Continue reading)

Permalink | Reply | 0 comments |
headers
Stefan Roese | 1 Jul 2009 09:21
Picon
Picon
Favicon

Re: [PATCH] ppc4xx: Fixed compilation warning in 4xx_enet.c

On Wednesday 01 July 2009 05:43:53 Alessio Centazzo wrote:
> This patch fixes a compilation warning for some Ethernet PHY-less
> PPC4xx platforms (440SPE based ones) and a potential compilation
> error for 440SP platforms (use of undefined 'ethgroup' variable).
> In the original code and in case of 440SPE platforms, 'ethgroup'
> is initialized to -1 and never modified.  Later in the function,
> within an #ifdef statement, an 'if statement' executes code only
> if 'ethgroup' is set to 4, therefore it is harmless to avoid
> executing the 'if statement' by removing the CONFIG_440SPE from
> the affected #ifdefs.  In case of 440SP platforms  with on-board
> Ethernet PHY, 'ethgroup' is undefined but used (there are not such
> platforms in the repository yet). All other architectures are not
> affected by this change.  This is the current warning message with
> a Ethernet PHY-less 440SPE platform build (there is not such
> platform in the repository yet):
>
> 4xx_enet.c: In function 'ppc_4xx_eth_init':
> 4xx_enet.c:880: warning: unused variable 'ethgroup'

Same issue here. Still doesn't apply. Most like again a whitespace issue (tabs 
vs spaces). Please fix and resubmit.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
(Continue reading)

Permalink | Reply | 0 comments |
headers
Felix Radensky | 1 Jul 2009 10:37

[PATCH] 4xx: Fix compilation warnings and MQ registers dump in SPD DDR2 code

This patch fixes printf format string compilation warnings in several
debug statements. It also fixes the dump of DDR controller MQ registers
found on some 44x and 46x platforms. The current register dump code
uses incorrect DCRs to access these registers.

Signed-off-by: Felix Radensky <felix <at> embedded-sol.com>
---
 cpu/ppc4xx/44x_spd_ddr2.c |   42 +++++++++++++++++++++++++-----------------
 1 files changed, 25 insertions(+), 17 deletions(-)

diff --git a/cpu/ppc4xx/44x_spd_ddr2.c b/cpu/ppc4xx/44x_spd_ddr2.c
index 33788cc..2ab2336 100644
--- a/cpu/ppc4xx/44x_spd_ddr2.c
+++ b/cpu/ppc4xx/44x_spd_ddr2.c
 <at>  <at>  -60,6 +60,14  <at>  <at> 
 		       "SDRAM_" #mnemonic, SDRAM_##mnemonic, data);	\
 	} while (0)

+#define PPC4xx_IBM_DDR2_DUMP_MQ_REGISTER(mnemonic)			\
+	do {								\
+		u32 data;						\
+		data = mfdcr(SDRAM_##mnemonic);				\
+		printf("%20s[%02x] = 0x%08X\n",				\
+		       "SDRAM_" #mnemonic, SDRAM_##mnemonic, data);	\
+	} while (0)
+
 #if defined(CONFIG_440)
 /*
  * This DDR2 setup code can dynamically setup the TLB entries for the DDR2
 <at>  <at>  -714,11 +722,11  <at>  <at>  static void check_mem_type(unsigned long *dimm_populated,
(Continue reading)

Permalink | Reply | 501 comments |

Gmane