headers
Jon Smirl | 1 Jun 2009 01:59
Picon
Gravatar

Re: [PATCH V2] board support patch for phyCORE-MPC5200B-tiny

On Sun, May 31, 2009 at 6:11 PM, Wolfgang Denk <wd <at> denx.de> wrote:
>> +/*---------------------------------------------------------------------------
>> + Environment settings
>> +---------------------------------------------------------------------------*/
>> +#if 0
>> +#define CONFIG_ENV_IS_IN_FLASH       1
>> +#define CONFIG_ENV_ADDR              (CONFIG_SYS_FLASH_BASE + 0xfe0000)
>> +#define CONFIG_ENV_SIZE              0x20000
>> +#define CONFIG_ENV_SECT_SIZE 0x20000
>> +#else
>> +#define CONFIG_ENV_IS_IN_EEPROM      1
>> +#define CONFIG_ENV_OFFSET    0x00    /* environment starts at the */
>> +                                     /*beginning of the EEPROM */
>> +#define CONFIG_ENV_SIZE              CONFIG_SYS_EEPROM_SIZE
>> +#endif
>> +#define CONFIG_ENV_OVERWRITE 1
>
> Are you sure? This is pessimal choice. EEPROM is slow and unreliable.
>
> After you decided for a solution, then please remove the (then) dead
> code.

Phytec ships default with the boards using the EEPROM.
But, I'm with you and I flip the #if to use the FLASH.

Both FLASH and EEPROM work. The flash has 128KB page size which wastes
a lot of space holding a 2KB environment so I see why some people want
to stick with EEPROM.

So I'd like to keep them both in place. Would it be better if the
(Continue reading)

Permalink | Reply | 1 comment |
headers
Nobuhiro Iwamatsu | 1 Jun 2009 03:03
Gravatar

Re: [RFC PATCH 1/2] sh: make lds more generic

Hi, Wolfgang.

2009/5/27 Wolfgang Denk <wd <at> denx.de>:
> Dear Nobuhiro Iwamatsu,
>
> In message <29ab51dc0905262313h17934f09u904a4e7325207148 <at> mail.gmail.com> you wrote:
>> 2009/5/14 Jean-Christophe PLAGNIOL-VILLARD <plagnioj <at> jcrosoft.com>:
>> > currently the sh lds need to sync the lds enty and TEXT_BASE manualy
>> > and the reloc_dst is based on it
>> >
>> > instead provide it now from the ldflags
>> >
>> > tested on r2dplus
>> >
>> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj <at> jcrosoft.com>
>> > Cc: Nobuhiro Iwamatsu <iwamatsu.nobuhiro <at> renesas.com>
>>
>> Appilied these patch collection.
>> Thank you!
>
> Sorry, but I don't agree. The commit message is terrible.
> "sh lds need to sync the lds enty" - what is that suppoosed to mean?
>
> I insist on readable and understandable commit messages.
>
OK , you are right.

Jean-Christophe, please update commit message and resend.

Best regards,
(Continue reading)

Permalink | Reply | 0 comments |
headers
Jon Smirl | 1 Jun 2009 03:05
Picon
Gravatar

Re: [PATCH V2] board support patch for phyCORE-MPC5200B-tiny

On Sun, May 31, 2009 at 6:11 PM, Wolfgang Denk <wd <at> denx.de> wrote:
>> +#define CONFIG_SYS_LOAD_ADDR 0x100000 /* default load address */
>
> This used to be a reasonable choice with Linux 2.4.4; it ain't so any
> more.

What should it be?

--

-- 
Jon Smirl
jonsmirl <at> gmail.com
Permalink | Reply | 1 comment |
headers
Mike Frysinger | 1 Jun 2009 05:17
Picon
Favicon
Gravatar

Pull request u-boot-blackfin.git

The following changes since commit 5520ab1f7685721314dcfb7cdcc7c15e6571473f:
  Wolfgang Denk (1):
        Merge branch 'master' of git://git.denx.de/u-boot-blackfin

are available in the git repository at:

  git://www.denx.de/git/u-boot-blackfin.git master

Mike Frysinger (2):
      Blackfin: fix if() logic in bootrom evt1 check
      Blackfin: spi: fix pin handling of SPI0 SSEL4

 drivers/spi/bfin_spi.c                     |    2 +-
 include/asm-blackfin/blackfin-config-pre.h |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Permalink | Reply | 1 comment |
headers
Ben Warren | 1 Jun 2009 05:48
Picon

[PATCH v3 1/3][Net][ARM] Moved Davinci Ethernet driver to drivers/net

This driver has been renamed davinci_emac.c

Signed-off-by: Ben Warren <biggerbadderben <at> gmail.com>
---

Change in V3: Renamed driver to davinci_emac

 cpu/arm926ejs/davinci/Makefile                     |    2 +-
 drivers/net/Makefile                               |    1 +
 .../davinci/ether.c => drivers/net/davinci_emac.c   |    0 
 3 files changed, 2 insertions(+), 1 deletions(-)
 rename cpu/arm926ejs/davinci/ether.c => drivers/net/davinci_emac.c (100%)

diff --git a/cpu/arm926ejs/davinci/Makefile b/cpu/arm926ejs/davinci/Makefile
index 6eaa89c..e45ad25 100644
--- a/cpu/arm926ejs/davinci/Makefile
+++ b/cpu/arm926ejs/davinci/Makefile
 <at>  <at>  -30,7 +30,7  <at>  <at>  LIB	= $(obj)lib$(SOC).a
 COBJS-y				+= cpu.o timer.o psc.o
 COBJS-$(CONFIG_SOC_DM355)	+= dm355.o
 COBJS-$(CONFIG_SOC_DM644X)	+= dm644x.o
-COBJS-$(CONFIG_DRIVER_TI_EMAC)	+= ether.o lxt972.o dp83848.o
+COBJS-$(CONFIG_DRIVER_TI_EMAC)	+= lxt972.o dp83848.o

 SOBJS	= reset.o

diff --git a/drivers/net/Makefile b/drivers/net/Makefile
index a360a50..26f1ea6 100644
--- a/drivers/net/Makefile
+++ b/drivers/net/Makefile
(Continue reading)

Permalink | Reply | 2 comments |
headers
Ben Warren | 1 Jun 2009 05:48
Picon

[PATCH v3 3/3][Net][ARM] Switched davinci_emac Ethernet driver to use newer API

Added CONFIG_NET_MULTI to all Davinci boards
Removed all calls to Davinci network driver from board code
Added cpu_eth_init() to cpu/arm926ejs/cpu.c

Signed-off-by: Ben Warren <biggerbadderben <at> gmail.com>
---

Change in V3: Renamed driver to davinci_emac

 board/davinci/common/misc.h         |    1 -
 board/davinci/dvevm/dvevm.c         |    3 -
 board/davinci/schmoogie/schmoogie.c |    3 -
 board/davinci/sffsdr/sffsdr.c       |    3 -
 board/davinci/sonata/sonata.c       |    3 -
 cpu/arm926ejs/davinci/cpu.c         |   12 ++++++
 drivers/net/davinci_emac.c           |   70 ++++++++++++-----------------------
 include/configs/davinci_dvevm.h     |    1 +
 include/configs/davinci_schmoogie.h |    1 +
 include/configs/davinci_sffsdr.h    |    1 +
 include/configs/davinci_sonata.h    |    1 +
 include/netdev.h                    |    1 +
 net/eth.c                           |    4 --
 13 files changed, 41 insertions(+), 63 deletions(-)

diff --git a/board/davinci/common/misc.h b/board/davinci/common/misc.h
index 316159a..dc3cc41 100644
--- a/board/davinci/common/misc.h
+++ b/board/davinci/common/misc.h
 <at>  <at>  -22,7 +22,6  <at>  <at> 
 #ifndef __MISC_H
(Continue reading)

Permalink | Reply | 0 comments |
headers
Ben Warren | 1 Jun 2009 05:55
Picon

Re: [PATCH] net: Add Marvell Kirkwood gigabit ethernet driver

Prafulla Wadaskar wrote:
>  
>
>   
>> -----Original Message-----
>> From: Ben Warren [mailto:biggerbadderben <at> gmail.com] 
>> Sent: Saturday, May 30, 2009 4:51 AM
>> To: Jean-Christophe PLAGNIOL-VILLARD
>> Cc: Prafulla Wadaskar; u-boot <at> lists.denx.de; Manas Saksena; 
>> Ronen Shitrit; Nicolas Pitre; Ashish Karkare; Prabhanjan 
>> Sarnaik; Lennert Buijtenhek
>> Subject: Re: [U-Boot] [PATCH] net: Add Marvell Kirkwood 
>> gigabit ethernet driver
>>
>> Jean-Christophe PLAGNIOL-VILLARD wrote:
>>     
>>> On 01:13 Sat 30 May     , Prafulla Wadaskar wrote:
>>>   
>>>       
>>>> This patch adds a egiga driver for the Marvell Kirkwood SoC's.
>>>>
>>>> Contributors:
>>>> Yotam Admon <yotam <at> marvell.com>
>>>> Michael Blostein <michaelbl <at> marvell.com
>>>>
>>>> Reviewed-by: Ronen Shitrit <rshitrit <at> marvell.com>
>>>> Acked-by: Stefan Rose <sr <at> denx.de>
>>>> Signed-off-by: Prafulla Wadaskar <prafulla <at> marvell.com>
>>>>     
>>>>
(Continue reading)

Permalink | Reply | 0 comments |
headers
Ben Warren | 1 Jun 2009 05:48
Picon

[PATCH v3 2/3][Net][ARM] Initial cleanup of Davinci Ethernet driver

 Removed pointless #ifdefs
 Moved functions around in file in preparation for switch to newer API

Signed-off-by: Ben Warren <biggerbadderben <at> gmail.com>
---

Change in V3: Renamed driver to davinci_emac

 drivers/net/davinci_emac.c |  146 +++++++++++++++++++++------------------------
 1 files changed, 69 insertions(+), 77 deletions(-)

diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c
index f6f81df..f5cec05 100644
--- a/drivers/net/davinci_emac.c
+++ b/drivers/net/davinci_emac.c
 <at>  <at>  -42,10 +42,6  <at>  <at> 
 #include <miiphy.h>
 #include <asm/arch/emac_defs.h>

-#ifdef CONFIG_DRIVER_TI_EMAC
-
-#ifdef CONFIG_CMD_NET
-
 unsigned int	emac_dbg = 0;
 #define debug_emac(fmt,args...)	if (emac_dbg) printf(fmt,##args)

 <at>  <at>  -291,77 +287,6  <at>  <at>  int davinci_eth_miiphy_initialize(bd_t *bis)
 }
 #endif
(Continue reading)

Permalink | Reply | 1 comment |
headers
Ben Warren | 1 Jun 2009 06:05
Picon

Re: [PATCH] ppc4xx/net: Fix MDIO clock setup

Hi Felix,

Felix Radensky wrote:
> This patch fixes MDIO clock setup in case when OPB frequency is 100MHz.
> Current code assumes that the value of sysinfo.freqOPB is 100000000
> when OPB frequency is 100MHz. In reality it is 100000001. As a result 
> MDIO clock is set to incorrect value, larger than 2.5MHz, thus violating
> the standard. This in not a problem on boards equipped with Marvell PHYs
> (e.g. Canyonlands), since those PHYs support MDIO clocks up to 8.3MHz, 
> but can be a problem for other PHYs (e.g. Realtek ones).
>
> Signed-off-by: Felix Radensky <felix <at> embedded-sol.com>
>   
Applied to net/next

thanks,
Ben
Permalink | Reply | 501 comments |
headers
Ben Warren | 1 Jun 2009 06:06
Picon

Re: [PATCH/next] Blackfin: bfin_mac: do portmuxing earlier to allow board override

Hi Mike,

Mike Frysinger wrote:
> Some boards may want to undo some pin muxing for the EMAC (like when a
> board doesn't have the RX error interrupt hooked up), but in order to do
> that, we need to do portmuxing during the eth init step.
>
> Signed-off-by: Mike Frysinger <vapier <at> gentoo.org>
> CC: Ben Warren <biggerbadderben <at> gmail.com>
> ---
Applied to net/next.

thanks,
Ben

P.S. - isn't there some way you could move this stuff to board code?
Permalink | Reply | 2 comments |

Gmane