headers
Gururaja Hebbar K R | 1 Aug 2008 02:33
Picon

Re: [PATCH] Correct ARM Versatile Timer Initialization

 Hi,

In message
<5BF78BCE8D9BF14A83F836BD9E3916BA23C1B7 <at> blrms.slti.sanyo.co.in> you
wrote:
>> Hi,
>> 
>> >>  <at>  <at>  -50,8 +50,7  <at>  <at>  static ulong lastdec;  int timer_init (void)  {
>> >>   *(volatile ulong *)(CFG_TIMERBASE + 0) =3D3D CFG_TIMER_RELOAD; 
>> >> /*=20 TimerLoad */
>> >^^^^^^^^^^^^^
>> >> - *(volatile ulong *)(CFG_TIMERBASE + 4) =3D3D CFG_TIMER_RELOAD; 
>> >> /*=20 TimerValue */
>> >^^^^^^^^^^^^^
>> >
>> >Your patch is line-wrapped and cannot be applied.
>> 
>> I Checked the Original Source File & found this.
>> 
>> 	*(volatile ulong *)(CFG_TIMERBASE + 0) =3D CFG_TIMER_RELOAD;
>> /* TimerLoad */  ---> This line ends  <at>  Column 80
>> 	*(volatile ulong *)(CFG_TIMERBASE + 4) =3D CFG_TIMER_RELOAD;
>> /* TimerValue */  ---> This line ends  <at>  Column 81
>> 
>> I just removed the Second Line since it was Invalid.
>>
>> I am really sorry for troubling but i have little issue finding the 
>> mistake.
>> Now in order to remove this, kindly let me know what i have to do.
>
(Continue reading)

Permalink | Reply | 5 comments |
headers
Gururaja Hebbar K R | 1 Aug 2008 02:42
Picon

Re: [PATCH] (Resubmit) ADD ARM AMBA PL031 RTC Support

Hi, 

>Please move such comments *below* the '---' line. Anything ABOVE '---'
>will become the commit message that goes into the repository, only
stuff below the '---' gets ignores as comment.

Yes i will do & re-submit

>>  drivers/rtc/Makefile    |    1 +
>>  drivers/rtc/rtc_pl031.c |  123
+++++++++++++++++++++++++++++++++++++++++++++++
>>  board/versatile/versatile.c |    9 +++++++++
>>  include/configs/versatile.h |    7 +++++++
>
>So this is actually not a single patch, but TWO:
Peter Pearse & Jean-Christophe PLAGNIOL-VILLARD had asked me to the
board details which will be using it. 
So i added it here. I already sent a separate Versatile Board Update
Only Code to Peter Pearse but not received any update from him.

>So please split your patch and submit as two separate patches.
Ok will do that

>> +#if defined(CONFIG_RTC_PL031) && defined(CONFIG_CMD_DATE)
>> +	rtc_init();
>> +#endif
>
>Why do we need the #ifdef's here? It seems this is a board specific
configuration anyway, i. e. we don't expect for example other RTC chips
to be used on this board, or do we?
(Continue reading)

Permalink | Reply | 1 comment |
headers
Tsi-Chung Liew | 1 Aug 2008 02:52
Favicon

[PATCH] Fix compile error caused by incorrect function return type 2

From: TsiChung Liew <Tsi-Chung.Liew <at> freescale.com>

Rename int mii_init(void) to void mii_init(void) for idmr
ColdFire platform

Signed-off-by: TsiChung Liew <Tsi-Chung.Liew <at> freescale.com>
---
 board/idmr/mii.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/board/idmr/mii.c b/board/idmr/mii.c
index f130e6e..78a7028 100644
--- a/board/idmr/mii.c
+++ b/board/idmr/mii.c
 <at>  <at>  -200,7 +200,7  <at>  <at>  int mii_discover_phy(struct eth_device *dev)
 }
 #endif				/* CFG_DISCOVER_PHY */

-int mii_init(void) __attribute__((weak,alias("__mii_init")));
+void mii_init(void) __attribute__((weak,alias("__mii_init")));

 void __mii_init(void)
 {
--

-- 
1.5.6.4

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
(Continue reading)

Permalink | Reply | 1 comment |
headers
Tsi-Chung Liew | 1 Aug 2008 02:52
Favicon

[PATCH] Fix compilation error for MCF5275

From: TsiChung Liew <Tsi-Chung.Liew <at> freescale.com>

Rename OBJ to COBJ in board/platform/Makefile

Signed-off-by: TsiChung Liew <Tsi-Chung.Liew <at> freescale.com>
---
 board/freescale/m5275evb/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/board/freescale/m5275evb/Makefile b/board/freescale/m5275evb/Makefile
index f337a75..74c2528 100644
--- a/board/freescale/m5275evb/Makefile
+++ b/board/freescale/m5275evb/Makefile
 <at>  <at>  -25,7 +25,7  <at>  <at>  include $(TOPDIR)/config.mk

 LIB	= $(obj)lib$(BOARD).a

-OBJS	= $(BOARD).o mii.o
+COBJS	= $(BOARD).o mii.o

 SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
 OBJS	:= $(addprefix $(obj),$(COBJS))
--

-- 
1.5.6.4

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
(Continue reading)

Permalink | Reply | 1 comment |
headers
Tsi-Chung Liew | 1 Aug 2008 02:53
Favicon

[PATCH] Fix compilation error for TASREG

From: TsiChung Liew <Tsi-Chung.Liew <at> freescale.com>

TASREG is ColdFire platform, the include ppc4xx.h in
board/esd/common/flash.c causes conflict.

Signed-off-by: TsiChung Liew <Tsi-Chung.Liew <at> freescale.com>
---
 board/esd/common/flash.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/board/esd/common/flash.c b/board/esd/common/flash.c
index dca10be..bda361e 100644
--- a/board/esd/common/flash.c
+++ b/board/esd/common/flash.c
 <at>  <at>  -22,7 +22,9  <at>  <at> 
  */

 #include <common.h>
+#ifdef __PPC__
 #include <ppc4xx.h>
+#endif
 #include <asm/processor.h>

 flash_info_t	flash_info[CFG_MAX_FLASH_BANKS]; /* info for FLASH chips	*/
--

-- 
1.5.6.4

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
(Continue reading)

Permalink | Reply | 1 comment |
headers
Tsi-Chung Liew | 1 Aug 2008 02:53
Favicon

[PATCH] Fix compilation issue caused by a missing function

From: TsiChung Liew <Tsi-Chung.Liew <at> freescale.com>

Implement usec2ticks() which is used by fsl_i2c.c in
lib_m68k/time.c

Signed-off-by: TsiChung Liew <Tsi-Chung.Liew <at> freescale.com>
---
 lib_m68k/time.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/lib_m68k/time.c b/lib_m68k/time.c
index 28d371d..6eba784 100644
--- a/lib_m68k/time.c
+++ b/lib_m68k/time.c
 <at>  <at>  -199,6 +199,11  <at>  <at>  unsigned long long get_ticks(void)
 	return get_timer(0);
 }

+unsigned long usec2ticks(unsigned long usec)
+{
+	return get_timer(usec);
+}
+
 /*
  * This function is derived from PowerPC code (timebase clock frequency).
  * On M68K it returns the number of timer ticks per second.
--

-- 
1.5.6.4

-------------------------------------------------------------------------
(Continue reading)

Permalink | Reply | 1 comment |
headers
Ryan CHEN | 1 Aug 2008 04:57

Re: [PATCH]:Enable 2D Engine in SM501 to hurry up fresh speed!

Hi  Wolfgang,
I have modified my patch. New macro "CONFIG_SM501_ENABLE_2DENGINE" be
included to specify codes what enable SM501 2D engine. The macro need be
declared in config header file.
Why does it need to enable 2D engine? The reason is most of framebuffer
contents need be moved in VRAM when screen scrolls up. The work be done by
software in current U-Boot for SM501. The patch is to enable 2D engine to do
it by hardware without CPU interference.  

Signed-off-by: Ryan Chen <ryan.chen <at> st.com>

diff --git a/drivers/video/sm501.c b/drivers/video/sm501.c
old mode 100644
new mode 100644
index 23db02c..250e445
--- a/drivers/video/sm501.c
+++ b/drivers/video/sm501.c
 <at>  <at>  -54,6 +54,48  <at>  <at> 
 #define write32(ptrReg, value) \
     (*(volatile unsigned int *)(sm501.isaBase + ptrReg) = value)

+#ifdef CONFIG_SM501_ENABLE_2DENGINE
+/* Register Macroes*/
+#define _F_START(f)             (0 ? f)
+#define _F_END(f)               (1 ? f)
+#define _F_SIZE(f)              (1 + _F_END(f) - _F_START(f))
+#define _F_MASK(f)              (((1 << _F_SIZE(f)) - 1) << _F_START(f))
+#define _F_NORMALIZE(v, f)      (((v) & _F_MASK(f)) >> _F_START(f))
+#define _F_DENORMALIZE(v, f)    (((v) << _F_START(f)) & _F_MASK(f))
+#define FIELD_GET(x, reg, field) \
(Continue reading)

Permalink | Reply | 2 comments |
headers
Ryan CHEN | 1 Aug 2008 05:11

[PATCH]:Enable 2D Engine in SM501!

Hi all,
This patch is part 2 for [PATCH:Enable 2D Engine in SM501]. New macro "CONFIG_SM501_ENABLE_2DENGINE" be
included to specify codes what enable SM501 2D engine. The macro need be declared in config header file.
Why does it need to enable 2D engine? The reason is most of framebuffer contents need be moved in VRAM when
screen scrolls up. The work be done by software in current U-Boot for SM501. The patch is to enable 2D engine
to do it by hardware without CPU interference.  

Signed-off-by: Ryan Chen <ryan.chen <at> st.com>

diff --git a/include/sm501.h b/include/sm501.h
index 3e71dbb..516776f 100644
--- a/include/sm501.h
+++ b/include/sm501.h
 <at>  <at>  -40,6 +40,2213  <at>  <at>  typedef struct {
 	unsigned int Value;
 } SMI_REGS;
 +#ifdef CONFIG_SM501_ENABLE_2DENGINE
+/*
+ *
+ * Definitions for the System Configuration registers.
+ *
+ */
+
+#define SYSTEM_CTRL                                     0x000000
+#define SYSTEM_CTRL_DPMS                                31:30
+#define SYSTEM_CTRL_DPMS_VPHP                           0
+#define SYSTEM_CTRL_DPMS_VPHN                           1
+#define SYSTEM_CTRL_DPMS_VNHP                           2
+#define SYSTEM_CTRL_DPMS_VNHN                           3
+#define SYSTEM_CTRL_PCI_BURST                           29:29
(Continue reading)

Permalink | Reply | 2 comments |
headers
Hebbar | 1 Aug 2008 05:15
Picon

Re: [PATCH] (Resubmit) ADD ARM AMBA PL031 RTC Support


Hi,

>Why do we need the #ifdef's here? It seems this is a board specific
>configuration anyway, i. e. we don't expect for example other RTC chips
>to be used on this board, or do we?

Also I Just Checked u-boot-1.3.3/board/bc3450/bc3450.c. Even here it has 
a declaration for RTC  <at>  line 47

#ifdef CONFIG_RTC_MPC5200
#include <rtc.h>
#endif

 <at>  line 371

#ifdef CONFIG_RTC_MPC5200
	struct rtc_time t;

	/* set to Wed Dec 31 19:00:00 1969 */
	t.tm_sec = t.tm_min = 0;
	t.tm_hour = 19;
	t.tm_mday = 31;
	t.tm_mon = 12;
	t.tm_year = 1969;
	t.tm_wday = 3;

	rtc_set(&t);
#endif /* CONFIG_RTC_MPC5200 */
(Continue reading)

Permalink | Reply | 0 comments |
headers
Gururaja Hebbar K R | 1 Aug 2008 06:50
Picon

Resubmit : [PATCH] Correct ARM Versatile Timer Initialization

Signed-off-by: Gururaja Hebbar <gururajakr <at> sanyo.co.in>
---
 cpu/arm926ejs/versatile/timer.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/cpu/arm926ejs/versatile/timer.c
b/cpu/arm926ejs/versatile/timer.c
index 32872d2..9659b67 100644
--- a/cpu/arm926ejs/versatile/timer.c
+++ b/cpu/arm926ejs/versatile/timer.c
 <at>  <at>  -50,8 +50,7  <at>  <at>  static ulong lastdec;
 int timer_init (void)
 {
 	*(volatile ulong *)(CFG_TIMERBASE + 0) = CFG_TIMER_RELOAD;
/* TimerLoad */
-	*(volatile ulong *)(CFG_TIMERBASE + 4) = CFG_TIMER_RELOAD;
/* TimerValue */
-	*(volatile ulong *)(CFG_TIMERBASE + 8) = 0x8C;
+	*(volatile ulong *)(CFG_TIMERBASE + 8) = 0x80;

 	/* init the timestamp and lastdec value */
 	reset_timer_masked();
--

-- 
1.5.6.4

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
(Continue reading)

Permalink | Reply | 3 comments |

Gmane