headers
David Hough | 1 Aug 03:16

a few patches

Hi,

I've recently been looking to use zinf as my main music player but first 
I've had to fix some bugs and do some customizing, so here are the patches 
i've developed so far

1. The fastforward and rewind keyboard shortcuts try to go past the 
beggining and end of the files, and crash zinf if playing mp3s, ogg files 
seem fine with this for some reason

--- zinfunpatched/ui/zinf/src/ZinfTheme.cpp	2003-05-18 20:56:17.000000000 
+0000
+++ zinf/ui/zinf/src/ZinfTheme.cpp	2003-08-01 00:32:14.000000000 +0000
@@ -1402,22 +1402,26 @@

 void ZinfTheme::StepPosition(int iSteps)
 {
-    string oSeek("Seek");
-    //string oName("Info"), oEmpty("");
+
+	if (m_iFramesSinceSeek > 0) {
     int    iValue, iFrame;
-    m_pWindow->ControlIntValue(oSeek, false, iValue);

+		if ((m_iCurrentSeconds == m_iTotalSeconds) && (iSteps > 0))
+			return;

-    iFrame = (int)(((float)iValue * (float)m_iTotalSeconds) /
-                   ((float)100 * m_fSecondsPerFrame));
+		iValue = m_iCurrentSeconds + iSteps;
(Continue reading)

Permalink | Reply | 3 comments |
headers
Kristian G. Kvilekval | 1 Aug 02:45
Picon
Gravatar

Re: a few patches

Thanks for the patches.  I'll try them out this weekend.

Send any and all patches you've got.   If they
are really big.  Place them on sourceforge
and send a note about what it does to the list.

Thx.

On Thu, 2003-07-31 at 18:16, David Hough wrote:
> Hi,
> 
> I've recently been looking to use zinf as my main music player but first 
> I've had to fix some bugs and do some customizing, so here are the patches 
> i've developed so far
> 
> 1. The fastforward and rewind keyboard shortcuts try to go past the 
> beggining and end of the files, and crash zinf if playing mp3s, ogg files 
> seem fine with this for some reason
> 
> --- zinfunpatched/ui/zinf/src/ZinfTheme.cpp	2003-05-18 20:56:17.000000000 
> +0000
> +++ zinf/ui/zinf/src/ZinfTheme.cpp	2003-08-01 00:32:14.000000000 +0000
> @@ -1402,22 +1402,26 @@
> 
>  void ZinfTheme::StepPosition(int iSteps)
>  {
> -    string oSeek("Seek");
> -    //string oName("Info"), oEmpty("");
> +
> +	if (m_iFramesSinceSeek > 0) {
(Continue reading)

Permalink | Reply | 0 comments |
headers
Kristian Kvilekval | 1 Aug 07:47
Picon
Gravatar

Re: a few patches

Please resend the patch as an attachment. 
It is malformed  (probably by the mailer).

On Thu, 2003-07-31 at 18:16, David Hough wrote:
> Hi,
> 
> I've recently been looking to use zinf as my main music player but first 
> I've had to fix some bugs and do some customizing, so here are the patches 
> i've developed so far
> 
> 1. The fastforward and rewind keyboard shortcuts try to go past the 
> beggining and end of the files, and crash zinf if playing mp3s, ogg files 
> seem fine with this for some reason
> 

-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01
Permalink | Reply | 1 comment |
headers
David Hough | 1 Aug 17:22

Re: a few patches

OK, I've regenerated the patch, and checked it applies cleanly so this 
should work

On 31 Jul 2003 22:47:35 -0700, Kristian Kvilekval <kris <at> cs.ucsb.edu> wrote:

> Please resend the patch as an attachment. It is malformed  (probably by 
> the mailer).
>
>
> On Thu, 2003-07-31 at 18:16, David Hough wrote:
>> Hi,
>>
>> I've recently been looking to use zinf as my main music player but first 
>> I've had to fix some bugs and do some customizing, so here are the 
>> patches i've developed so far
>>
>> 1. The fastforward and rewind keyboard shortcuts try to go past the 
>> beggining and end of the files, and crash zinf if playing mp3s, ogg 
>> files seem fine with this for some reason
>>
>
>
>
>
> -------------------------------------------------------
> This SF.Net email sponsored by: Free pre-built ASP.NET sites including
> Data Reports, E-commerce, Portals, and Forums are available now.
> Download today and enter to win an XBOX or Visual Studio .NET.
> http://aspnet.click- 
> url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01
(Continue reading)

Permalink | Reply | 0 comments |
headers
Kristian Kvilekval | 3 Aug 22:15
Picon
Gravatar

Zinf 2.2.4 released!


Zinf-2.2.4 has been placed on sourceforge.
Please download and give it a spin.

This is a bug fix and enhancement release.

Changes for version 2.2.4
--------------------------------------------------------------------

-  New automake build system (Thanks Andreas!)
-  Better URL handling (as per RFC 1738)
-  Preferences file fixups
-  Authentication in URL support.
-  Initial support for seeking  on streams (not yet).
-  Broswer tree speedups (Micheal Hall))
-  Vorbis locking issues (Ed Sweetman)
-  RMP -> EMP bugfix (again).
-  Play nice with remote playlists from command line
-  Display error in cmdlineUI when no available file(bug #608356)
-  Fix vorbis tag handling (bugs #756372, #774821)
-  Don't go past BOF, EOF (crashes) (David Hough)
-  Stop succession of missing file  error message (David Hough)
-  Remember main window location (David Hough)
-  Update info in main window when skipping song (David Hough)

And many others!

--

-- 
Kristian G. Kvilekval
email:kris <at> cs.ucsb.edu office:(805)893-4276 http://www.cs.ucsb.edu/~kris
(Continue reading)

Permalink | Reply | 0 comments |
headers
Ralf Engels | 3 Aug 22:35
Picon
Picon

[Fwd: Patch for crash with multiple UIs]


Hi,
the following patch solves a problem when specifying multiple UIs on the 
command line.
Segmentation fault because of this line:

-            name = m_argUIList[uiListIndex+1];

I did also a little cleanup on this file.

As my patches get more and bigger I have problems with diff.
Can you please tell me how to do the diff against the cvs? I know that 
there is a mode for this.

Ok, anyway, here is the patch...

--- base/src/player.cpp.old     2003-07-27 19:48:37.000000000 +0200
+++ base/src/player.cpp 2003-07-27 20:00:37.000000000 +0200
@@ -657,7 +657,6 @@
  Player::
  Run()
  {
-   uint32_t    uiListIndex = 0;
     string     name;
     Error     error = kError_NoErr;
     int32_t     uisActivated = 0;
@@ -686,6 +685,7 @@
     bool loadSecondaryUIs = true;

     // which ui should we instantiate first??
(Continue reading)

Permalink | Reply | 3 comments |
headers
Kristian Kvilekval | 3 Aug 23:12
Picon
Gravatar

Re: [Fwd: Patch for crash with multiple UIs]

Thanks for the patch.   I'll check it in the first patch of 2.2.5

Try 'cvs diff -au' from the top level cvs directory.   

On Sun, 2003-08-03 at 13:35, Ralf Engels wrote:
> Hi,
> the following patch solves a problem when specifying multiple UIs on the 
> command line.
> Segmentation fault because of this line:
> 
> -            name = m_argUIList[uiListIndex+1];
> 
> I did also a little cleanup on this file.
> 
> As my patches get more and bigger I have problems with diff.
> Can you please tell me how to do the diff against the cvs? I know that 
> there is a mode for this.
> 
> 
> Ok, anyway, here is the patch...
> 

--

-- 
Kristian G. Kvilekval
email:kris <at> cs.ucsb.edu office:(805)893-4276 http://www.cs.ucsb.edu/~kris

-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
(Continue reading)

Permalink | Reply | 0 comments |
headers
Sam Varshavchik | 3 Aug 23:16

Re: Patch for crash with multiple UIs

Ralf Engels writes:

> Can you please tell me how to do the diff against the cvs? I know that 
> there is a mode for this.

There's nothing special about generating diffs against cvs.  Check out the 
CVS tree into a separate directory, and diff against that.
Permalink | Reply | 1 comment |
headers
Sam Varshavchik | 4 Aug 02:36

id3lib dependency?

Does 2.2.4 require id3lib?  Earlier versions did, but there doesn't seem to 
be the case any more.  Just double checking, if id3lib is no longer required 
I can get rid of the id3lib RPMs.

Zinf 2.2.4 RPMs for Red Hat 9 (including an updated libmusicbrainz) have 
been uploaded.  The rio plugin rpm is experimental and untested.
Permalink | Reply | 1 comment |
headers
Kristian Kvilekval | 4 Aug 04:02
Picon
Gravatar

Re: id3lib dependency?

id3lib is still required.  

On Sun, 2003-08-03 at 17:36, Sam Varshavchik wrote:
> Does 2.2.4 require id3lib?  Earlier versions did, but there doesn't seem to 
> be the case any more.  Just double checking, if id3lib is no longer required 
> I can get rid of the id3lib RPMs.
> 
> Zinf 2.2.4 RPMs for Red Hat 9 (including an updated libmusicbrainz) have 
> been uploaded.  The rio plugin rpm is experimental and untested.
--

-- 
Kristian G. Kvilekval
email:kris <at> cs.ucsb.edu office:(805)893-4276 http://www.cs.ucsb.edu/~kris

-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01
Permalink | Reply | 0 comments |

Gmane