Tanu Kaskinen | 22 Dec 11:55 2014
Picon

Patch review status wiki page updated

Patch review status updated:
http://www.freedesktop.org/wiki/Software/PulseAudio/PatchStatus/

Statistics:

* 2014-12-22
   * 23 patches are pending review.
   * The oldest pending patch is 155 days old.

* 2014-12-15
   * 21 patches are pending review.
   * The oldest pending patch is 148 days old.

* 2014-12-08
   * 22 patches are pending review.
   * The oldest pending patch is 141 days old.

* 2014-12-01
   * 24 patches are pending review.
   * The oldest pending patch is 134 days old.

* 2014-11-18
   * 71 patches are pending review.
   * The oldest pending patch is 427 days old.

* 2014-11-11
   * 72 patches are pending review.
   * The oldest pending patch is 420 days old.

* 2014-09-28
(Continue reading)

David Henningsson | 19 Dec 14:17 2014

[ANNOUNCE] PulseAudio 6.0 rc2 released!

If you're been naughty this year, your chance to make it up for 
Christmas is to dutily test PulseAudio RC2 and report bugs (or 
successes!) accordingly.

If you've been nice this year, better not ruin it all by skipping your 
testing of PulseAudio RC2!

And if you don't celebrate Christmas at all, you could just spend your 
time testing PulseAudio RC2 instead...

Anyhow, compared to RC1, we have these fixes/changes:
  * Build system fixes for Debian/FreeBSD and mingw32
  * Some translation updates
  * Fixed A2DP profile not restored correctly
  * Configure fixes for bluez 5 native headset backend
  * Noise in the beginning of a recording (with srbchannel) fixed
  * Fixed a few memory safety issues
  * Added warnings for two unstable modules (module-equalizer-sink and 
module-dbus-protocol)
  * Enabled autospawn even when systemd socket activation is built in 
(see below)

Notes:

  * Using the new systemd socket activation for PulseAudio will cause 
PulseAudio to not have any connection with D-Bus, breaking device 
reservation protocol, module-jackdbus-detect and module-dbus-protocol. 
Therefore, autospawn is now still enabled by default even if you build 
with systemd daemon headers. To enable systemd activation, an end user 
or packager would now have to do two steps:
(Continue reading)

David Henningsson | 19 Dec 10:24 2014

[PATCH] bluez5: Do not suspend on no -> unknown profile transitions

In case a transport is currently disconnected and transitions to
idle, that should not count as a "remote hang up" event.

Signed-off-by: David Henningsson <david.henningsson <at> canonical.com>
---

When used together with Tanu's module-card-restore patch, then the a2dp profile could
successfully be restored when PA starts up.

That said, I somewhat prefer my own version which never sets the profile to off. Just like
an available port does not cause the backend to switch away from it, (this logic is up to
module-switch-on-port-available), unavailable profiles should work the same way IMO.

 src/modules/bluetooth/module-bluez5-device.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/modules/bluetooth/module-bluez5-device.c b/src/modules/bluetooth/module-bluez5-device.c
index e6a8071..995e550 100644
--- a/src/modules/bluetooth/module-bluez5-device.c
+++ b/src/modules/bluetooth/module-bluez5-device.c
 <at>  <at>  -1968,11 +1968,13  <at>  <at>  static void handle_transport_state_change(struct userdata *u, struct pa_bluetoot
     bool release = false;
     pa_card_profile *cp;
     pa_device_port *port;
+    pa_available_t oldavail;

     pa_assert(u);
     pa_assert(t);
     pa_assert_se(cp = pa_hashmap_get(u->card->profiles, pa_bluetooth_profile_to_string(t->profile)));

(Continue reading)

Tanu Kaskinen | 16 Dec 12:14 2014
Picon

[PATCH] card-restore: Fix profile restoring with bluetooth

The bluetooth card is created when the first profile becomes
available, which means that the card may have profiles that are not
available when the card is initialized. If module-card-restore tries
to restore such profile, that will fail, and the card will be
initialized with the "off" profile active.

This patch modifies module-card-restore so that if follows the profile
availability status, and when the saved profile becomes available, it
is activated. Additionally, module-card-restore is modified so that it
doesn't even try to restore unavailable profiles, when the necessary
information is available. In practice there are two existing places
where the profile is restored, and only one of those contexts has the
necessary information available. Unfortunately, it's the more
important context (card creation) where the information is not
available. This means that module-card-restore will set the initial
profile of a new card even if the profile is unavailable, and this
will cause an ugly warning in the log, even though there's nothing
abnormal happening.

BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=87081
---
 src/modules/module-card-restore.c | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/src/modules/module-card-restore.c b/src/modules/module-card-restore.c
index 681acca..beb748e 100644
--- a/src/modules/module-card-restore.c
+++ b/src/modules/module-card-restore.c
 <at>  <at>  -66,6 +66,7  <at>  <at>  struct userdata {
     pa_hook_slot *card_put_hook_slot;
(Continue reading)

David Henningsson | 15 Dec 12:58 2014

[PATCH] WIP: Trying to allow being on unavailable profiles

We should not autoswitch to the off profile in case things go wrong.
In particular we should not switch to the off profile on startup
just because we haven't got the right callbacks from bluez yet,
because then the profile will always change from a2dp to off.

Signed-off-by: David Henningsson <david.henningsson <at> canonical.com>
---

This is an attempt to fix https://bugs.freedesktop.org/show_bug.cgi?id=87081
but it's probably wrong, because I had to disable what looks like some type of 
remote "hang up" feature. I don't know anything about this feature and could use
some help/feedback/review on how to re-enable it without it being triggered.

Anyhow, from a quick test, it seems to be working.

 src/modules/bluetooth/module-bluez5-device.c | 29 +++++++++++-----------------
 1 file changed, 11 insertions(+), 18 deletions(-)

diff --git a/src/modules/bluetooth/module-bluez5-device.c b/src/modules/bluetooth/module-bluez5-device.c
index e6a8071..a16f9ba 100644
--- a/src/modules/bluetooth/module-bluez5-device.c
+++ b/src/modules/bluetooth/module-bluez5-device.c
 <at>  <at>  -1857,7 +1857,7  <at>  <at>  static int set_profile_cb(pa_card *c, pa_card_profile *new_profile) {
         const pa_bluetooth_device *d = u->device;

         if (!d->transports[*p] || d->transports[*p]->state <=
PA_BLUETOOTH_TRANSPORT_STATE_DISCONNECTED) {
-            pa_log_warn("Refused to switch profile to %s: Not connected", new_profile->name);
+            pa_log_info("Refused to switch profile to %s: Not connected", new_profile->name);
             return -PA_ERR_IO;
(Continue reading)

Tanu Kaskinen | 15 Dec 11:05 2014
Picon

Patch review status wiki page updated

Patch review status updated:
http://www.freedesktop.org/wiki/Software/PulseAudio/PatchStatus/

Statistics:

* 2014-12-15
   * 21 patches are pending review.
   * The oldest pending patch is 148 days old.

* 2014-12-08
   * 22 patches are pending review.
   * The oldest pending patch is 141 days old.

* 2014-12-01
   * 24 patches are pending review.
   * The oldest pending patch is 134 days old.

* 2014-11-18
   * 71 patches are pending review.
   * The oldest pending patch is 427 days old.

* 2014-11-11
   * 72 patches are pending review.
   * The oldest pending patch is 420 days old.

* 2014-09-28
   * 148 patches are pending review.
   * The oldest pending patch is 386 days old.

* 2014-09-21
(Continue reading)

arun | 15 Dec 09:38 2014
Picon

[PATCH] build-sys: Add a configure flag for building only client libs

From: Arun Raghavan <git <at> arunraghavan.net>

https://bugs.freedesktop.org/show_bug.cgi?id=72173
---
 Makefile.am     | 11 +++++++++--
 configure.ac    | 17 +++++++++++++----
 man/Makefile.am |  2 +-
 src/Makefile.am | 25 +++++++++++++++++++++++++
 4 files changed, 48 insertions(+), 7 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index 665736d..470f127 100644
--- a/Makefile.am
+++ b/Makefile.am
 <at>  <at>  -39,7 +39,11  <at>  <at>  EXTRA_DIST = \
 	src/daemon/.gitignore \
 	src/pulse/.gitignore

-SUBDIRS = src doxygen man po
+SUBDIRS = src doxygen
+
+if !CLIENT_LIBS_ONLY
+SUBDIRS += man po
+endif

 MAINTAINERCLEANFILES =
 noinst_DATA =
 <at>  <at>  -62,6 +66,9  <at>  <at>  cmakedir = $(libdir)/cmake/PulseAudio
 cmake_DATA = PulseAudioConfig.cmake PulseAudioConfigVersion.cmake

(Continue reading)

Chris Mason | 11 Dec 19:58 2014

Trying HSP support in current git

Hi everyone,

I've compiled the current git sources to try out the new HSP supoprt.  
When I run pactl list, I get this:

Card #3
	Name: bluez_card.48_C1_AC_AD_38_DE
	Driver: module-bluez5-device.c
	Owner Module: 27
	Properties:
		device.description = "PLT M55"
		device.string = "48:C1:AC:AD:38:DE"
		device.api = "bluez"
		device.class = "sound"
		device.bus = "bluetooth"
		device.form_factor = "headset"
		bluez.path = "/org/bluez/hci0/dev_48_C1_AC_AD_38_DE"
		bluez.class = "0x240404"
		bluez.alias = "PLT_M55"
		device.icon_name = "audio-headset-bluetooth"
		device.intended_roles = "phone"
	Profiles:
		headset_head_unit: Headset Head Unit (HSP/HFP) (sinks: 1, sources: 1, 
priority: 20, available: no)
		a2dp_sink: High Fidelity Playback (A2DP Sink) (sinks: 1, sources: 0, 
priority: 10, available: yes)
		off: Off (sinks: 0, sources: 0, priority: 0, available: yes)
	Active Profile: a2dp_sink
	Ports:
		headset-output: Headset (priority: 0, latency offset: 0 usec, 
(Continue reading)

김정연 | 11 Dec 13:49 2014
Picon

Why tsched disabled when I use module-alsa-sink with 'mmap=0 tsched=1' parameters?

Dear developers,


I have question something about selecting logic between timer-based and IRQ scheduling.

When I tried to load 'module-alsa-sink' with 'mmap=0 tsched=1' parameters, tsched(timer-based scheduling) becomes disabled by below codes.

It seems tsched is allowed only mmap supported ALSA devices. Why tsched disabled while use non-mmap driven ALSA?

So, I found able to use tsched with 'mmap=0' option with below workaround code.

I think it seems possible to use 'mmap=0 tsched=1' together. There are any reasons for that?


==========

diff -uNr ./a/alsa-sink.c ./b/alsa-sink.c

--- ./a/alsa-sink.c     2014-12-11 21:41:13.680373375 +0900

+++ ./b/alsa-sink.c     2014-12-11 21:45:50.032371336 +0900

<at> <at> -2210,11 +2210,6 <at> <at>

         u->use_mmap = use_mmap = false;

     }


-    if (use_tsched && (!b || !d)) {

-        pa_log_info("Cannot enable timer-based scheduling, falling back to sound IRQ scheduling.");

-        u->use_tsched = use_tsched = false;

-    }

-

     if (u->use_mmap)

         pa_log_info("Successfully enabled mmap() mode.");


diff -uNr ./a/alsa-util.c ./b/alsa-util.c

--- ./a/alsa-util.c     2014-12-11 21:41:13.680373375 +0900

+++ ./b/alsa-util.c     2014-12-11 21:46:46.228370922 +0900

<at> <at> -240,9 +240,6 <at> <at>

         goto finish;

     }


-    if (!_use_mmap)

-        _use_tsched = false;

-

     if (!pa_alsa_pcm_is_hw(pcm_handle))

         _use_tsched = false;

==========


Thanks in advance,

KimJeongYeon

_______________________________________________
pulseaudio-discuss mailing list
pulseaudio-discuss <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
Ismo Puustinen | 10 Dec 14:38 2014
Picon

[PATCH] config: do not change digital controls from analog path config

When the default ALSA analog path configuration is loaded, it disables
digital IEC958 mixer controls. This should not be needed, since digital outputs
are handled from a different sink. Therefore remove the configuration that
touches the controls.
---
 src/modules/alsa/mixer/paths/analog-output.conf.common | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/modules/alsa/mixer/paths/analog-output.conf.common b/src/modules/alsa/mixer/paths/analog-output.conf.common
index 727b776..700bf28 100644
--- a/src/modules/alsa/mixer/paths/analog-output.conf.common
+++ b/src/modules/alsa/mixer/paths/analog-output.conf.common
 <at>  <at>  -152,12 +152,6  <at>  <at>  priority = 0
 name = output-bass-boost-off
 priority = 10

-[Element IEC958]
-switch = off
-
-[Element IEC958 Optical Raw]
-switch = off
-
 ;;; 'Analog Output'

 [Element Analog Output]
--

-- 
1.9.3

_______________________________________________
pulseaudio-discuss mailing list
pulseaudio-discuss <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
David Henningsson | 9 Dec 23:00 2014

[PATCH] memblock: Initialize mempool object to zero

This fixes a "use of uninitialised value" error in previous memblock commit.

Reported-by: Alexander Patrakov <patrakov <at> gmail.com>
Signed-off-by: David Henningsson <david.henningsson <at> canonical.com>
---
 src/pulsecore/memblock.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/pulsecore/memblock.c b/src/pulsecore/memblock.c
index eb85d1f..b781312 100644
--- a/src/pulsecore/memblock.c
+++ b/src/pulsecore/memblock.c
 <at>  <at>  -751,7 +751,7  <at>  <at>  pa_mempool* pa_mempool_new(bool shared, size_t size) {
     pa_mempool *p;
     char t1[PA_BYTES_SNPRINT_MAX], t2[PA_BYTES_SNPRINT_MAX];

-    p = pa_xnew(pa_mempool, 1);
+    p = pa_xnew0(pa_mempool, 1);

     p->block_size = PA_PAGE_ALIGN(PA_MEMPOOL_SLOT_SIZE);
     if (p->block_size < PA_PAGE_SIZE)
 <at>  <at>  -778,7 +778,6  <at>  <at>  pa_mempool* pa_mempool_new(bool shared, size_t size) {
                  pa_bytes_snprint(t2, sizeof(t2), (unsigned) (p->n_blocks * p->block_size)),
                  (unsigned long) pa_mempool_block_size_max(p));

-    memset(&p->stat, 0, sizeof(p->stat));
     pa_atomic_store(&p->n_init, 0);

     PA_LLIST_HEAD_INIT(pa_memimport, p->imports);
--

-- 
1.9.1

_______________________________________________
pulseaudio-discuss mailing list
pulseaudio-discuss <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

Gmane