Paqa_latency print typos & QA check
Alan Horstmann <gineera <at> aspect135.co.uk>
2013-05-29 17:02:33 GMT
Phil,
While reading output from paqa_latency I noticed the printouts say 'Output'
when reporting for input (there is also one rogue tab).
Also there seemed no reason not to enable the QA_ASSERT check of default high
latency to be greater than the low (now // out), except that it should allow
them to be equal. However, there may be a good reason!
The diff looks like this:-
--- ../svn-working-copy/qa/paqa_latency.c 2013-04-27 15:29:30.000000000 +0100
+++ qa/paqa_latency.c 2013-05-29 17:55:36.000000000 +0100
<at> <at> -255,7 +255,7 <at> <at>
{
numLoops = 1;
}
-
+
for( i=0; i<numLoops; i++ )
{
if( numLoops == 1 )
<at> <at> -361,15 +361,15 <at> <at>
printf(" Output defaultHighOutputLatency = %f seconds\n", pdi->defaultHighOutputLatency);
QA_ASSERT_TRUE( "defaultLowOutputLatency should be > 0", (pdi->defaultLowOutputLatency > 0.0) );
QA_ASSERT_TRUE( "defaultHighOutputLatency should be > 0", (pdi->defaultHighOutputLatency > 0.0) );
- //QA_ASSERT_TRUE( "defaultHighOutputLatency should be > Low", (pdi->defaultHighOutputLatency >
pdi->defaultLowOutputLatency) );
+ QA_ASSERT_TRUE( "defaultHighOutputLatency should be >= Low", (pdi->defaultHighOutputLatency >=
pdi->defaultLowOutputLatency) );
}
if( pdi->maxInputChannels > 0 )
{
- printf(" Input defaultLowOutputLatency = %f seconds\n", pdi->defaultLowInputLatency);
- printf(" Input defaultHighOutputLatency = %f seconds\n", pdi->defaultHighInputLatency);
- QA_ASSERT_TRUE( "defaultLowOutputLatency should be > 0", (pdi->defaultLowInputLatency > 0.0) );
- QA_ASSERT_TRUE( "defaultHighOutputLatency should be > 0", (pdi->defaultHighInputLatency > 0.0) );
- //QA_ASSERT_TRUE( "defaultHighOutputLatency should be > Low", (pdi->defaultHighInputLatency >
pdi->defaultLowInputLatency) );
+ printf(" Input defaultLowInputLatency = %f seconds\n", pdi->defaultLowInputLatency);
+ printf(" Input defaultHighInputLatency = %f seconds\n", pdi->defaultHighInputLatency);
+ QA_ASSERT_TRUE( "defaultLowInputLatency should be > 0", (pdi->defaultLowInputLatency > 0.0) );
+ QA_ASSERT_TRUE( "defaultHighInputLatency should be > 0", (pdi->defaultHighInputLatency > 0.0) );
+ QA_ASSERT_TRUE( "defaultHighInputLatency should be >= Low", (pdi->defaultHighInputLatency >=
pdi->defaultLowInputLatency) );
}
}
return 0;
I can commit this change if you wish?
Regards
Alan
_______________________________________________
Portaudio mailing list
Portaudio <at> music.columbia.edu
http://music.columbia.edu/mailman/listinfo/portaudio