Yair K. | 5 Apr 15:53 2009
Picon

[PATCH] FreeBSD: Add oss_userdev support, compile ossmixd. ossplay: Add float formats

Hi,

  The attached patches contain the following changes:
   1) FreeBSD: implement oss_get_uid and compile oss_userdev. Tested with 
udserver, and it seems to work.
   2) FreeBSD: compile ossmixd and libossmix. GNU ld requires removing 
the '-r' switch in srcconf.c otherwise the compile is broken on FreeBSD and 
Linux too.
   3) ossplay: Add float 32bit and 64bit format support.
   4) ossrecord: Be more careful when length may exceed maximum recordable 
file length in header, add note to man file (some formats only allocate 32 
bit in header to record file size and do not allow marking "unknown file 
size").
   4) ossplay: add some typedefs for integers with required bit lengths and 
use them where needed. The typedefs still assumes the same model like before, 
so no real change here.

Yours,
	Yair K.
Attachment (oss-freebsd-support-userdev.diff.gz): application/x-gzip, 1853 bytes
_______________________________________________
oss-devel mailing list
oss-devel <at> mailman.opensound.com
http://mailman.opensound.com/mailman/listinfo/oss-devel
Yair K. | 14 Apr 18:04 2009
Picon

[PATCH] Some very small patches to ossmix, hdaudio

Hi,
The attached patches:


1. Fix a bug with ossmix setting MIXT_SLIDER type.
2. Add a pci id to oss_hdaudio.
3. Condense lspci calls in soundon.


Yours,
Yair K.
Attachment (oss-hdaudio-add-id.diff.gz): application/x-gzip, 726 bytes
Attachment (oss-soundon.diff.gz): application/x-gzip, 349 bytes
Attachment (ossmix-small-fix.diff.gz): application/x-gzip, 766 bytes
_______________________________________________
oss-devel mailing list
oss-devel <at> mailman.opensound.com
http://mailman.opensound.com/mailman/listinfo/oss-devel
Hannu Savolainen | 15 Apr 07:49 2009

Re: [PATCH] Some very small patches to ossmix, hdaudio

Yair K. wrote:
> Hi,
> The attached patches:
>
>
> 1. Fix a bug with ossmix setting MIXT_SLIDER type.
> 2. Add a pci id to oss_hdaudio.
> 3. Condense lspci calls in soundon.
Ok. In the hg version now.

Best regards,

Hannu
Cristi Magherusan | 16 Apr 12:25 2009
Picon

Source repository suggestion, compile error with build 1052 due to -Werror

Hello,

I'm the gentoo ebuild maintainer, and I'm having some issues with the
fact that the old releases are moved to the attic directory when new
ones are released, and the ebuild fails to find them. Could you please
keep the sources in the same directory once they are published, so that
we won't have to change the old ebuilds when new versions appear?

And another issue is the usage of the -Werror CFLAG which makes
compilation fail with this message under Gentoo x86 with gcc 4.3.3:

cc -ffreestanding -c -O -fno-common -fno-stack-protector -Wall -Werror
-DOSS_LITTLE_ENDIAN  -I../../include -I../../kernel/framework/include
-I../../kernel/OS/Linux -I../../kernel/nonfree/include -I../..
-I/usr/src/uts/i686 osspartysh.c -o ./osspartysh.o
cc1: warnings being treated as errors
osspartysh.c: In function ‘pty_session’:
osspartysh.c:349: error: ignoring return value of ‘mkstemp’, declared
with attribute warn_unused_result
make[2]: *** [osspartysh.o] Error 1

This patch fixes the issue by using lower level file access functions
(write instead of fprintf):
http://hg.atheme.org/users/majeru/portage-overlay/raw-file/a8d1a5565974/media-sound/oss/files/oss-4.1.1052-Werror_fix.patch
_______________________________________________
oss-devel mailing list
oss-devel <at> mailman.opensound.com
http://mailman.opensound.com/mailman/listinfo/oss-devel
Hannu Savolainen | 16 Apr 17:30 2009

Re: Source repository suggestion, compile error with build 1052 due to -Werror

Cristi Magherusan wrote:
> Hello,
>
> I'm the gentoo ebuild maintainer, and I'm having some issues with the
> fact that the old releases are moved to the attic directory when new
> ones are released, and the ebuild fails to find them. Could you please
> keep the sources in the same directory once they are published, so that
> we won't have to change the old ebuilds when new versions appear?
>
>   
Ok. Should I move the older packages back to the original directory?
> And another issue is the usage of the -Werror CFLAG which makes
> compilation fail with this message under Gentoo x86 with gcc 4.3.3:
>
> cc -ffreestanding -c -O -fno-common -fno-stack-protector -Wall -Werror
> -DOSS_LITTLE_ENDIAN  -I../../include -I../../kernel/framework/include
> -I../../kernel/OS/Linux -I../../kernel/nonfree/include -I../..
> -I/usr/src/uts/i686 osspartysh.c -o ./osspartysh.o
> cc1: warnings being treated as errors
> osspartysh.c: In function ‘pty_session’:
> osspartysh.c:349: error: ignoring return value of ‘mkstemp’, declared
> with attribute warn_unused_result
> make[2]: *** [osspartysh.o] Error 1
>
> This patch fixes the issue by using lower level file access functions
> (write instead of fprintf):
> http://hg.atheme.org/users/majeru/portage-overlay/raw-file/a8d1a5565974/media-sound/oss/files/oss-4.1.1052-Werror_fix.patch
>   
I will do this fix to b1053.

Best regards,

Hannu
_______________________________________________
oss-devel mailing list
oss-devel <at> mailman.opensound.com
http://mailman.opensound.com/mailman/listinfo/oss-devel
Cristi Magherusan | 16 Apr 20:54 2009
Picon

Re: Source repository suggestion, compile error with build 1052 due to -Werror

On Thu, 2009-04-16 at 18:30 +0300, Hannu Savolainen wrote:
> Cristi Magherusan wrote:
> > Hello,
> >
> > I'm the gentoo ebuild maintainer, and I'm having some issues with the
> > fact that the old releases are moved to the attic directory when new
> > ones are released, and the ebuild fails to find them. Could you please
> > keep the sources in the same directory once they are published, so that
> > we won't have to change the old ebuilds when new versions appear?
> >
> >   
> Ok. Should I move the older packages back to the original directory?
You may do as you wish, now I'm in sync with the current ones (4.0.1016
and 4.1.1052) but i'd like it to be this way from now on.

> I will do this fix to b1053.
Thanks!
Cristi
Will Keaney | 25 Apr 16:46 2009
Picon

[PATCH] Use dev_name() instead of bus_id

OSS modules won't build against kernel 2.6.30 right now.  This patch
addresses that by changing from the apparently deprecated dev.bus_id to
dev_name(), and was created using a fresh checkout from the mercurial,
last changeset 735:b75dd483cb27.

Will Keaney
uberpinguin
diff -r b75dd483cb27 setup/Linux/oss/build/osscore.c
--- a/setup/Linux/oss/build/osscore.c	Tue Apr 21 23:54:05 2009 +0300
+++ b/setup/Linux/oss/build/osscore.c	Sat Apr 25 10:46:31 2009 -0400
 <at>  <at>  -1618,7 +1618,7  <at>  <at> 
 char *
 oss_pci_read_devpath (dev_info_t * dip)
 {
-  return dip->pcidev->dev.bus_id;
+  return dev_name(dip->pcidev);
 }

 int
_______________________________________________
oss-devel mailing list
oss-devel <at> mailman.opensound.com
http://mailman.opensound.com/mailman/listinfo/oss-devel
Yair K. | 25 Apr 17:26 2009
Picon

Re: [PATCH] Use dev_name() instead of bus_id

On Saturday, 25 April 2009 17:46:55 Will Keaney wrote:
> OSS modules won't build against kernel 2.6.30 right now. This patch
> addresses that by changing from the apparently deprecated dev.bus_id to
> dev_name(), and was created using a fresh checkout from the mercurial,
> last changeset 735:b75dd483cb27.
>
> Will Keaney
> uberpinguin


Wouldn't this patch need some check again LINUX_VERSION_CODE, so that OSS will compile against earlier Linux versions? Per lxr.linux.no early 2.6.x didn't have this function.


Yours,
Yair K.


diff -r 9cad50985f54 setup/Linux/oss/build/osscore.c
--- a/setup/Linux/oss/build/osscore.c Wed Apr 15 08:49:00 2009 +0300
+++ b/setup/Linux/oss/build/osscore.c Sat Apr 25 18:23:55 2009 +0300
char *
oss_pci_read_devpath (dev_info_t * dip)
{
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,30)
+ return dev_name(dip->pcidev);
+#else
return dip->pcidev->dev.bus_id;
+#endif
}

int


_______________________________________________
oss-devel mailing list
oss-devel <at> mailman.opensound.com
http://mailman.opensound.com/mailman/listinfo/oss-devel
Will Keaney | 25 Apr 19:00 2009
Picon

Re: [PATCH] Use dev_name() instead of bus_id

Yair K. wrote:
> On Saturday, 25 April 2009 17:46:55 Will Keaney wrote:
> > OSS modules won't build against kernel 2.6.30 right now. This patch
> > addresses that by changing from the apparently deprecated dev.bus_id to
> > dev_name(), and was created using a fresh checkout from the mercurial,
> > last changeset 735:b75dd483cb27.
> >
> > Will Keaney
> > uberpinguin
>
>
> Wouldn't this patch need some check again LINUX_VERSION_CODE, so that
> OSS will compile against earlier Linux versions? Per lxr.linux.no
> early 2.6.x didn't have this function.
>
>
> Yours,
> Yair K.
>
>
> diff -r 9cad50985f54 setup/Linux/oss/build/osscore.c
> --- a/setup/Linux/oss/build/osscore.c Wed Apr 15 08:49:00 2009 +0300
> +++ b/setup/Linux/oss/build/osscore.c Sat Apr 25 18:23:55 2009 +0300
> char *
> oss_pci_read_devpath (dev_info_t * dip)
> {
> +#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,30)
> + return dev_name(dip->pcidev);
> +#else
> return dip->pcidev->dev.bus_id;
> +#endif
> }
>
> int
>
Ah, you're right.  I hadn't thought of that.  Once I've figured out how
to implement it, I'll submit a revised patch.

Will

_______________________________________________
oss-devel mailing list
oss-devel <at> mailman.opensound.com
http://mailman.opensound.com/mailman/listinfo/oss-devel
Yair K. | 25 Apr 19:07 2009
Picon

Re: [PATCH] Use dev_name() instead of bus_id

On Saturday, 25 בApril 2009 20:00:51 Will Keaney wrote:
> Yair K. wrote:
> > On Saturday, 25 April 2009 17:46:55 Will Keaney wrote:
> > > OSS modules won't build against kernel 2.6.30 right now. This patch
> > > addresses that by changing from the apparently deprecated dev.bus_id to
> > > dev_name(), and was created using a fresh checkout from the mercurial,
> > > last changeset 735:b75dd483cb27.
> > >
> > > Will Keaney
> > > uberpinguin
> >
> > Wouldn't this patch need some check again LINUX_VERSION_CODE, so that
> > OSS will compile against earlier Linux versions? Per lxr.linux.no
> > early 2.6.x didn't have this function.
> >
> >
> > Yours,
> > Yair K.
> >
> >
> > diff -r 9cad50985f54 setup/Linux/oss/build/osscore.c
> > --- a/setup/Linux/oss/build/osscore.c Wed Apr 15 08:49:00 2009 +0300
> > +++ b/setup/Linux/oss/build/osscore.c Sat Apr 25 18:23:55 2009 +0300
> > char *
> > oss_pci_read_devpath (dev_info_t * dip)
> > {
> > +#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,30)
> > + return dev_name(dip->pcidev);
> > +#else
> > return dip->pcidev->dev.bus_id;
> > +#endif
> > }
> >
> > int
>
> Ah, you're right. I hadn't thought of that. Once I've figured out how
> to implement it, I'll submit a revised patch.
>
> Will


I included a revised version. I should have asked whether it worked for you.


Yours,
Yair K.
_______________________________________________
oss-devel mailing list
oss-devel <at> mailman.opensound.com
http://mailman.opensound.com/mailman/listinfo/oss-devel

Gmane