root | 1 Feb 01:35 2010

[mb-commits] r12657 - search_server/trunk/index/src/test/java/org/musicbrainz/search/index

Author: murdos
Date: 2010-02-01 00:35:16 +0000 (Mon, 01 Feb 2010)
New Revision: 12657

Modified:
   search_server/trunk/index/src/test/java/org/musicbrainz/search/index/AbstractIndexTest.java
   search_server/trunk/index/src/test/java/org/musicbrainz/search/index/RecordingIndexTest.java
   search_server/trunk/index/src/test/java/org/musicbrainz/search/index/ReleaseGroupIndexTest.java
   search_server/trunk/index/src/test/java/org/musicbrainz/search/index/ReleaseIndexTest.java
   search_server/trunk/index/src/test/java/org/musicbrainz/search/index/WorkIndexTest.java
Log:
Updated unit tests after http://codereview.musicbrainz.org/r/448/ (addition of artist_credit.name).
Indexing code not yet updated.

Modified: search_server/trunk/index/src/test/java/org/musicbrainz/search/index/AbstractIndexTest.java
===================================================================
---
search_server/trunk/index/src/test/java/org/musicbrainz/search/index/AbstractIndexTest.java	2010-01-31
23:59:57 UTC (rev 12656)
+++
search_server/trunk/index/src/test/java/org/musicbrainz/search/index/AbstractIndexTest.java	2010-02-01
00:35:16 UTC (rev 12657)
 <at>  <at>  -171,6 +171,7  <at>  <at> 

         stmt.addBatch("CREATE TABLE artist_credit (" +
                 "  id serial NOT NULL," +
+                "  name integer NOT NULL," +
                 "  artistcount integer NOT NULL," +
                 "  refcount integer DEFAULT 0" +
                 ")");
(Continue reading)

root | 1 Feb 21:43 2010

[mb-commits] r12658 - in mb_server/trunk: . admin admin/apache lib po root/static/wikidocs

Author: warp
Date: 2010-02-01 20:43:40 +0000 (Mon, 01 Feb 2010)
New Revision: 12658

Added:
   mb_server/trunk/.gitignore
   mb_server/trunk/admin/.gitignore
   mb_server/trunk/admin/apache/.gitignore
   mb_server/trunk/lib/.gitignore
   mb_server/trunk/po/.gitignore
   mb_server/trunk/root/static/wikidocs/.gitignore
Log:
git svn create-ignore
root | 1 Feb 21:43 2010

[mb-commits] r12659 - in mb_server/trunk: lib/MusicBrainz/Server/Data t

Author: warp
Date: 2010-02-01 20:43:53 +0000 (Mon, 01 Feb 2010)
New Revision: 12659

Modified:
   mb_server/trunk/lib/MusicBrainz/Server/Data/Collection.pm
   mb_server/trunk/t/data_collection.t
Log:
See review 515

Modified: mb_server/trunk/lib/MusicBrainz/Server/Data/Collection.pm
===================================================================
--- mb_server/trunk/lib/MusicBrainz/Server/Data/Collection.pm	2010-02-01 20:43:40 UTC (rev 12658)
+++ mb_server/trunk/lib/MusicBrainz/Server/Data/Collection.pm	2010-02-01 20:43:53 UTC (rev 12659)
 <at>  <at>  -33,8 +33,13  <at>  <at> 

     my $sql = Sql->new($self->c->dbh);
     $sql->auto_commit;
+
+    my $rows = $sql->select ("SELECT * FROM editor_collection_release 
+       WHERE collection=? AND release=?", $collection_id, $release_id);
+    $sql->finish;
+
     $sql->do("INSERT INTO editor_collection_release (collection, release)
-              VALUES (?, ?)", $collection_id, $release_id);
+              VALUES (?, ?)", $collection_id, $release_id) unless $rows;
 }

 sub remove_release_from_collection

(Continue reading)

root | 2 Feb 20:12 2010

[mb-commits] r12660 - in mb_server/trunk: lib/MusicBrainz/Server/Controller/User lib/MusicBrainz/Server/Data root/user root/user/profile t t/sql

Author: warp
Date: 2010-02-02 19:12:14 +0000 (Tue, 02 Feb 2010)
New Revision: 12660

Added:
   mb_server/trunk/lib/MusicBrainz/Server/Controller/User/Subscribers.pm
   mb_server/trunk/root/user/subscribers.tt
Modified:
   mb_server/trunk/lib/MusicBrainz/Server/Data/Editor.pm
   mb_server/trunk/root/user/profile/layout.tt
   mb_server/trunk/t/data_editor.t
   mb_server/trunk/t/sql/editor.sql
Log:
See review 517

Modified: mb_server/trunk/lib/MusicBrainz/Server/Data/Editor.pm
===================================================================
--- mb_server/trunk/lib/MusicBrainz/Server/Data/Editor.pm	2010-02-01 20:43:53 UTC (rev 12659)
+++ mb_server/trunk/lib/MusicBrainz/Server/Data/Editor.pm	2010-02-02 19:12:14 UTC (rev 12660)
 <at>  <at>  -83,6 +83,20  <at>  <at> 
         $query, $editor_id, $offset || 0);
 }

+sub find_subscribers
+{
+    my ($self, $editor_id, $limit, $offset) =  <at> _;
+    my $query = "SELECT " . $self->_columns . "
+                 FROM " . $self->_table . "
+                    JOIN editor_subscribe_editor s ON editor.id = s.editor
+                 WHERE s.subscribededitor = ?
(Continue reading)

root | 2 Feb 20:13 2010

[mb-commits] r12661 - mb_server/trunk/lib/MusicBrainz/Server/Plugin

Author: warp
Date: 2010-02-02 19:13:19 +0000 (Tue, 02 Feb 2010)
New Revision: 12661

Modified:
   mb_server/trunk/lib/MusicBrainz/Server/Plugin/FormRenderer.pm
Log:
See review 518

Modified: mb_server/trunk/lib/MusicBrainz/Server/Plugin/FormRenderer.pm
===================================================================
--- mb_server/trunk/lib/MusicBrainz/Server/Plugin/FormRenderer.pm	2010-02-02 19:12:14 UTC (rev 12660)
+++ mb_server/trunk/lib/MusicBrainz/Server/Plugin/FormRenderer.pm	2010-02-02 19:13:19 UTC (rev 12661)
 <at>  <at>  -108,7 +108,7  <at>  <at> 
     {
         return $self->h->label({
             id => 'label-' . $field->id,
-            for => $field->id,
+            for => 'id-' . $field->id,
             class => $class || undef
             %$attrs
         }, $label);
 <at>  <at>  -202,3 +202,23  <at>  <at> 
 }

 1;
+
+=head1 COPYRIGHT
+
+Copyright (C) 2009-2010  MetaBrainz Foundation
(Continue reading)

root | 3 Feb 13:36 2010

[mb-commits] r12662 - mb_server/trunk/lib/MusicBrainz/Server/Controller

Author: acid2
Date: 2010-02-03 12:36:08 +0000 (Wed, 03 Feb 2010)
New Revision: 12662

Modified:
   mb_server/trunk/lib/MusicBrainz/Server/Controller/Search.pm
Log:
Import type_to_model in Controller::Search

If a search returned only one result, the controller would fail
to redirect to it, and instead thrown an exception

Modified: mb_server/trunk/lib/MusicBrainz/Server/Controller/Search.pm
===================================================================
--- mb_server/trunk/lib/MusicBrainz/Server/Controller/Search.pm	2010-02-02 19:13:19 UTC (rev 12661)
+++ mb_server/trunk/lib/MusicBrainz/Server/Controller/Search.pm	2010-02-03 12:36:08 UTC (rev 12662)
 <at>  <at>  -6,7 +6,7  <at>  <at> 
 use base 'MusicBrainz::Server::Controller';

 use LWP::UserAgent;
-use MusicBrainz::Server::Data::Utils qw( model_to_type );
+use MusicBrainz::Server::Data::Utils qw( model_to_type type_to_model );
 use MusicBrainz::Server::Form::Search::Query;
 use MusicBrainz::Server::Form::Search::Search;
root | 3 Feb 13:50 2010

[mb-commits] r12663 - in mb_server/trunk: lib/MusicBrainz/Server/Edit/Artist t/actions/artist

Author: acid2
Date: 2010-02-03 12:50:31 +0000 (Wed, 03 Feb 2010)
New Revision: 12663

Modified:
   mb_server/trunk/lib/MusicBrainz/Server/Edit/Artist/Create.pm
   mb_server/trunk/t/actions/artist/artist-edit-create.t
Log:
Allow creating artists with only the minimal amount of fields

Modified: mb_server/trunk/lib/MusicBrainz/Server/Edit/Artist/Create.pm
===================================================================
--- mb_server/trunk/lib/MusicBrainz/Server/Edit/Artist/Create.pm	2010-02-03 12:36:08 UTC (rev 12662)
+++ mb_server/trunk/lib/MusicBrainz/Server/Edit/Artist/Create.pm	2010-02-03 12:50:31 UTC (rev 12663)
 <at>  <at>  -44,12 +44,12  <at>  <at> 
         name       => Str,
         gid        => Optional[Str],
         sort_name  => Optional[Str],
-        type_id    => Optional[Int],
-        gender_id  => Optional[Int],
-        country_id => Optional[Int],
-        comment    => Optional[Str],
-        begin_date => Optional[PartialDateHash],
-        end_date   => Optional[PartialDateHash],
+        type_id    => Nullable[Int],
+        gender_id  => Nullable[Int],
+        country_id => Nullable[Int],
+        comment    => Nullable[Str],
+        begin_date => Nullable[PartialDateHash],
+        end_date   => Nullable[PartialDateHash],
(Continue reading)

root | 3 Feb 16:33 2010

[mb-commits] r12664 - in mb_server/trunk: lib/MusicBrainz/Server/Edit/Artist root/edit/details

Author: warp
Date: 2010-02-03 15:33:05 +0000 (Wed, 03 Feb 2010)
New Revision: 12664

Added:
   mb_server/trunk/root/edit/details/remove_artist.tt
Modified:
   mb_server/trunk/lib/MusicBrainz/Server/Edit/Artist/Delete.pm
Log:
MBS-350, review 523, view delete artist edit type

Modified: mb_server/trunk/lib/MusicBrainz/Server/Edit/Artist/Delete.pm
===================================================================
--- mb_server/trunk/lib/MusicBrainz/Server/Edit/Artist/Delete.pm	2010-02-03 12:50:31 UTC (rev 12663)
+++ mb_server/trunk/lib/MusicBrainz/Server/Edit/Artist/Delete.pm	2010-02-03 15:33:05 UTC (rev 12664)
 <at>  <at>  -6,7 +6,7  <at>  <at> 
 extends 'MusicBrainz::Server::Edit::Generic::Delete';

 sub edit_type { $EDIT_ARTIST_DELETE }
-sub edit_name { "Delete artist" }
+sub edit_name { "Remove artist" }
 sub _delete_model { 'Artist' }
root | 3 Feb 16:34 2010

[mb-commits] r12665 - in mb_server/trunk/root: . components label release release_group search static/styles

Author: warp
Date: 2010-02-03 15:34:19 +0000 (Wed, 03 Feb 2010)
New Revision: 12665

Removed:
   mb_server/trunk/root/components/tagger.tt
Modified:
   mb_server/trunk/root/components/common-macros.tt
   mb_server/trunk/root/label/index.tt
   mb_server/trunk/root/layout.tt
   mb_server/trunk/root/release/header.tt
   mb_server/trunk/root/release_group/releases-list.tt
   mb_server/trunk/root/search/results-release.tt
   mb_server/trunk/root/static/styles/layout.css
Log:
MBS-202, review 519, implement green tagger icons

Modified: mb_server/trunk/root/components/common-macros.tt
===================================================================
--- mb_server/trunk/root/components/common-macros.tt	2010-02-03 15:33:05 UTC (rev 12664)
+++ mb_server/trunk/root/components/common-macros.tt	2010-02-03 15:34:19 UTC (rev 12665)
 <at>  <at>  -241,6 +241,15  <at>  <at> 
     });
 END -%]

+[%- MACRO tagger_icon(release) BLOCK -%]
+    [% USE date %]
+    <a href="http://127.0.0.1:[% c.session.tport %]/openalbum?id=[% release.gid %]&t=[% date.now %]"
+        target="tagger-iframe" class="tagger-icon" title="[% l('Open in tagger') %]">
+        <img src="[% c.uri_for('/static/images/mblookup-tagger.png') %]" alt="[% l('Tagger') %]" />
(Continue reading)

root | 4 Feb 20:01 2010

[mb-commits] r12666 - mmd-schema/trunk/schema

Author: robert
Date: 2010-02-04 19:01:55 +0000 (Thu, 04 Feb 2010)
New Revision: 12666

Modified:
   mmd-schema/trunk/schema/musicbrainz_mmd-2.0.rng
Log:
Latest changes to allow the web service documents to parse. Fixed up ISRC, PUID and disc elements
and a few other minor changes.

Modified: mmd-schema/trunk/schema/musicbrainz_mmd-2.0.rng
===================================================================
--- mmd-schema/trunk/schema/musicbrainz_mmd-2.0.rng	2010-02-03 15:34:19 UTC (rev 12665)
+++ mmd-schema/trunk/schema/musicbrainz_mmd-2.0.rng	2010-02-04 19:01:55 UTC (rev 12666)
 <at>  <at>  -63,6 +63,12  <at>  <at> 
             <optional>
                 <ref name="def_work-element"/>
             </optional>
+            <optional>
+                <ref name="def_puid-element"/>
+            </optional>
+            <optional>
+                <ref name="def_disc-element"/>
+            </optional>

             <optional>
                 <ref name="def_artist-list"/>
 <at>  <at>  -83,6 +89,9  <at>  <at> 
                 <ref name="def_work-list"/>
             </optional>
(Continue reading)


Gmane