root | 2 Jan 2010 13:46
Favicon

[mb-commits] r12408 - in mb_server/trunk: lib/MusicBrainz/Server/Controller lib/MusicBrainz/Server/Edit/Track lib/MusicBrainz/Server/Form root/edit/details t/actions/release_editor

Author: acid2
Date: 2010-01-02 12:46:09 +0000 (Sat, 02 Jan 2010)
New Revision: 12408

Modified:
   mb_server/trunk/lib/MusicBrainz/Server/Controller/Release.pm
   mb_server/trunk/lib/MusicBrainz/Server/Edit/Track/Edit.pm
   mb_server/trunk/lib/MusicBrainz/Server/Form/Release.pm
   mb_server/trunk/root/edit/details/edit_track.tt
   mb_server/trunk/t/actions/release_editor/edit-track.t
Log:
Allow setting release editor track times. Fixes MBS-20

Modified: mb_server/trunk/lib/MusicBrainz/Server/Controller/Release.pm
===================================================================
--- mb_server/trunk/lib/MusicBrainz/Server/Controller/Release.pm	2009-12-30 14:58:38 UTC (rev 12407)
+++ mb_server/trunk/lib/MusicBrainz/Server/Controller/Release.pm	2010-01-02 12:46:09 UTC (rev 12408)
 <at>  <at>  -339,7 +339,7  <at>  <at> 
                     else {
                         # Editing an existing track
                         $self->_create_edit($c, $EDIT_TRACK_EDIT,
-                            $track_field => [qw( position name artist_credit )],
+                            $track_field => [qw( position name artist_credit length )],
                             track => $track,
                         );
                     }

Modified: mb_server/trunk/lib/MusicBrainz/Server/Edit/Track/Edit.pm
===================================================================
--- mb_server/trunk/lib/MusicBrainz/Server/Edit/Track/Edit.pm	2009-12-30 14:58:38 UTC (rev 12407)
(Continue reading)

root | 2 Jan 2010 16:29
Favicon

[mb-commits] r12409 - in mb_server/trunk: po root/main

Author: acid2
Date: 2010-01-02 15:29:19 +0000 (Sat, 02 Jan 2010)
New Revision: 12409

Modified:
   mb_server/trunk/po/ar.po
   mb_server/trunk/po/mb_server.pot
   mb_server/trunk/po/nl.po
   mb_server/trunk/po/ru.po
   mb_server/trunk/root/main/index.tt
Log:
Apply a bugfix patch from Nikolai to fix some I18N issue

Modified: mb_server/trunk/po/ar.po
===================================================================
--- mb_server/trunk/po/ar.po	2010-01-02 12:46:09 UTC (rev 12408)
+++ mb_server/trunk/po/ar.po	2010-01-02 15:29:19 UTC (rev 12409)
 <at>  <at>  -7,7 +7,7  <at>  <at> 
 msgstr ""
 "Project-Id-Version: mbserver\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2009-10-27 20:47+0100\n"
+"POT-Creation-Date: 2009-12-30 17:59+0100\n"
 "PO-Revision-Date: 2009-03-27 12:21+0000\n"
 "Last-Translator: MaXeR <Unknown>\n"
 "Language-Team: Arabic <ar <at> li.org>\n"
 <at>  <at>  -19,7 +19,7  <at>  <at> 
 "X-Launchpad-Export-Date: 2009-04-03 21:48+0000\n"
 "X-Generator: Launchpad (build Unknown)\n"
 
(Continue reading)

root | 2 Jan 2010 17:18
Favicon

[mb-commits] r12410 - mb_server/trunk/po

Author: acid2
Date: 2010-01-02 16:18:44 +0000 (Sat, 02 Jan 2010)
New Revision: 12410

Added:
   mb_server/trunk/po/de.po
   mb_server/trunk/po/fr.po
   mb_server/trunk/po/pl.po
   mb_server/trunk/po/ro.po
   mb_server/trunk/po/tr.po
   mb_server/trunk/po/zh_TW.po
Modified:
   mb_server/trunk/po/ar.po
   mb_server/trunk/po/mb_server.pot
   mb_server/trunk/po/nl.po
   mb_server/trunk/po/ru.po
Log:
More I18N stuff from Nikolai

Modified: mb_server/trunk/po/ar.po
===================================================================
--- mb_server/trunk/po/ar.po	2010-01-02 15:29:19 UTC (rev 12409)
+++ mb_server/trunk/po/ar.po	2010-01-02 16:18:44 UTC (rev 12410)
 <at>  <at>  -7,16 +7,16  <at>  <at> 
 msgstr ""
 "Project-Id-Version: mbserver\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2009-12-30 17:59+0100\n"
-"PO-Revision-Date: 2009-03-27 12:21+0000\n"
-"Last-Translator: MaXeR <Unknown>\n"
(Continue reading)

root | 2 Jan 2010 17:51
Favicon

[mb-commits] r12411 - mb_server/trunk/po

Author: warp
Date: 2010-01-02 16:51:05 +0000 (Sat, 02 Jan 2010)
New Revision: 12411

Modified:
   mb_server/trunk/po/
Log:
ignore generated files.

Property changes on: mb_server/trunk/po
___________________________________________________________________
Added: svn:ignore
   + *.mo
root | 4 Jan 2010 17:01
Favicon

[mb-commits] r12412 - search_server/branches/ngs/index/src/main/java/org/musicbrainz/search/index

Author: ijabz
Date: 2010-01-04 16:01:28 +0000 (Mon, 04 Jan 2010)
New Revision: 12412

Modified:
   search_server/branches/ngs/index/src/main/java/org/musicbrainz/search/index/IndexBuilder.java
Log:
Problems building recording index because sometimes query analyser EXPLAIN is deciding to run this query
SELECT re.id as recordingId,re.gid as trackid,re.length as duration,tn.name as trackname 
                FROM recording re 
                INNER JOIN track_name tn 
                ON re.name=tn.id 
                WHERE re.id BETWEEN ? AND ?")

by performing a full table scan on track_name rather than an index scan using track_name_pkey, this is
invariably performs much worse.

Cant see why it is doing this because the tables have been vacuumed and the explain correctly works out its
going to take a long time , so why does it continue to do it ? From
http://www.revsys.com/writings/postgresql-performance.html it appears increasing
shared_buffers and effective_cahe_size might cause it to work correctly, but with my tests it didnt.

Setting 
SET enable_seqscan = off
on the connection makes query analyzer favour using indexes where they exist, reducing query time

Also increased default cluster size, 50,000 range gave best results on my labtop.

Modified: search_server/branches/ngs/index/src/main/java/org/musicbrainz/search/index/IndexBuilder.java
===================================================================
(Continue reading)

root | 4 Jan 2010 17:02
Favicon

[mb-commits] r12413 - search_server/branches/ngs/index/src/main/java/org/musicbrainz/search/index

Author: ijabz
Date: 2010-01-04 16:02:20 +0000 (Mon, 04 Jan 2010)
New Revision: 12413

Modified:
   search_server/branches/ngs/index/src/main/java/org/musicbrainz/search/index/RecordingIndex.java
Log:
Release Group Typpe is mandatory

Modified: search_server/branches/ngs/index/src/main/java/org/musicbrainz/search/index/RecordingIndex.java
===================================================================
---
search_server/branches/ngs/index/src/main/java/org/musicbrainz/search/index/RecordingIndex.java	2010-01-04
16:01:28 UTC (rev 12412)
+++
search_server/branches/ngs/index/src/main/java/org/musicbrainz/search/index/RecordingIndex.java	2010-01-04
16:02:20 UTC (rev 12413)
 <at>  <at>  -104,7 +104,7  <at>  <at> 
                 "ON m.release=r.id " +
                 "INNER JOIN release_group rg " +
                 "ON rg.id = r.release_group " +
-                "LEFT JOIN release_group_type rgt " +    //according to ruaok is mandatory
+                "INNER JOIN release_group_type rgt " +    
                 "ON rg.type = rgt.id " +
                 "INNER JOIN release_name rn " +
                 "ON r.name=rn.id " +
root | 4 Jan 2010 18:58
Favicon

[mb-commits] r12414 - in mb_server/trunk: lib/MusicBrainz/Server/Controller root/artist root/label root/recording root/release_group root/work

Author: warp
Date: 2010-01-04 17:58:25 +0000 (Mon, 04 Jan 2010)
New Revision: 12414

Modified:
   mb_server/trunk/lib/MusicBrainz/Server/Controller/EditListingRole.pm
   mb_server/trunk/root/artist/layout.tt
   mb_server/trunk/root/label/layout.tt
   mb_server/trunk/root/recording/layout.tt
   mb_server/trunk/root/release_group/layout.tt
   mb_server/trunk/root/work/layout.tt
Log:
fixing MBS-14, see review 491.

Modified: mb_server/trunk/lib/MusicBrainz/Server/Controller/EditListingRole.pm
===================================================================
--- mb_server/trunk/lib/MusicBrainz/Server/Controller/EditListingRole.pm	2010-01-04 16:02:20
UTC (rev 12413)
+++ mb_server/trunk/lib/MusicBrainz/Server/Controller/EditListingRole.pm	2010-01-04 17:58:25
UTC (rev 12414)
 <at>  <at>  -5,7 +5,7  <at>  <at> 

 requires '_load_paged';

-sub edits : Chained('load') PathPart
+sub edits : Chained('load') PathPart RequireAuth
 {
     my ($self, $c) =  <at> _;

Modified: mb_server/trunk/root/artist/layout.tt
(Continue reading)

root | 4 Jan 2010 21:40
Favicon

[mb-commits] r12415 - search_server/branches/ngs/index/src/test/java/org/musicbrainz/search/index

Author: ijabz
Date: 2010-01-04 20:40:49 +0000 (Mon, 04 Jan 2010)
New Revision: 12415

Modified:
   search_server/branches/ngs/index/src/test/java/org/musicbrainz/search/index/RecordingIndexTest.java
Log:
Removed Release Group Type Test

Modified: search_server/branches/ngs/index/src/test/java/org/musicbrainz/search/index/RecordingIndexTest.java
===================================================================
---
search_server/branches/ngs/index/src/test/java/org/musicbrainz/search/index/RecordingIndexTest.java	2010-01-04
17:58:25 UTC (rev 12414)
+++
search_server/branches/ngs/index/src/test/java/org/musicbrainz/search/index/RecordingIndexTest.java	2010-01-04
20:40:49 UTC (rev 12415)
 <at>  <at>  -233,28 +233,8  <at>  <at> 
         ir.close();
     }

-    /**
-     * Basic test of all fields
-     *
-     *  <at> throws Exception
-     */
-    public void testNoReleaseType() throws Exception {
+    

-        addTrackTwo();
(Continue reading)

root | 4 Jan 2010 21:40
Favicon

[mb-commits] r12416 - in mb_server/branches/RELEASE_20090524-BRANCH/htdocs: . comp/layout

Author: robert
Date: 2010-01-04 20:40:51 +0000 (Mon, 04 Jan 2010)
New Revision: 12416

Modified:
   mb_server/branches/RELEASE_20090524-BRANCH/htdocs/comp/layout/topmenu
   mb_server/branches/RELEASE_20090524-BRANCH/htdocs/index.html
Log:
Checking in review 493 for navap. See http://codereview.musicbrainz.org/r/493

Modified: mb_server/branches/RELEASE_20090524-BRANCH/htdocs/comp/layout/topmenu
===================================================================
--- mb_server/branches/RELEASE_20090524-BRANCH/htdocs/comp/layout/topmenu	2010-01-04
20:40:49 UTC (rev 12415)
+++ mb_server/branches/RELEASE_20090524-BRANCH/htdocs/comp/layout/topmenu	2010-01-04
20:40:51 UTC (rev 12416)
 <at>  <at>  -76,11 +76,11  <at>  <at> 
 			[
 				{ url => "/doc/CD_Lookup_Tool" },
 			],
-			{ name => "Picard Tagger",			url => "/doc/Picard_Tagger" },
+			{ name => "MusicBrainz Picard",			url => "/doc/MusicBrainz_Picard" },
 				{ url => "/doc/Picard_Download" },
 				{ url => "/doc/Picard_Tutorial" },
 				{ url => "/doc/Picard_QuickStart" },
-			{ name => "Magic Tagger",			url => "/doc/Magic_Tagger" },
+			{ name => "Magic MP3 Tagger",			url => "/doc/Magic_MP3_Tagger" },
 			{ name => "Jaikoz Tag Editor",			url => "/doc/Jaikoz_MP3_Tag_Editor" },
 			{ name => "libmusicbrainz",	url => "/doc/libmusicbrainz" },
 			[
(Continue reading)

root | 4 Jan 2010 22:30
Favicon

[mb-commits] r12417 - in search_server/branches/ngs/index/src: main/java/org/musicbrainz/search/index test/java/org/musicbrainz/search/index

Author: ijabz
Date: 2010-01-04 21:30:25 +0000 (Mon, 04 Jan 2010)
New Revision: 12417

Modified:
   search_server/branches/ngs/index/src/main/java/org/musicbrainz/search/index/RecordingIndex.java
   search_server/branches/ngs/index/src/test/java/org/musicbrainz/search/index/RecordingIndexTest.java
Log:
Revert 12415 & 12413, Release Group Type is still optional after all

Modified: search_server/branches/ngs/index/src/main/java/org/musicbrainz/search/index/RecordingIndex.java
===================================================================
---
search_server/branches/ngs/index/src/main/java/org/musicbrainz/search/index/RecordingIndex.java	2010-01-04
20:40:51 UTC (rev 12416)
+++
search_server/branches/ngs/index/src/main/java/org/musicbrainz/search/index/RecordingIndex.java	2010-01-04
21:30:25 UTC (rev 12417)
 <at>  <at>  -104,7 +104,7  <at>  <at> 
                 "ON m.release=r.id " +
                 "INNER JOIN release_group rg " +
                 "ON rg.id = r.release_group " +
-                "INNER JOIN release_group_type rgt " +    
+                "LEFT JOIN release_group_type rgt " +    
                 "ON rg.type = rgt.id " +
                 "INNER JOIN release_name rn " +
                 "ON r.name=rn.id " +

Modified: search_server/branches/ngs/index/src/test/java/org/musicbrainz/search/index/RecordingIndexTest.java
===================================================================
(Continue reading)


Gmane