root | 1 Apr 2007 02:53
Favicon

[mb-commits] r9000 - mb_server/trunk/cgi-bin/MusicBrainz/Server/Moderation

Author: robert
Date: 2007-04-01 00:53:38 +0000 (Sun, 01 Apr 2007)
New Revision: 9000

Modified:
   mb_server/trunk/cgi-bin/MusicBrainz/Server/Moderation/MOD_CHANGE_ARTIST_QUALITY.pm
Log:
The artist was never loaded, thus the MBID was not available for invalidating the cache. Fixes #2604

Modified: mb_server/trunk/cgi-bin/MusicBrainz/Server/Moderation/MOD_CHANGE_ARTIST_QUALITY.pm
===================================================================
---
mb_server/trunk/cgi-bin/MusicBrainz/Server/Moderation/MOD_CHANGE_ARTIST_QUALITY.pm	2007-03-31
20:37:47 UTC (rev 8999)
+++
mb_server/trunk/cgi-bin/MusicBrainz/Server/Moderation/MOD_CHANGE_ARTIST_QUALITY.pm	2007-04-01
00:53:38 UTC (rev 9000)
 <at>  <at>  -96,6 +96,7  <at>  <at> 
 	require Artist;
 	my $ar = Artist->new($self->{DBH});
 	$ar->SetId($self->GetRowId);
+	$ar->LoadFromId;
 	$ar->UpdateQualityModPending($adjust);
 }
root | 1 Apr 2007 03:24
Favicon

[mb-commits] r9001 - in mb_server/trunk/cgi-bin: . MusicBrainz/Server/Moderation

Author: robert
Date: 2007-04-01 01:24:18 +0000 (Sun, 01 Apr 2007)
New Revision: 9001

Modified:
   mb_server/trunk/cgi-bin/Artist.pm
   mb_server/trunk/cgi-bin/Label.pm
   mb_server/trunk/cgi-bin/MusicBrainz/Server/Moderation/MOD_CHANGE_RELEASE_QUALITY.pm
   mb_server/trunk/cgi-bin/MusicBrainz/Server/Moderation/MOD_MERGE_ARTIST.pm
   mb_server/trunk/cgi-bin/MusicBrainz/Server/Moderation/MOD_MERGE_LABEL.pm
Log:
Fixed #2624

Fix mod pending lag for merge artist and merge label.

Modified: mb_server/trunk/cgi-bin/Artist.pm
===================================================================
--- mb_server/trunk/cgi-bin/Artist.pm	2007-04-01 00:53:38 UTC (rev 9000)
+++ mb_server/trunk/cgi-bin/Artist.pm	2007-04-01 01:24:18 UTC (rev 9001)
 <at>  <at>  -388,6 +388,9  <at>  <at> 
     my $al = Alias->new($old->{DBH});
     $al->SetTable("ArtistAlias");
     $al->Insert($n, $old->GetName);
+
+    # Invalidate the new artist as well
+    $new->InvalidateCache;
 }

 sub UpdateName

(Continue reading)

root | 1 Apr 2007 03:54
Favicon

[mb-commits] r9002 - in mb_server/trunk/cgi-bin/MusicBrainz/Server: . Moderation

Author: robert
Date: 2007-04-01 01:54:08 +0000 (Sun, 01 Apr 2007)
New Revision: 9002

Modified:
   mb_server/trunk/cgi-bin/MusicBrainz/Server/CoverArt.pm
   mb_server/trunk/cgi-bin/MusicBrainz/Server/Moderation/MOD_ADD_ALBUM.pm
   mb_server/trunk/cgi-bin/MusicBrainz/Server/Moderation/MOD_EDIT_ARTIST.pm
   mb_server/trunk/cgi-bin/MusicBrainz/Server/Moderation/MOD_EDIT_RELEASES.pm
Log:
Removed unneeded debug prints.
Fixed the caching of cover art link types

Modified: mb_server/trunk/cgi-bin/MusicBrainz/Server/CoverArt.pm
===================================================================
--- mb_server/trunk/cgi-bin/MusicBrainz/Server/CoverArt.pm	2007-04-01 01:24:18 UTC (rev 9001)
+++ mb_server/trunk/cgi-bin/MusicBrainz/Server/CoverArt.pm	2007-04-01 01:54:08 UTC (rev 9002)
 <at>  <at>  -235,16 +235,16  <at>  <at> 
 sub GetAsinLinkTypeId
 {
 	my $self = shift;
-	return $Album::ASIN_LINK_TYPE_ID if (defined $Album::ASIN_LINK_TYPE_ID);
+	return $ASIN_LINK_TYPE_ID if (defined $ASIN_LINK_TYPE_ID);
 	
 	# try to extract the id from the DB
 	my $dbh = (ref $self ? $self->{DBH} : shift);

 	my $sql = Sql->new($dbh);
-	$Album::ASIN_LINK_TYPE_ID = $sql->SelectSingleValue("SELECT id FROM lt_album_url WHERE name =
'amazon asin'")
(Continue reading)

root | 1 Apr 2007 04:07
Favicon

[mb-commits] r9003 - in mb_server/trunk/htdocs: comp comp/layout mod mod/search

Author: robert
Date: 2007-04-01 02:07:41 +0000 (Sun, 01 Apr 2007)
New Revision: 9003

Modified:
   mb_server/trunk/htdocs/comp/layout/topmenu
   mb_server/trunk/htdocs/comp/notetext
   mb_server/trunk/htdocs/comp/showmoddetail
   mb_server/trunk/htdocs/mod/info.html
   mb_server/trunk/htdocs/mod/search/select-filter.html
Log:
Applying the patches from Prodoc to change the name of edit info to edit conditions.

Modified: mb_server/trunk/htdocs/comp/layout/topmenu
===================================================================
--- mb_server/trunk/htdocs/comp/layout/topmenu	2007-04-01 01:54:08 UTC (rev 9002)
+++ mb_server/trunk/htdocs/comp/layout/topmenu	2007-04-01 02:07:41 UTC (rev 9003)
 <at>  <at>  -226,7 +226,7  <at>  <at> 

 			] : [],
 			{ name => "Review/Vote on Edits",	url => "/mod/search/select-filter.html" },
-			{ name => "Edit information", url => "/mod/info.html" },
+			{ name => "Edit Conditions", url => "/mod/info.html" },
 			[
 				{ url => "/mod/search/pre/new.html" },
 				{ url => "/mod/search/pre/subscriptions.html" },

Modified: mb_server/trunk/htdocs/comp/notetext
===================================================================
--- mb_server/trunk/htdocs/comp/notetext	2007-04-01 01:54:08 UTC (rev 9002)
(Continue reading)

root | 1 Apr 2007 04:14
Favicon

[mb-commits] r9004 - in mb_server/trunk/htdocs: comp comp/layout mod mod/search show/edit

Author: robert
Date: 2007-04-01 02:14:24 +0000 (Sun, 01 Apr 2007)
New Revision: 9004

Added:
   mb_server/trunk/htdocs/show/edit/conditions.html
Removed:
   mb_server/trunk/htdocs/mod/info.html
Modified:
   mb_server/trunk/htdocs/comp/layout/topmenu
   mb_server/trunk/htdocs/comp/notetext
   mb_server/trunk/htdocs/mod/automodlist.html
   mb_server/trunk/htdocs/mod/search/select-filter.html
Log:
Move the edit conditions page to a more logical place. This fixes #2616

Modified: mb_server/trunk/htdocs/comp/layout/topmenu
===================================================================
--- mb_server/trunk/htdocs/comp/layout/topmenu	2007-04-01 02:07:41 UTC (rev 9003)
+++ mb_server/trunk/htdocs/comp/layout/topmenu	2007-04-01 02:14:24 UTC (rev 9004)
 <at>  <at>  -226,7 +226,7  <at>  <at> 

 			] : [],
 			{ name => "Review/Vote on Edits",	url => "/mod/search/select-filter.html" },
-			{ name => "Edit Conditions", url => "/mod/info.html" },
+			{ name => "Edit Conditions", url => "/show/edit/conditions.html" },
 			[
 				{ url => "/mod/search/pre/new.html" },
 				{ url => "/mod/search/pre/subscriptions.html" },

(Continue reading)

root | 1 Apr 2007 04:23
Favicon

[mb-commits] r9005 - mb_server/trunk/admin/reports

Author: robert
Date: 2007-04-01 02:23:20 +0000 (Sun, 01 Apr 2007)
New Revision: 9005

Modified:
   mb_server/trunk/admin/reports/BadAmazonURLs
   mb_server/trunk/admin/reports/BadAmazonURLs.inc
Log:
Added an info link on mo's request

Modified: mb_server/trunk/admin/reports/BadAmazonURLs
===================================================================
--- mb_server/trunk/admin/reports/BadAmazonURLs	2007-04-01 02:14:24 UTC (rev 9004)
+++ mb_server/trunk/admin/reports/BadAmazonURLs	2007-04-01 02:23:20 UTC (rev 9005)
 <at>  <at>  -39,7 +39,7  <at>  <at> 
 	my $sql = $self->SqlObj;

 	$self->GatherDataFromQuery(<<'EOF');
-         SELECT url, album.id as release, album.name as name
+         SELECT url, album.id as release, album.name as name, url.id as urlid
            FROM url, album, l_album_url 
           WHERE link1 = url.id 
             AND link0 = album.id

Modified: mb_server/trunk/admin/reports/BadAmazonURLs.inc
===================================================================
--- mb_server/trunk/admin/reports/BadAmazonURLs.inc	2007-04-01 02:14:24 UTC (rev 9004)
+++ mb_server/trunk/admin/reports/BadAmazonURLs.inc	2007-04-01 02:23:20 UTC (rev 9005)
 <at>  <at>  -113,7 +113,7  <at>  <at> 
 				<td>
(Continue reading)

root | 1 Apr 2007 04:40
Favicon

[mb-commits] r9006 - mb_server/trunk

Author: robert
Date: 2007-04-01 02:40:17 +0000 (Sun, 01 Apr 2007)
New Revision: 9006

Modified:
   mb_server/trunk/CHANGES
Log:
Added link to the milestone closed bug list.

Modified: mb_server/trunk/CHANGES
===================================================================
--- mb_server/trunk/CHANGES	2007-04-01 02:23:20 UTC (rev 9005)
+++ mb_server/trunk/CHANGES	2007-04-01 02:40:17 UTC (rev 9006)
 <at>  <at>  -1,4 +1,4  <at>  <at> 
-Release 2007-XX-XX:
+Release 2007-04-01:

  * New Features:
    * Labels, catalog numbers, barcodes and release formats.
 <at>  <at>  -48,6 +48,10  <at>  <at> 
    * Rephrased the "Reveal my e-mail address" option. (#2438)
    * Tagger icon shows up before new release is submitted. (#2444)

+For a complete list of fixes that went into this release, please see this link:
+
+   http://bugs.musicbrainz.org/query?status=closed&milestone=Server%3A+Labels%2C+Data+quality+and+improved+cover+art&order=priority
+
 ********************************************************************************
 ********************************************************************************
(Continue reading)

root | 1 Apr 2007 04:58
Favicon

[mb-commits] r9007 - metabrainz/trunk/cgi-bin

Author: robert
Date: 2007-04-01 02:58:46 +0000 (Sun, 01 Apr 2007)
New Revision: 9007

Modified:
   metabrainz/trunk/cgi-bin/nagcheck
   metabrainz/trunk/cgi-bin/nagcheck_days
Log:
Make the nagcheck case insensitive

Modified: metabrainz/trunk/cgi-bin/nagcheck
===================================================================
--- metabrainz/trunk/cgi-bin/nagcheck	2007-04-01 02:40:17 UTC (rev 9006)
+++ metabrainz/trunk/cgi-bin/nagcheck	2007-04-01 02:58:46 UTC (rev 9007)
 <at>  <at>  -46,7 +46,7  <at>  <at> 

     $out = $sql->SelectSingleValue("SELECT ((extract(epoch from now()) - extract(epoch from
payment_date)) / 86400) > ((amount + fee) * $days_per_dollar) as nag
                                            FROM donation 
-                                          WHERE moderator = ? 
+                                          WHERE lower(moderator) = lower(?)
                                        ORDER BY payment_date DESC 
                                           LIMIT 1", $args{moderator});

Modified: metabrainz/trunk/cgi-bin/nagcheck_days
===================================================================
--- metabrainz/trunk/cgi-bin/nagcheck_days	2007-04-01 02:40:17 UTC (rev 9006)
+++ metabrainz/trunk/cgi-bin/nagcheck_days	2007-04-01 02:58:46 UTC (rev 9007)
 <at>  <at>  -46,7 +46,7  <at>  <at> 

(Continue reading)

root | 1 Apr 2007 09:07
Favicon

[mb-commits] r9008 - mb_server/trunk/admin/sql

Author: luks
Date: 2007-04-01 07:07:04 +0000 (Sun, 01 Apr 2007)
New Revision: 9008

Modified:
   mb_server/trunk/admin/sql/DropTables.sql
Log:
Missing 'DROP SEQUENCE's.

Modified: mb_server/trunk/admin/sql/DropTables.sql
===================================================================
--- mb_server/trunk/admin/sql/DropTables.sql	2007-04-01 02:58:46 UTC (rev 9007)
+++ mb_server/trunk/admin/sql/DropTables.sql	2007-04-01 07:07:04 UTC (rev 9008)
 <at>  <at>  -98,24 +98,36  <at>  <at> 
 DROP SEQUENCE discid_id_seq;
 DROP SEQUENCE l_album_album_id_seq;
 DROP SEQUENCE l_album_artist_id_seq;
+DROP SEQUENCE l_album_label_id_seq;
 DROP SEQUENCE l_album_track_id_seq;
 DROP SEQUENCE l_album_url_id_seq;
 DROP SEQUENCE l_artist_artist_id_seq;
+DROP SEQUENCE l_artist_label_id_seq;
 DROP SEQUENCE l_artist_track_id_seq;
 DROP SEQUENCE l_artist_url_id_seq;
+DROP SEQUENCE l_label_label_id_seq;
+DROP SEQUENCE l_label_track_id_seq;
+DROP SEQUENCE l_label_url_id_seq;
 DROP SEQUENCE l_track_track_id_seq;
 DROP SEQUENCE l_track_url_id_seq;
 DROP SEQUENCE l_url_url_id_seq;
(Continue reading)

root | 1 Apr 2007 09:15
Favicon

[mb-commits] r9009 - in mb_server/trunk/admin/sql: . updates

Author: luks
Date: 2007-04-01 07:15:37 +0000 (Sun, 01 Apr 2007)
New Revision: 9009

Modified:
   mb_server/trunk/admin/sql/DropFKConstraints.sql
   mb_server/trunk/admin/sql/updates/20061104-1.sql
   mb_server/trunk/admin/sql/updates/20061104-2.sql
Log:
Move modsublabel_fk_moderator from 20061104-1.sql to 20061104-2.sql.

Modified: mb_server/trunk/admin/sql/DropFKConstraints.sql
===================================================================
--- mb_server/trunk/admin/sql/DropFKConstraints.sql	2007-04-01 07:07:04 UTC (rev 9008)
+++ mb_server/trunk/admin/sql/DropFKConstraints.sql	2007-04-01 07:15:37 UTC (rev 9009)
 <at>  <at>  -30,6 +30,9  <at>  <at> 
 ALTER TABLE l_album_artist DROP CONSTRAINT fk_l_album_artist_link0;
 ALTER TABLE l_album_artist DROP CONSTRAINT fk_l_album_artist_link1;
 ALTER TABLE l_album_artist DROP CONSTRAINT fk_l_album_artist_link_type;
+ALTER TABLE l_album_label DROP CONSTRAINT fk_l_album_label_link0;
+ALTER TABLE l_album_label DROP CONSTRAINT fk_l_album_label_link1;
+ALTER TABLE l_album_label DROP CONSTRAINT fk_l_album_label_link_type;
 ALTER TABLE l_label_label DROP CONSTRAINT fk_l_label_label_link0;
 ALTER TABLE l_label_label DROP CONSTRAINT fk_l_label_label_link1;
 ALTER TABLE l_label_label DROP CONSTRAINT fk_l_label_label_link_type;

Modified: mb_server/trunk/admin/sql/updates/20061104-1.sql
===================================================================
--- mb_server/trunk/admin/sql/updates/20061104-1.sql	2007-04-01 07:07:04 UTC (rev 9008)
+++ mb_server/trunk/admin/sql/updates/20061104-1.sql	2007-04-01 07:15:37 UTC (rev 9009)
(Continue reading)


Gmane