Re: [PATCH] Added Musepack support with libmpcdec

Hello Maxime,

* Maxime COSTE <frrrwww <at> gmail.com> wrote:
> Here is a patch that add support for libmpcdec in herrie, allowing it to play
> musepack files.
> 
> Tell me if I need to change anything.

Sorry for letting you wait this long - I've been very busy lately at
work/uni lately.

> +    if (!fd->stream) {
> +        fseek(fd->fp, 0, SEEK_END);
> +        data->size = ftell(fd->fp);
> +        fseek(fd->fp, 0, SEEK_SET);
> +    } else
> +        data->size = 0;

Herrie's streaming implementation is very primitive and has no way to
`taste' a stream to match with an audio module. We should actually have
a list of mime types, but I haven't found any time to do this. Maybe the
best thing would be to just return an error when you hit a stream? I
know, it's not very good, but right now it prevents MP3 streams from
being played.

What's your opinion on this matter?

--

-- 
 Ed Schouten <ed <at> 80386.nl>
 WWW: http://80386.nl/

Re: [PATCH] Added Musepack support with libmpcdec

On Tue, Dec 09, 2008 at 06:48:58PM +0100, Ed Schouten wrote:
> Hello Maxime,
> 
> * Maxime COSTE <frrrwww <at> gmail.com> wrote:
> > Here is a patch that add support for libmpcdec in herrie, allowing it to play
> > musepack files.
> > 
> > Tell me if I need to change anything.
> 
> Sorry for letting you wait this long - I've been very busy lately at
> work/uni lately.
> 

No problem.

> > +    if (!fd->stream) {
> > +        fseek(fd->fp, 0, SEEK_END);
> > +        data->size = ftell(fd->fp);
> > +        fseek(fd->fp, 0, SEEK_SET);
> > +    } else
> > +        data->size = 0;
> 
> Herrie's streaming implementation is very primitive and has no way to
> `taste' a stream to match with an audio module. We should actually have
> a list of mime types, but I haven't found any time to do this. Maybe the
> best thing would be to just return an error when you hit a stream? I
> know, it's not very good, but right now it prevents MP3 streams from
> being played.
> 
> What's your opinion on this matter?

can't play songs

About getting what's playing

Re: About getting what's playing

Hello,

* Schneider <dudektria <at> gmail.com> wrote:
> I wonder if it's possible to get information about what I'm playing, to put
> on a conkyrc or something. Herrie stores this kind of info, puts on a file
> or something?

The latest Herrie snapshot has DBus-support, so if we would add this, we
should do this through DBus. Unfortunately I'm *very* busy lately (work,
school, etc). Any volunteers?

--

-- 
 Ed Schouten <ed <at> 80386.nl>
 WWW: http://80386.nl/

Re: About getting what's playing

Re: About getting what's playing