EasyTAG - Tag editor ()

Andraž 'ruskie' Levstik | 10 Nov 2007 19:58

Support for Ogg images

Is there any way to add support for ogg images to easytag?

--
Andraž "ruskie" Levstik
Source Mage GNU/Linux Games grimoire guru
Geek/Hacker/Tinker

Be sure brain is in gear before engaging mouth.

Key id = F4C1F89C
Key fingerprint = 6FF2 8F20 4C9D DB36 B5B6  F134 884D 72CC F4C1 F89C

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Easytag-mailing mailing list
Easytag-mailing <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/easytag-mailing

headers

Johann Franz | 22 Nov 2007 07:36

Bugfix, changed signature of MP4GetMetadataCoverArt() in libmp4v2-1.6.1

Well, if this hasn't been fixed before - patch applies to easytag 2.1 and 2.1.3:

--- src/mp4_tag.c.orig	2007-11-19 19:27:42.000000000 +0100
+++ src/mp4_tag.c
 <at>  <at>  -185,7 +185,7  <at>  <at>  gboolean Mp4tag_Read_File_Tag (gchar *fi
      * Picture *
      ***********/
     // There is only one picture!
-    if ( MP4GetMetadataCoverArt( mp4file, &coverArt, &coverSize ) )
+    if ( MP4GetMetadataCoverArt( mp4file, &coverArt, &coverSize, 0 ) )
     {
         Picture *pic = Picture_Allocate();
         pic->size = coverSize;

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

_______________________________________________
Easytag-mailing mailing list
Easytag-mailing <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/easytag-mailing

headers

Jérôme COUDERC | 22 Nov 2007 21:00

Re: Bugfix, changed signature of MP4GetMetadataCoverArt() in libmp4v2-1.6.1

Hi,

    Thanks again for this new patch to enable compilation with the last 
version of mpeg4ip 1.6.1.
But also, I need a solution to be compatible with the previous version.

There is a way to detect the version of mpeg4ip or libmp4v2 to include 
some "#if" in the code?

Regards,
Jerome

Johann Franz wrote, the 22/11/2007 07:36 :
> Well, if this hasn't been fixed before - patch applies to easytag 2.1 and 2.1.3:
>
> --- src/mp4_tag.c.orig	2007-11-19 19:27:42.000000000 +0100
> +++ src/mp4_tag.c
>  <at>  <at>  -185,7 +185,7  <at>  <at>  gboolean Mp4tag_Read_File_Tag (gchar *fi
>       * Picture *
>       ***********/
>      // There is only one picture!
> -    if ( MP4GetMetadataCoverArt( mp4file, &coverArt, &coverSize ) )
> +    if ( MP4GetMetadataCoverArt( mp4file, &coverArt, &coverSize, 0 ) )
>      {
>          Picture *pic = Picture_Allocate();
>          pic->size = coverSize;
>   
>

--

--

(Continue reading)

headers

Götz Waschk | 22 Nov 2007 22:45

Re: Bugfix, changed signature of MP4GetMetadataCoverArt() in libmp4v2-1.6.1

On Nov 22, 2007 9:00 PM, Jérôme COUDERC <easytag <at> gmail.com> wrote:
>  Thanks again for this new patch to enable compilation with the last
> version of mpeg4ip 1.6.1.
> But also, I need a solution to be compatible with the previous version.

Hi Jéròme,

I remember I had promised something like that. I wrote a little
configure check, but maybe some autoconf guru can improve it.

Regards, Götz

--

-- 
AL I:40: Do what thou wilt shall be the whole of the Law.

Attachment (easytag-2.1.3-new-mpeg4ip.patch): text/x-patch, 1271 bytes

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

_______________________________________________
Easytag-mailing mailing list
Easytag-mailing <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/easytag-mailing

headers

Jérôme COUDERC | 23 Nov 2007 00:45

Re: Bugfix, changed signature of MP4GetMetadataCoverArt() in libmp4v2-1.6.1

Thanks Götz,

I've tried the attached patch. It detects correctly the version of the 
library, but I've noted that now it doesn't add "-lmp4v2" to the 
compilator flags....

So the compilation fails...

Do you have the same problem?

Regards,
Jerome

Götz Waschk wrote, the 22.11.2007 22:45 :
> On Nov 22, 2007 9:00 PM, Jérôme COUDERC <easytag <at> gmail.com> wrote:
>   
>>  Thanks again for this new patch to enable compilation with the last
>> version of mpeg4ip 1.6.1.
>> But also, I need a solution to be compatible with the previous version.
>>     
>
> Hi Jéròme,
>
> I remember I had promised something like that. I wrote a little
> configure check, but maybe some autoconf guru can improve it.
>
> Regards, Götz
>
>
>

(Continue reading)

headers

Götz Waschk | 23 Nov 2007 08:04

Re: Bugfix, changed signature of MP4GetMetadataCoverArt() in libmp4v2-1.6.1

On Nov 23, 2007 12:45 AM, Jérôme COUDERC <easytag <at> gmail.com> wrote:
> I've tried the attached patch. It detects correctly the version of the
> library, but I've noted that now it doesn't add "-lmp4v2" to the
> compilator flags....
Hi Jérôme,

oh right, autoheader didn't pick up the mp4v2 definition, don't ask me
why. But it is working fine if you rearrange it a bit, see the
attached patch.

Regards, Götz

--

-- 
AL I:40: Do what thou wilt shall be the whole of the Law.

Attachment (easytag-2.1.3-new-mpeg4ip.patch): text/x-patch, 1386 bytes

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

_______________________________________________
Easytag-mailing mailing list
Easytag-mailing <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/easytag-mailing

headers

Götz Waschk | 23 Nov 2007 09:01

Re: Bugfix, changed signature of MP4GetMetadataCoverArt() in libmp4v2-1.6.1

Hi,

a much simpler solution is to just check for the mpeg4ip version, then
you don't need my configure hack at all:

#if MPEG4IP_HEX_VERSION >= 0x10601
    if ( MP4GetMetadataCoverArt( mp4file, &coverArt, &coverSize,0 ) )
#else
    if ( MP4GetMetadataCoverArt( mp4file, &coverArt, &coverSize ) )
#endif

Regards, Götz

--

-- 
AL I:40: Do what thou wilt shall be the whole of the Law.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

headers

EasyTAG | 23 Nov 2007 12:48

Re: Bugfix, changed signature of MP4GetMetadataCoverArt() in libmp4v2-1.6.1

But this shouldn't work if you install only libmp4v2, and not mpeg4ip...

Personally, the first solution seems good for me...

About the version 1.6.1 : the new API allow to read multiple images but you can save only one picture when writing the tag. Isn't it?

Jerome

2007/11/23, Götz Waschk <goetz.waschk <at> gmail.com >:

Hi,

a much simpler solution is to just check for the mpeg4ip version, then
you don't need my configure hack at all:

#if MPEG4IP_HEX_VERSION >= 0x10601
if ( MP4GetMetadataCoverArt( mp4file, &coverArt, &coverSize,0 ) )
#else
if ( MP4GetMetadataCoverArt( mp4file, &coverArt, &coverSize ) )
#endif

Regards, Götz

--
AL I:40: Do what thou wilt shall be the whole of the Law.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Easytag-mailing mailing list
Easytag-mailing <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/easytag-mailing

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

_______________________________________________
Easytag-mailing mailing list
Easytag-mailing <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/easytag-mailing

headers

Götz Waschk | 23 Nov 2007 12:52

Re: Bugfix, changed signature of MP4GetMetadataCoverArt() in libmp4v2-1.6.1

On Nov 23, 2007 12:48 PM, EasyTAG <easytag <at> gmail.com> wrote:
> But this shouldn't work if you install only libmp4v2, and not mpeg4ip...

Is that even possible? Here, mp4.h includes mpeg4ip.h.

> About the version 1.6.1 : the new API allow to read multiple images but you
> can save only one picture when writing the tag. Isn't it?

I don't think so. Maybe you should try to call
MP4SetMetadataCoverArt() several times?

Regards, Götz

--

-- 
AL I:40: Do what thou wilt shall be the whole of the Law.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

headers

EasyTAG | 23 Nov 2007 14:22

Re: Bugfix, changed signature of MP4GetMetadataCoverArt() in libmp4v2-1.6.1

2007/11/23, Götz Waschk <goetz.waschk <at> gmail.com>:

On Nov 23, 2007 12:48 PM, EasyTAG <easytag <at> gmail.com> wrote:
> But this shouldn't work if you install only libmp4v2, and not mpeg4ip...

Is that even possible? Here, mp4.h includes mpeg4ip.h.

Some distributions as Fedora use the package from http://resare.com/libmp4v2/
It was build by keeping only the library mp4v2 from mpeg4ip

> About the version 1.6.1 : the new API allow to read multiple images but you
> can save only one picture when writing the tag. Isn't it?

I don't think so. Maybe you should try to call
MP4SetMetadataCoverArt() several times?

Already tested... it fails :-(

Regards, Götz

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

_______________________________________________
Easytag-mailing mailing list
Easytag-mailing <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/easytag-mailing

Mon	Tue	Wed	Thu	Fri	Sat	Sun

			1	2	3	4
5	6	7	8	9	10	11
12	13	14	15	16	17	18
19	20	21	22	23	24	25
26	27	28	29	30

20	May 2013
9	April 2013
34	March 2013
10	February 2013
11	January 2013
1	December 2012
7	November 2012
7	October 2012
15	September 2012
9	August 2012
8	July 2012
47	June 2012
20	May 2012
1	April 2012
17	March 2012
9	February 2012
25	January 2012
18	December 2011
11	November 2011
2	October 2011
1	August 2011
14	July 2011
13	June 2011
12	May 2011
6	April 2011
11	March 2011
2	February 2011
4	January 2011
6	December 2010
10	November 2010
25	August 2010
5	July 2010
25	June 2010
15	May 2010
2	April 2010
1	March 2010
3	February 2010
3	January 2010
5	December 2009
1	November 2009
10	September 2009
21	August 2009
4	July 2009
3	June 2009
6	May 2009
8	April 2009
1	March 2009
1	February 2009
1	January 2009
8	December 2008
5	November 2008
7	October 2008
2	September 2008
4	August 2008
4	July 2008
11	June 2008
14	May 2008
8	April 2008
6	March 2008
7	February 2008
20	January 2008
31	December 2007
17	November 2007
10	October 2007
8	September 2007
8	August 2007
14	July 2007
18	June 2007
10	May 2007
5	April 2007
24	March 2007
12	February 2007
12	January 2007
13	December 2006
22	November 2006
7	October 2006
11	September 2006
10	August 2006
11	July 2006
26	June 2006
18	May 2006
10	April 2006
7	March 2006
15	February 2006
10	January 2006
3	December 2005
36	November 2005
5	October 2005
17	September 2005
12	August 2005
3	July 2005
6	June 2005