Are patches welcome?

Hi, all.

Are patches welcome in the upstream cdparanoia project?

I am part of the Optical Media tools in Debian, together with Takaki
Taniguchi, taking care of the packaging of some tools, of which
cdparanoia is part.

We have some patches in our tree and it would be desireable to have as
little difference with you as possible. Some patches seem to be quite
trivial (like spelling errors), while others are less trivial.

So, would you like to get the patches that we have? I just checked and
some of them do apply to the SVN repo as of this exact moment.

Thanks in advance, Rogério Brito.

--

-- 
Rogério Brito : rbrito <at> {ime.usp.br,gmail.com} : GPG key 1024D/7C2CAEB8
http://rb.doesntexist.org : Packages for LaTeX : algorithms.berlios.de
DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br
_______________________________________________
Paranoia-dev mailing list
Paranoia-dev <at> xiph.org
http://lists.xiph.org/mailman/listinfo/paranoia-dev

Re: Are patches welcome?

I'm happy to review all patches and there are certainly minor faults
in the current release I need to review for a new release anyway.
This is a good time to send patches in!  If I don't accept them for
one reason or another, I'll give feedback why.

I'm not fussy about indent or style in patches as I carefully review
and hand apply in any case.  Don't worry about nitpicky details, I'm
more interested in what they do and how they do it.

Monty

Re: Are patches welcome?

Hi, Monty.

On 12/09/2009 08:25 PM, xiphmont <at> xiph.org wrote:
> I'm happy to review all patches and there are certainly minor faults
> in the current release I need to review for a new release anyway.
> This is a good time to send patches in!  If I don't accept them for
> one reason or another, I'll give feedback why.

Thank you so very much for your kindness to accept comments from outsiders.

I hope that you don't mind if I send you links for our tree instead of sending
some patches that may be large for e-mails. If you would prefer some other
address to send them to, please let me know.

(I'm still a rookie with git).

> I'm not fussy about indent or style in patches as I carefully review
> and hand apply in any case.  Don't worry about nitpicky details, I'm
> more interested in what they do and how they do it.

Thank you very much.

Rogério Brito.

--

-- 
Rogério Brito : rbrito <at> {ime.usp.br,gmail.com} : GPG key 1024D/7C2CAEB8
http://rb.doesntexist.org : Packages for LaTeX : algorithms.berlios.de
DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br

[patch] cdparanoia sample offset inconsistency

Hello,

Apologies if this is a duplicate. I've sent a previous version to the list 
but it appears it did not get through. The version of the patch included 
herein is better anyway.

I've encountered a problem when using the -O (--sample-offset) option. 
Currently, the code checks whether the specified offset is more than 588 
samples, and if so biases the sectors in the (internal) TOC so that the 
offset becomes less than 588.

However, this creates an inconsistency when the span is analyzed: the span 
might both refer to (corrected) values from the TOC (e.g. end of disk) and 
uncorrected values (e.g. absolute sector positions).

E.g.: [.2000]- (read from sector 2000 to end of disk).

The included patch fixes this by adding the offset in sectors specified 
using absolute positions.

Best regards,

--

-- 
Eric Lesage

Index: interface/cdda_interface.h
===================================================================
--- interface/cdda_interface.h	(revision 16745)
+++ interface/cdda_interface.h	(working copy)
 <at>  <at>  -66,6 +66,8  <at>  <at> 

Re: Are patches welcome?

> I hope that you don't mind if I send you links for our tree instead of
> sending
> some patches that may be large for e-mails. If you would prefer some other
> address to send them to, please let me know.

I strongly prefer having patches, along with descriptions of what the
patches do.  It saves me the work of filtering irrelevant
inconsistencies between the source trees, as well as forces the
submitter to do a little additional review before submission 

I understand patches are not of interest to the entire list; feel free
to mail them to me directly (monty <at> xiph.org or xiphmont <at> gmail.com).

Thank you!
Monty