Joe Kappus | 11 Jun 06:05 2014
Picon

[PATCH] Fix reading last track when using -O on some drives

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I just wanted to confirm this patch works for me and is indeed required 
in order to make secure rips with my GSA-U20N drive with offset +667.  
Without it the last track will fail on many CD's.  Arch has already 
included this patch in this package: 
no known packages for any other major distro.  It would be ideal if 
upstream could include this.     

Drives requiring a larger offset are fairly common and there's quite a 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJTl9UxAAoJEEqI9cVGWZwK8LYP/2a6D6MAqm2qQ00lTd/yj5Ma
ndRnDna2kn0uaGcOIQRkorboIwsUim28fJ6B78+LSCMX6n61v0odg0KAIgUuGLrK
v38LSV///MAU0wio7wgUV+IkdpaSM/urN++txjX28Sq++QOdhaliGIs/cBGczjsk
bT3dihrFodONmZYfBQ/YJlrLnfmRsvmYI8SfMUmwZ8TKxMQPeY1oI/0/fF4ZaARo
zZ3eGz6FkXGTTx+ZZIO/jZhS0teH03sj7Igihp7tfGtRBk8nNELm/u8T0Iu4JU8u
EucwO5F4/8pClNe5TrO18xqaEpFECsAIuOtkMBKjQnslKzIF7ttYRbVZf6U0ms5S
ODQ33QkDkGcUhCDYmhMItLyVitTFjgQhBGn3YvsmiIJLaubMp2zMsYg53nWd6F+A
GrwjedCakYfNwlM/nOotyIkhjBVuRMmpg3f3dj27ovRNgGTlpSuTaF6r3wwuaAbC
JvF3Ft1kUdNUMXFSmpPQf5JHzMvrG27DZLk9RHKCJaYStsloXeFXNBHReqkZMcm2
qxLCnV+ZOt66zfFEYA2zMIaC5ilxWDQ9aKDDqt+FfrgSurbZGJJ/3waCXibiFL4f
LWg0FuMgxn+CaNT8Kl1IPZPtnAXBJAG7XPOhfDwcw/cDcfSzwxomCcZuLK6c287E
rsLnl3CWeRKSNg4Jq3kI
=rP4d
-----END PGP SIGNATURE-----

_______________________________________________
Paranoia-dev mailing list
Paranoia-dev <at> xiph.org
http://lists.xiph.org/mailman/listinfo/paranoia-dev
Weird Kerning | 30 Jul 17:02 2013
Picon

Fwd: [PATCH] Fix reading last track when using -O on some drives

Hi,

Sorry, just realized I sent these to the wrong list. Didn't realize there was a -dev mailing list.

The second patch fixes an issue that occurs for some (but not all, apparently) drives that do not support overreading when ripping the last audio track if it's followed by a data track.


---------- Forwarded message ----------
From: Weird Kerning <weirdkerning <at> gmail.com>
Date: Mon, Jul 29, 2013 at 11:15 AM
Subject: [PATCH] Fix reading last track when using -O on some drives
To: paranoia <at> xiph.org


Hi,

It's often desirable to pass -O <sample offset> when ripping discs so that it's easy to assess the accuracy of the rip by comparing to the rips other have made by using AccurateRip and the like. On drives that require a large -- presumably >= 588 -- sample offset correction that do not support reading into the lead-out area of the disc, cdparanoia will cause (Linux -- not tested elsewhere) kernel transport errors and will fail when trying to rip the last track.

This patch adds an option to force overreading into the lead-out (-x, --force-overread) when ripping the last track on the disc, which is disabled by default, since most drives are not actually able to successfully do this. When it's not enabled, digital silence is written to pad out the extracted audio so the track is the correct length. This matches the behavior of other popular DAE tools like EAC and dbpoweramp.

This patch also fixes a bug that prevented overreading into the lead-out from working even on drives that do support it. Without this patch when using a read offset correction even for drives that do correctly overread, the samples that are in the lead-out after offset correction were not being correctly read, and were being written to the output as digital silence. This patch forces a buffer flush before trying to read the extra sectors, which causes the data to actually be read.

This patch resolves issues users have hit this issue: https://github.com/thomasvs/morituri/issues/36  when using morituri, a cli DAE tool that uses cdparanoia for audio extraction.

Patch is against the head of the cdparanoia svn repo. Please apply if appropriate.

Attachment (01-overread.patch): application/octet-stream, 9 KiB
Attachment (02-overread_data.patch): application/octet-stream, 2650 bytes
_______________________________________________
Paranoia-dev mailing list
Paranoia-dev <at> xiph.org
http://lists.xiph.org/mailman/listinfo/paranoia-dev
Phillip Susi | 15 Jul 21:52 2013

paranoia_mode bits


I've been looking over the sources of sound-juicer lately and am a bit
confused by the paranoia_mode bits.  It seems that sound-juicer
PARANOIA_MODE_SCRATCH, and the cdparanoia gstreamer plugin defaults to
PARANOIA_MODE_FRAGMENT, but looking at the cdparanoia sources, it
looks like neither of these bits are implemented, so setting either of
these values should be equivalent to MODE_DISABLE.

The only bits I see used in the sources are VERIFY, OVERLAP, and
NEVERSKIP, and VERIFY implies OVERLAP.

Am I missing something here?

Edson | 29 May 09:04 2013
Picon

Aprovados lista publicada Major Isidoro

Aprovados lista publicada Major Isidoro:

Vila Rica: ANA PAULA PEREIRA DA SILVA, LUCAS ARAUJO DA SILVA, GABRIEL LIMA VALENTIM, QUEZIA GOMES SNTOS,
JOÃO CARLOS MOREIRA DE CARVALHO, DAYA VALE DOS SANTOS, MARIA JOSEANE DE SOUZA, JOAO HUDSON OLIVEIRA
NUNES. SUÉNIA CONCEIÇÃO SILVA, BRUNO MORAES NASCIMENTO, LUIZ GUSTAVO SILVA CRISPIM DE LIMA, HYAGO
KENNEDY FERNANDES DE SOUSA, RICHELLE DANTAS SILVA. Pastos Bons.

Major Isidoro, ANA FLÁVIA DA SILVA, LUAN MARLLUS MAIA RAULINO, FRANCISCO MARIO ROCHA DE MELO, PEDRO IGOR
GARCIA COSTA, JOÃO CARLOS MOREIRA DE CARVALHO, DANIEL GUIMARAES CORDEIRO, MARIA IVONEIDE DE OLIVEIRA
NASCIMENTO, JESICA FREITAS E SILVA. SILVONEIDE DE O, AYSLAN CORDEIRO DO SANTIAGO, LUCIANA SOARES F. DA
SILVA, HARIANNE LEITE DE ALENCAR, REJANE SANTA CELESTINA DA SILVA. Carandaí. 

Presidente Dutra e ANA PAULA DA SILVA AMORIM, LUCAS ALEXANDRE DAMASCENO, FRANCISCO RUBENS MENDES
MARTINS, PRISCILA BARROS COSTA, JOÃO CARLOS MOREIRA DE CARVALHO, DAVID DA SILVA PINHEIRO, MARIA JOSÉ
FIGUEIRA DA SILVA, JOAO BATISTA DE OLIVEIRA SILVA. SONIA MARA SOUSA SANTANA, BRUNA THAINA CASTRO
AMAZONAS, LUISA CARLA ARAUJO PAIVA DE CARVALHO, HILDEJONES DOMINGOS DE SOUZA NETO, RHAYSSA ABREU ROCHA. Niquelândia.
Andrew Smith | 28 Dec 08:34 2010
Picon

Link to Asunder

Hi

Sorry for the spam, I don't know who to email. I just feel it's a shame 
and wanted to ask you to fix it if willing:

Would mind adding a link to Asunder ( http://littlesvr.ca/asunder/ ) on 
your Links page?

Thanks

Andrew
Billy | 9 Nov 18:41 2010
Picon

PATCH: slight memleak in initialization

Also simplify the pattern-matching loop that generates device names.


Reported 6 years ago as Debian Bug #245167 [1] and long forgotten about.

But the bug is still in the code, so I revamped the patch.

Attachment (cdparanoia_memleak_fix.patch): application/octet-stream, 1414 bytes
_______________________________________________
Paranoia-dev mailing list
Paranoia-dev <at> xiph.org
http://lists.xiph.org/mailman/listinfo/paranoia-dev
Tim-Philipp Müller | 13 Apr 13:38 2010
Picon

[PATCH] add pkg-config .pc file for cdparanoia

Hi,

it would be nice if Cdparanoia installed a .pc file for pkg-config
alongside its headers and libs.

This makes it easier for applications and libs using cdparanoia to
correctly check for the existence of cdparanoia, query its version, or
figure out the right include paths and linker flags.

Patch attached (configure in svn will need to be recreated after
applying the patch).

 Cheers
  -Tim
_______________________________________________
Paranoia-dev mailing list
Paranoia-dev <at> xiph.org
http://lists.xiph.org/mailman/listinfo/paranoia-dev
Eric Lesage | 11 Dec 09:31 2009
Picon

[patch] cdparanoia sample offset inconsistency

Hello,

Apologies if this is a duplicate. I've sent a previous version to the list 
but it appears it did not get through. The version of the patch included 
herein is better anyway.

I've encountered a problem when using the -O (--sample-offset) option. 
Currently, the code checks whether the specified offset is more than 588 
samples, and if so biases the sectors in the (internal) TOC so that the 
offset becomes less than 588.

However, this creates an inconsistency when the span is analyzed: the span 
might both refer to (corrected) values from the TOC (e.g. end of disk) and 
uncorrected values (e.g. absolute sector positions).

E.g.: [.2000]- (read from sector 2000 to end of disk).

The included patch fixes this by adding the offset in sectors specified 
using absolute positions.

Best regards,

-- 
Eric Lesage
Index: interface/cdda_interface.h
===================================================================
--- interface/cdda_interface.h	(revision 16745)
+++ interface/cdda_interface.h	(working copy)
 <at>  <at>  -66,6 +66,8  <at>  <at> 
   long audio_first_sector;
   long audio_last_sector;
 
+  long manual_sector_offset; /* Offset in sectors specified by user with -O */
+
   int errordest;
   int messagedest;
   char *errorbuf;
Index: interface/toc.c
===================================================================
--- interface/toc.c	(revision 16745)
+++ interface/toc.c	(working copy)
 <at>  <at>  -23,7 +23,9  <at>  <at> 
       return(-401);
     }
     else {
-      return 0; /* pre-gap of first track always starts at lba 0 */
+      return d->manual_sector_offset; /* pre-gap of first track always starts
+	                               * at lba 0 (but we need to account for
+				       * manual correction) */
     }
   }
 
 <at>  <at>  -45,7 +47,7  <at>  <at> 
   for(i=0;i<d->tracks;i++)
     if(cdda_track_audiop(d,i+1)==1) {
       if (i == 0) /* disc starts at lba 0 if first track is an audio track */
-       return 0;
+       return d->manual_sector_offset; /* account for manual correction */
       else
        return(cdda_track_firstsector(d,i+1));
     }
Index: main.c
===================================================================
--- main.c	(revision 16745)
+++ main.c	(working copy)
 <at>  <at>  -1087,6 +1087,9  <at>  <at> 
     }
   }
 
+  /* Save it to report correct offsets later. */
+  d->manual_sector_offset = toc_offset;
+
   if(toc_bias){
     toc_offset=-cdda_track_firstsector(d,1);
   }
_______________________________________________
Paranoia-dev mailing list
Paranoia-dev <at> xiph.org
http://lists.xiph.org/mailman/listinfo/paranoia-dev
Rogério Brito | 7 Dec 15:36 2009
Picon

Are patches welcome?

Hi, all.

Are patches welcome in the upstream cdparanoia project?

I am part of the Optical Media tools in Debian, together with Takaki
Taniguchi, taking care of the packaging of some tools, of which
cdparanoia is part.

We have some patches in our tree and it would be desireable to have as
little difference with you as possible. Some patches seem to be quite
trivial (like spelling errors), while others are less trivial.

So, would you like to get the patches that we have? I just checked and
some of them do apply to the SVN repo as of this exact moment.

Thanks in advance, Rogério Brito.

--

-- 
Rogério Brito : rbrito <at> {ime.usp.br,gmail.com} : GPG key 1024D/7C2CAEB8
http://rb.doesntexist.org : Packages for LaTeX : algorithms.berlios.de
DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br
_______________________________________________
Paranoia-dev mailing list
Paranoia-dev <at> xiph.org
http://lists.xiph.org/mailman/listinfo/paranoia-dev
Russell Salerno | 3 Oct 23:02 2009
Picon

Patch for original XBOX drives

Hello all,

I'm on a mission to get cdparanoia to work on original XBoxes (not
360) fitted with Philips and/or Thompson DVD drives.  In sum, the
original XBox came fitted with either a Thompson, Philips, or Samsung
DVD drive.  Cdparanoia recognizes and works with the XBox Samsung
drive, but not the Philips and/or Thompson drives because they do not
identify themselves as having CD ripping capabilities.  I tried
patching the release 10pre0 (which is the installed version on my xDSL
box) with Michael Steil's patch but it did not make any difference.
See, e.g., http://lists.xiph.org/pipermail/paranoia-dev/2003-August/000125.html

Ultimately I'd like to add an option e.g., -xbox philips or -xbox
thompson that will force cdparanoia to skip any drive capability tests
and just rip using predetermined parameters.

My question to the group is where in the code should I start poking to
implement such a patch and also, if anyone has attempted this and/or
has any other insight into this particular area.

Thanks in advance,

Russell Salerno
Martin Thierer | 27 Sep 17:04 2009
Picon

cdparanoia hangs on the last track when using both --sample-offset and -Z

Hi,

I'm running cdparanoia 10.2 on gentoo linux x64.

When ripping the last track of an audio-cd and using both the options
"--sample-offset" and "-Z", cdparanoia consistently hangs at the end of
the rip. When dropping either of these options or ripping a different
track everything works fine. The actual sample-offset used doesn't seem
to have an effect.

This happens with both of my drives. I'm using the /dev/srx interfaces.

When running cdparanoia with option "-e", it keeps looping through the
message "##: 6 [skip]  <at>  0".

Please tell me if there's more information I could provide to help to
debug the problem.

Thank you very much!

Martin

Gmane