Matt Hughes (JIRA | 1 May 20:11 2007
Picon

Commented: (SHALE-409) Shale 1.0.4+ incorrectly removes all entries in the request map after render response


    [
https://issues.apache.org/struts/browse/SHALE-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40918
] 

Matt Hughes commented on SHALE-409:
-----------------------------------

There clearly is a bug in this method.  In the first while block, it finds all keys in the request map whose
value is of a certain type.  And then in the second while block, it finds all keys in the map that it hasn't
already added before.  Therefore, after the second while block, the 'list' variable has EVERY KEY that was
in the original map.  If that is really what you intended, you could have made the method a lot simpler:
map.clear().  I would submit a fix for this but I really can't figure out what that second while block is
trying to do.  Any ideas?  This bug breaks ajax4jsf as well as any other library expecting their request
attributes to stay put.

// In ViewPhaseListener
    private void afterRenderResponse(PhaseEvent event) {

        // Initialize local values we will need
        Map map = event.getFacesContext().getExternalContext().getRequestMap();
        // Remove our list of initialized views explicitly
        map.remove(FacesConstants.VIEWS_INITIALIZED);

        List list = new ArrayList();
        Iterator entries = map.entrySet().iterator();

        // First select all the ViewController and AbstractRequestBean instances
        while (entries.hasNext()) {
            Map.Entry entry = (Map.Entry) entries.next();
(Continue reading)

Hasan Turksoy (JIRA | 3 May 09:44 2007
Picon

Created: (SHALE-441) validator script should not be generated for child components inside not rendered or not editable or not enabled parent component.

validator script should not be generated for child components inside not rendered or not editable or not
enabled parent component.
----------------------------------------------------------------------------------------------------------------------------------

                 Key: SHALE-441
                 URL: https://issues.apache.org/struts/browse/SHALE-441
             Project: Shale
          Issue Type: Bug
          Components: Validator
    Affects Versions: 1.0.4
         Environment: jsf 1.1, commons-validator 1.3.1
            Reporter: Hasan Turksoy

A mail at user mailing list exists about this issue: http://www.nabble.com/-validator--possible-bug-in-validator-script-generation-for-child-comp.-inside-not-rendered-parent-comp.-tf3681172.html

ValidatorScript class is generating scripts only for (editable AND rendered AND [not disabled or
readonly]) fields... this is ok.. issue is; if i put a validator for a component comforming above
conditions but inside a parent component not comforming above condition, it's still generating scripts
for that field... but when parent not rendered, my child component won't be rendered too. In this case,
generated scripts throw javascript errors since they can not find the related field to validate...

Suppose i have a text box with a validator inside... if i use this textbox directly, it should generate
validation script for this field... But if i put this textbox inside a NOT RENDERED panel, it shouldn't
generate validation scripts for my textbox... like below case;

<h:panelGroup rendered="false"> // child components won't be rendered because parent's not rendered
  <h:inputText id="txt_name" ....>
   <s:commonsValidator type="required" arg="Name" server="true" client="true" />
  </h:inputText>
</h:panelGroup>
(Continue reading)

Hermod Opstvedt (JIRA | 7 May 18:40 2007
Picon

Created: (SHALE-442) Add exclusion filter to Shale Validator

Add exclusion filter to Shale Validator
---------------------------------------

                 Key: SHALE-442
                 URL: https://issues.apache.org/struts/browse/SHALE-442
             Project: Shale
          Issue Type: Improvement
          Components: Validator
    Affects Versions: 1.1.0-SNAPSHOT
            Reporter: Hermod Opstvedt
             Fix For: 1.1.0-SNAPSHOT

Shale validator automatically wraps all JSF components with shalevalidatingrenderer. This means that
for instance the tomahawk inpuSuggestAjax component does not work, because it checks to see if the
renderer is ajaxrenderer. This means you can not have both, which is a shame because both have their place
in a web 2.0 app.

--

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Gary VanMatre (JIRA | 8 May 04:21 2007
Picon

Assigned: (SHALE-441) validator script should not be generated for child components inside not rendered or not editable or not enabled parent component.


     [
https://issues.apache.org/struts/browse/SHALE-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary VanMatre reassigned SHALE-441:
-----------------------------------

    Assignee: Gary VanMatre

> validator script should not be generated for child components inside not rendered or not editable or not
enabled parent component.
> ----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SHALE-441
>                 URL: https://issues.apache.org/struts/browse/SHALE-441
>             Project: Shale
>          Issue Type: Bug
>          Components: Validator
>    Affects Versions: 1.0.4
>         Environment: jsf 1.1, commons-validator 1.3.1
>            Reporter: Hasan Turksoy
>         Assigned To: Gary VanMatre
>
> A mail at user mailing list exists about this issue: http://www.nabble.com/-validator--possible-bug-in-validator-script-generation-for-child-comp.-inside-not-rendered-parent-comp.-tf3681172.html
> ValidatorScript class is generating scripts only for (editable AND rendered AND [not disabled or
readonly]) fields... this is ok.. issue is; if i put a validator for a component comforming above
conditions but inside a parent component not comforming above condition, it's still generating scripts
for that field... but when parent not rendered, my child component won't be rendered too. In this case,
generated scripts throw javascript errors since they can not find the related field to validate...
> Suppose i have a text box with a validator inside... if i use this textbox directly, it should generate
(Continue reading)

Lionel Port (JIRA | 8 May 09:38 2007
Picon

Created: (SHALE-443) ClassNotFound Exception when deploy Shale-Validator to weblogic 9.2

ClassNotFound Exception when deploy Shale-Validator to weblogic 9.2
-------------------------------------------------------------------

                 Key: SHALE-443
                 URL: https://issues.apache.org/struts/browse/SHALE-443
             Project: Shale
          Issue Type: Bug
          Components: Validator
    Affects Versions: 1.0.4
         Environment: Weblogic 9.2
            Reporter: Lionel Port

When shale-validator.jar is installed in a web application and deployed to weblogic 9.2 a
ClassNotFoundException is thrown. The class name that is being loaded is the new line character "\n". The
problem even exists with the samples application.

java.lang.ClassNotFoundException: 

	at weblogic.utils.classloaders.GenericClassLoader.findLocalClass(GenericClassLoader.java:286)
	at weblogic.utils.classloaders.GenericClassLoader.findClass(GenericClassLoader.java:259)
	at weblogic.utils.classloaders.ChangeAwareClassLoader.findClass(ChangeAwareClassLoader.java:54)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:251)

--

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

(Continue reading)

Hermod Opstvedt (JIRA | 8 May 09:49 2007
Picon

Commented: (SHALE-443) ClassNotFound Exception when deploy Shale-Validator to weblogic 9.2


    [
https://issues.apache.org/struts/browse/SHALE-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40941
] 

Hermod Opstvedt commented on SHALE-443:
---------------------------------------

Hi

This is a problem inside WLS:

see: http://www.nabble.com/BEA-don't-support-shale-on-Weblogic-Server-9.2-t3252752.html

> ClassNotFound Exception when deploy Shale-Validator to weblogic 9.2
> -------------------------------------------------------------------
>
>                 Key: SHALE-443
>                 URL: https://issues.apache.org/struts/browse/SHALE-443
>             Project: Shale
>          Issue Type: Bug
>          Components: Validator
>    Affects Versions: 1.0.4
>         Environment: Weblogic 9.2
>            Reporter: Lionel Port
>
> When shale-validator.jar is installed in a web application and deployed to weblogic 9.2 a
ClassNotFoundException is thrown. The class name that is being loaded is the new line character "\n". The
problem even exists with the samples application.
> java.lang.ClassNotFoundException: 
(Continue reading)

Ryan Wynn (JIRA | 11 May 01:26 2007
Picon

Created: (SHALE-444) Eclipse Plugin

Eclipse Plugin
--------------

                 Key: SHALE-444
                 URL: https://issues.apache.org/struts/browse/SHALE-444
             Project: Shale
          Issue Type: New Feature
          Components: Clay
         Environment: Any environment supported by Eclipse
            Reporter: Ryan Wynn

Provide a clay plugin for eclipse.  Create a visual editor targeted towards creating/maintaining clay
component metadata.  Support autodetection of clay component definitions in the workspace.  Allow
component extension through drag and drop from a component palette.  Provide autocompletion of managed
bean names and methods.  Support both visual and text modes.

--

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Ryan Wynn (JIRA | 11 May 01:34 2007
Picon

Updated: (SHALE-444) Eclipse Plugin


     [
https://issues.apache.org/struts/browse/SHALE-444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan Wynn updated SHALE-444:
----------------------------

    Attachment: shale-clay-plugin-src.zip

This is a zipped up Eclipse Plugin project containing the src code for a basic Shale clay plugin.  This plugin
has runtime dependencies which must be added to the project before it will run.  These dependencies are not
packaged with the attached source.

The runtime dependencies are commons-beanutils, commons-collections, commons-logging,
commons-digester, shale-clay, shale-core, and servlet-api.jar  It is expected that these libraries
with be provided in the /lib directory under the root of the project.

Also, you will need to make sure you have the gef and xerces plugins installed in eclipse.

> Eclipse Plugin
> --------------
>
>                 Key: SHALE-444
>                 URL: https://issues.apache.org/struts/browse/SHALE-444
>             Project: Shale
>          Issue Type: New Feature
>          Components: Clay
>         Environment: Any environment supported by Eclipse
>            Reporter: Ryan Wynn
>         Attachments: shale-clay-plugin-src.zip
(Continue reading)

Lionel Port (JIRA | 11 May 02:04 2007
Picon

Commented: (SHALE-443) ClassNotFound Exception when deploy Shale-Validator to weblogic 9.2


    [
https://issues.apache.org/struts/browse/SHALE-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40962
] 

Lionel Port commented on SHALE-443:
-----------------------------------

There should still be something that shale can do about it. That link you posted says its a problem with the
declaration of the org.apache.shale.validator.faces.ValidatorLifecycleListener and that myfaces
may have had a similar problem but was able to develop a work around.

> ClassNotFound Exception when deploy Shale-Validator to weblogic 9.2
> -------------------------------------------------------------------
>
>                 Key: SHALE-443
>                 URL: https://issues.apache.org/struts/browse/SHALE-443
>             Project: Shale
>          Issue Type: Bug
>          Components: Validator
>    Affects Versions: 1.0.4
>         Environment: Weblogic 9.2
>            Reporter: Lionel Port
>
> When shale-validator.jar is installed in a web application and deployed to weblogic 9.2 a
ClassNotFoundException is thrown. The class name that is being loaded is the new line character "\n". The
problem even exists with the samples application.
> java.lang.ClassNotFoundException: 
>             
> 	at weblogic.utils.classloaders.GenericClassLoader.findLocalClass(GenericClassLoader.java:286)
(Continue reading)

Lionel Port (JIRA | 11 May 02:13 2007
Picon

Commented: (SHALE-409) Shale 1.0.4+ incorrectly removes all entries in the request map after render response


    [
https://issues.apache.org/struts/browse/SHALE-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40963
] 

Lionel Port commented on SHALE-409:
-----------------------------------

Beyond just commenting out the code to remove the keys from the request, it looks like that whole function is redundant.

All it does is populate a list that will never be used again and remove all the request attributes.

> Shale 1.0.4+ incorrectly removes all entries in the request map after render response
> -------------------------------------------------------------------------------------
>
>                 Key: SHALE-409
>                 URL: https://issues.apache.org/struts/browse/SHALE-409
>             Project: Shale
>          Issue Type: Bug
>          Components: View
>    Affects Versions: 1.0.4, 1.0.5-SNAPSHOT
>         Environment: WinXP, AJAX4JSF-1.0.6+, Shale-1.0.4 (Application, Core, Dialog, Spring, Tiger, View)
>            Reporter: Todd Bush
>
> I found this issue while debugging why Shale-1.0.4 caused AJAX4JSF to stop working.  Within the
ViewPhaseListener.afterRenderResponse method, all ViewControllers and AbstractRequestBeans are
removed from the request map.  Then a second loop through the request map removes all other entries in an
attempt to remove any annotated managed beans.  AJAX4JSF relies on entries in the request map while
parsing the outgoing HTML, entries which are removed by this phase listener.  Once I comment out the second
request map loop, AJAX4JSF works.  Any other technology which relies on request map entries after render
(Continue reading)


Gmane