Jacklondon Chen (JIRA | 20 Jul 19:31 2016
Picon

[jira] [Commented] (LOG4NET-522) add sample log4net.xml for AdoNetAppender using ConnectionType of OleDbConnection


    [
https://issues.apache.org/jira/browse/LOG4NET-522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15386253#comment-15386253
] 

Jacklondon Chen commented on LOG4NET-522:
-----------------------------------------

I mean for SQL Server.
How to write log4net.xml ? What SQL is used to create log table ? What SQL is used to insert log?

> add sample log4net.xml for AdoNetAppender using ConnectionType of OleDbConnection
> ---------------------------------------------------------------------------------
>
>                 Key: LOG4NET-522
>                 URL: https://issues.apache.org/jira/browse/LOG4NET-522
>             Project: Log4net
>          Issue Type: Improvement
>          Components: Examples
>    Affects Versions: 1.2.15
>            Reporter: Jacklondon Chen
>              Labels: documentation
>   Original Estimate: 504h
>  Remaining Estimate: 504h
>
> It's hard to make a configuration file log4net.xml for AdoNetAppender using ConnectionType of OleDbConnection.
> Can the developer give a sample of this?

--
This message was sent by Atlassian JIRA
(Continue reading)

Jacklondon Chen (JIRA | 20 Jul 19:20 2016
Picon

[jira] [Created] (LOG4NET-522) add sample log4net.xml for AdoNetAppender using ConnectionType of OleDbConnection

Jacklondon Chen created LOG4NET-522:
---------------------------------------

             Summary: add sample log4net.xml for AdoNetAppender using ConnectionType of OleDbConnection
                 Key: LOG4NET-522
                 URL: https://issues.apache.org/jira/browse/LOG4NET-522
             Project: Log4net
          Issue Type: Improvement
          Components: Examples
    Affects Versions: 1.2.15
            Reporter: Jacklondon Chen

It's hard to make a configuration file log4net.xml for AdoNetAppender using ConnectionType of OleDbConnection.
Can the developer give a sample of this?

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Gregory Zak (JIRA | 18 Jul 22:29 2016
Picon

[jira] [Commented] (LOG4NET-510) FileAppender.InterProcessLock.AcquireLock blocks everything


    [
https://issues.apache.org/jira/browse/LOG4NET-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383010#comment-15383010
] 

Gregory Zak commented on LOG4NET-510:
-------------------------------------

Just wanted to add to this: I can consistently reproduce a hang by restricting the log folder such that the
application doesn't have write permission and deleting the log file itself, then running the
application normally.

When it tries to create the file for the first time, presumably it silently fails the first time due to
permission issues, which is good. But any subsequent log attempts hang indefinitely.

> FileAppender.InterProcessLock.AcquireLock blocks everything
> -----------------------------------------------------------
>
>                 Key: LOG4NET-510
>                 URL: https://issues.apache.org/jira/browse/LOG4NET-510
>             Project: Log4net
>          Issue Type: Bug
>          Components: Appenders
>    Affects Versions: 1.2.13
>         Environment: Windows 2012
>            Reporter: StevenXi
>            Priority: Critical
>         Attachments: screenshot-1.png
>
>
(Continue reading)

Charles Lowell (JIRA | 14 Jul 00:40 2016
Picon

[jira] [Comment Edited] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not


    [
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15375927#comment-15375927
] 

Charles Lowell edited comment on LOG4NET-467 at 7/13/16 10:39 PM:
------------------------------------------------------------------

I've attached the contents of my pull request (#16) as a patch.

was (Author: chlowe):
Patch containing GitHub Pull Request #16

> Is .NET Core, will be supported in the near future, or not
> ----------------------------------------------------------
>
>                 Key: LOG4NET-467
>                 URL: https://issues.apache.org/jira/browse/LOG4NET-467
>             Project: Log4net
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 1.2.13
>            Reporter: san kan
>              Labels: features
>         Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
(Continue reading)

Charles Lowell (JIRA | 14 Jul 00:40 2016
Picon

[jira] [Updated] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not


     [
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Charles Lowell updated LOG4NET-467:
-----------------------------------
    Attachment: LOG4NET-467.patch

Patch containing GitHub Pull Request #16

> Is .NET Core, will be supported in the near future, or not
> ----------------------------------------------------------
>
>                 Key: LOG4NET-467
>                 URL: https://issues.apache.org/jira/browse/LOG4NET-467
>             Project: Log4net
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 1.2.13
>            Reporter: san kan
>              Labels: features
>         Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?

(Continue reading)

ASF GitHub Bot (JIRA | 13 Jul 17:46 2016
Picon

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not


    [
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15375230#comment-15375230
] 

ASF GitHub Bot commented on LOG4NET-467:
----------------------------------------

Github user chlowell commented on a diff in the pull request:

    https://github.com/apache/log4net/pull/16#discussion_r70652017

    --- Diff: src/Util/ReadOnlyPropertiesDictionary.cs ---
     <at>  <at>  -215,8 +216,13  <at>  <at>  public virtual void GetObjectData(SerializationInfo info, StreamingContext conte
     				string entryKey = entry.Key as string;
     				object entryValue = entry.Value;

    -				// If value is serializable then we add it to the list
    -				if (entryKey != null && entryValue != null && entryValue.GetType().IsSerializable)
    +                // If value is serializable then we add it to the list
    +#if NETSTANDARD1_3
    +			    bool isSerializable = entryValue.GetType().GetTypeInfo().IsSerializable;
    +#else
    +                bool isSerializable = entryValue.GetType().IsSerializable;
    +#endif
    +                if (entryKey != null && entryValue != null && isSerializable)
     				{
    --- End diff --

    The original code mixes tabs and spaces freely. I tried to remain consistent with that to limit whitespace
(Continue reading)

ASF GitHub Bot (JIRA | 13 Jul 16:10 2016
Picon

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not


    [
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15375066#comment-15375066
] 

ASF GitHub Bot commented on LOG4NET-467:
----------------------------------------

Github user jasonwilliams200OK commented on the issue:

    https://github.com/apache/log4net/pull/16

    >  <at> arkadiuszwojcik the goal of this PR is to make log4net portable across .NET Core platforms.
Implementing those abstractions could be useful, but doing so wouldn't enable consuming log4net on
additional platforms.

    I agree and I think that can be a separate repo / package, something like log4net.Extensions.Logging.
However, having this Extensions package first hand from original vendor (Apache) is vital on multiple accounts.

    ---

    Separately, can this PR get some prio love from the reviews please? All the providers listed here:
https://github.com/aspnet/Logging#providers, are not as popular as log4net and we (folks running
stuff on dotnet core) hoping to get our hands on apache/log4net bits.

     <at> chlowell, could you please prepare a SVN patch for the reviewers? We can always have subsequent PRs to
refine stuff. If you are aiming to add CI setup for .NET Core TxM as part of this PR, feel free to grab
Travis/AppVeyor bits from https://github.com/autofac/Autofac.Extras.Moq/pull/6/files.

> Is .NET Core, will be supported in the near future, or not
(Continue reading)

ASF GitHub Bot (JIRA | 13 Jul 15:49 2016
Picon

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not


    [
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15375022#comment-15375022
] 

ASF GitHub Bot commented on LOG4NET-467:
----------------------------------------

Github user stuartd commented on the issue:

    https://github.com/apache/log4net/pull/16

   
[ToUpperInvariant](http://stackoverflow.com/questions/2801508/what-is-wrong-with-tolowerinvariant)
is preferable

> Is .NET Core, will be supported in the near future, or not
> ----------------------------------------------------------
>
>                 Key: LOG4NET-467
>                 URL: https://issues.apache.org/jira/browse/LOG4NET-467
>             Project: Log4net
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 1.2.13
>            Reporter: san kan
>              Labels: features
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
(Continue reading)

ASF GitHub Bot (JIRA | 13 Jul 15:25 2016
Picon

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not


    [
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374973#comment-15374973
] 

ASF GitHub Bot commented on LOG4NET-467:
----------------------------------------

Github user niemyjski commented on a diff in the pull request:

    https://github.com/apache/log4net/pull/16#discussion_r70623307

    --- Diff: src/Util/PatternStringConverters/NewLinePatternConverter.cs ---
     <at>  <at>  -72,6 +75,16  <at>  <at>  internal sealed class NewLinePatternConverter : LiteralPatternConverter, IOption
     		/// </remarks>
     		public void ActivateOptions()
     		{
    +#if NETSTANDARD1_3
    +			if (CultureInfo.InvariantCulture.CompareInfo.Compare(Option, "DOS",
CompareOptions.IgnoreCase) == 0)
    +			{
    +				Option = "\r\n";
    +			}
    +			else if (CultureInfo.InvariantCulture.CompareInfo.Compare(Option, "UNIX",
CompareOptions.IgnoreCase) == 0)
    --- End diff --

    ToLowerInvariant()

> Is .NET Core, will be supported in the near future, or not
(Continue reading)

ASF GitHub Bot (JIRA | 13 Jul 12:29 2016
Picon

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not


    [
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374800#comment-15374800
] 

ASF GitHub Bot commented on LOG4NET-467:
----------------------------------------

Github user jasonwilliams200OK commented on a diff in the pull request:

    https://github.com/apache/log4net/pull/16#discussion_r70601430

    --- Diff: src/Util/PatternStringConverters/NewLinePatternConverter.cs ---
     <at>  <at>  -72,6 +75,16  <at>  <at>  internal sealed class NewLinePatternConverter : LiteralPatternConverter, IOption
     		/// </remarks>
     		public void ActivateOptions()
     		{
    +#if NETSTANDARD1_3
    +			if (CultureInfo.InvariantCulture.CompareInfo.Compare(Option, "DOS",
CompareOptions.IgnoreCase) == 0)
    +			{
    +				Option = "\r\n";
    +			}
    +			else if (CultureInfo.InvariantCulture.CompareInfo.Compare(Option, "UNIX",
CompareOptions.IgnoreCase) == 0)
    --- End diff --

    Should we just ToLower(), compare with `==` and get rid of the preprocessors for all Compare()-like code?

> Is .NET Core, will be supported in the near future, or not
(Continue reading)

ASF GitHub Bot (JIRA | 13 Jul 12:27 2016
Picon

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not


    [
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374796#comment-15374796
] 

ASF GitHub Bot commented on LOG4NET-467:
----------------------------------------

Github user jasonwilliams200OK commented on a diff in the pull request:

    https://github.com/apache/log4net/pull/16#discussion_r70601024

    --- Diff: src/Util/ReadOnlyPropertiesDictionary.cs ---
     <at>  <at>  -215,8 +216,13  <at>  <at>  public virtual void GetObjectData(SerializationInfo info, StreamingContext conte
     				string entryKey = entry.Key as string;
     				object entryValue = entry.Value;

    -				// If value is serializable then we add it to the list
    -				if (entryKey != null && entryValue != null && entryValue.GetType().IsSerializable)
    +                // If value is serializable then we add it to the list
    +#if NETSTANDARD1_3
    +			    bool isSerializable = entryValue.GetType().GetTypeInfo().IsSerializable;
    +#else
    +                bool isSerializable = entryValue.GetType().IsSerializable;
    +#endif
    +                if (entryKey != null && entryValue != null && isSerializable)
     				{
    --- End diff --

    nit: indentation under `#if` `#else` and that of `if (entryKey` is off
(Continue reading)


Gmane