John Celso Inocente (JIRA | 21 Jul 13:07 2016
Picon

[jira] [Created] (ISIS-1474) Cannot use custom

John Celso Inocente created ISIS-1474:
-----------------------------------------

             Summary: Cannot use custom 
                 Key: ISIS-1474
                 URL: https://issues.apache.org/jira/browse/ISIS-1474
             Project: Isis
          Issue Type: Bug
          Components: Core: Security: Shiro
    Affects Versions: 1.13.0
         Environment: Jetbrains IntelliJ
            Reporter: John Celso Inocente
            Assignee: Dan Haywood
            Priority: Blocker

Good Evening apache isis team,

	Im still new here so I'll try my best to explain the issue that I have found. I found a potential bug when I was
updating our application
to the latest apache isis version to 1.13.0 and found this error. It's regarding the shiro
authentication/authorization manager installer. It
seems it is looking for a constructor but couldn't trace and couldn't see as to why this happens. here is the
stacktrace: 

{quote}	
18:15:53,891  [IsisWicketApplication main       ERROR]  Failed to initialize
com.google.inject.ProvisionException: Guice provision errors:

1) Error in custom provider, org.apache.isis.core.commons.factory.InstanceCreationException:
Could not instantiate an object of class
(Continue reading)

Dan Haywood (JIRA | 19 Jul 18:10 2016
Picon

[jira] [Resolved] (ISIS-1472) Any attempts to schedule a background job via the RO viewer fail, due to incomplete state. (In fact: actions with commands cannot be invoked via RO viewer).


     [
https://issues.apache.org/jira/browse/ISIS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Haywood resolved ISIS-1472.
-------------------------------
    Resolution: Fixed

> Any attempts to schedule a background job via the RO viewer fail, due to incomplete state.  (In fact:
actions with commands cannot be invoked via RO viewer).
> -------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: ISIS-1472
>                 URL: https://issues.apache.org/jira/browse/ISIS-1472
>             Project: Isis
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.13.0
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>             Fix For: 1.13.1
>
>
> The issue is that regular commands are not being persisted, at all, under the RO viewer.  
> This is because I've made it the responsibility of the viewer to get hold of the current Command (using
CommandContext#getCommand()) and to update the "Executor" of the Command to be "USER".  This is done by
the Wicket viewer.  And, similarly, in BackgroundCommandExecution adapter the Executor gets set to "BACKGROUND".
> But in the RO viewer I've not updated this field, so it remains set to its default, "OTHER".  This then causes
the initialization of the Command (when the initial action is invoked) to be skipped, resulting in no memberIdentifier.
> So, the fix is just for RO viewer to set this field in DomainObjectResourceServerside and DomainServiceResourceServerside.
(Continue reading)

Picon

[jira] [Commented] (ISIS-1472) Any attempts to schedule a background job via the RO viewer fail, due to incomplete state. (In fact: actions with commands cannot be invoked via RO viewer).


    [
https://issues.apache.org/jira/browse/ISIS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384401#comment-15384401
] 

ASF subversion and git services commented on ISIS-1472:
-------------------------------------------------------

Commit 501e890f90d535df43d73a90e14295fadc9f9b64 in isis's branch refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=501e890 ]

ISIS-1472: set Command#Executor when invoking an action or editing a property.

> Any attempts to schedule a background job via the RO viewer fail, due to incomplete state.  (In fact:
actions with commands cannot be invoked via RO viewer).
> -------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: ISIS-1472
>                 URL: https://issues.apache.org/jira/browse/ISIS-1472
>             Project: Isis
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.13.0
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>             Fix For: 1.13.1
>
>
> The issue is that regular commands are not being persisted, at all, under the RO viewer.  
> This is because I've made it the responsibility of the viewer to get hold of the current Command (using
(Continue reading)

Cesar Lugo (JIRA | 19 Jul 17:43 2016
Picon

[jira] [Created] (ISIS-1473) Inline edit for mutable collections with filtering

Cesar Lugo created ISIS-1473:
--------------------------------

             Summary: Inline edit for mutable collections with filtering
                 Key: ISIS-1473
                 URL: https://issues.apache.org/jira/browse/ISIS-1473
             Project: Isis
          Issue Type: Improvement
          Components: Core: Viewer: Wicket
    Affects Versions: 1.13.0
            Reporter: Cesar Lugo
            Assignee: Dan Haywood

Ability to allow inline mutable collections allowing filters.  This would allow the users to edit
collections in the same grid shown in the Viewer, and also filter data using multiple types of filters.

Mutable collections might include:
- Row selection to identify which row to edit.
- Move around the properties within a collection either using the TAB key or using the mouse to position in a
specific property.
- Properties with multiple allowed values or with foreign lookup shown as a drop down selection list.
Ideally, if multiple values are allowed (1:N), multi-selection might be allowed.
- Existing values in a cell should be auto selected when the user reaches the cell, to facilitate replacing
the existing value by just keying in the new value.
- Allow creation of new elements in the collection by adding a row. Multiple rows could be added by reaching
the end of a row and keying in the TAB key, and also by selecting a blank space by the end of the collection grid.
- Ability to define in the meta data of the collection which properties are editable in this grid.
- Ability to define in the meta data if the user is allowed to add rows in this collection.

Filters:
(Continue reading)

Dan Haywood (JIRA | 19 Jul 16:33 2016
Picon

[jira] [Created] (ISIS-1472) Any attempts to schedule a background job via the RO viewer fail, due to incomplete state. (In fact: actions with commands cannot be invoked via RO viewer).

Dan Haywood created ISIS-1472:
---------------------------------

             Summary: Any attempts to schedule a background job via the RO viewer fail, due to incomplete state.  (In
fact: actions with commands cannot be invoked via RO viewer).
                 Key: ISIS-1472
                 URL: https://issues.apache.org/jira/browse/ISIS-1472
             Project: Isis
          Issue Type: Bug
          Components: Core
    Affects Versions: 1.13.0
            Reporter: Dan Haywood
            Assignee: Dan Haywood
             Fix For: 1.13.1

The issue is that regular commands are not being persisted, at all, under the RO viewer.  

This is because I've made it the responsibility of the viewer to get hold of the current Command (using
CommandContext#getCommand()) and to update the "Executor" of the Command to be "USER".  This is done by
the Wicket viewer.  And, similarly, in BackgroundCommandExecution adapter the Executor gets set to "BACKGROUND".

But in the RO viewer I've not updated this field, so it remains set to its default, "OTHER".  This then causes
the initialization of the Command (when the initial action is invoked) to be skipped, resulting in no memberIdentifier.

So, the fix is just for RO viewer to set this field in DomainObjectResourceServerside and DomainServiceResourceServerside.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

(Continue reading)

Dan Haywood (JIRA | 19 Jul 13:26 2016
Picon

[jira] [Comment Edited] (ISIS-1471) Integrate Flyway or Liquibase or something similar


    [
https://issues.apache.org/jira/browse/ISIS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383974#comment-15383974
] 

Dan Haywood edited comment on ISIS-1471 at 7/19/16 11:25 AM:
-------------------------------------------------------------

Jeroen wrote:

Hi Kambiz,

There's currently not a nice hook that I can think of to execute Flyway
migrations. I would create a separate "upgrade" mode to start Isis that
bootstraps with an in-memory db and allows you to do the Flyway stuff. But
Dan probably has other ideas ;-)

I've looked into Flyway for exactly the same purpose but was not really
enthousiast about it. What I disliked the most is that you have to maintain
every single db change in scripts. For me, the domain model is the source
and persistence should be derived from that. And Datanucleus does an
excellent job in creating all database artifacts so I want to keep
leveraging that.

What we currently do (manually) is roughly this:
1. stop Isis;
2. drop all db constraints;
3. apply db upgrade script (for the changes that cannot be handled by
Datanucleus);
4. start Isis;
(Continue reading)

Dan Haywood (JIRA | 19 Jul 13:25 2016
Picon

[jira] [Commented] (ISIS-1471) Integrate Flyway or Liquibase or something similar


    [
https://issues.apache.org/jira/browse/ISIS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383980#comment-15383980
] 

Dan Haywood commented on ISIS-1471:
-----------------------------------

Timothy wrote:

Hello Kambiz, Hello Jeroen,

My colleague pointed me to your mails at the mailing list as we were also interested in that topic. In
datanucleus documentation see [1] I found a hook that can be used. Please note that I implemented that
yesterday, so it is not well tested but the application starts and all integration tests are green.

In persistor_datanucleus.properties add this:
isis.persistor.datanucleus.impl.javax.jdo.PersistenceManagerFactoryClass=com.example.FlywayJdoPersistenceManagerFactory

and turn off the auto generation:
isis.persistor.datanucleus.impl.datanucleus.schema.autoCreateAll=false

Also I turned off validation because I had issues with LONGVARBINARY as HSQL replaced it to VARBINARY which
datanucleus was not very happy about that ;)
isis.persistor.datanucleus.impl.datanucleus.schema.validateAll=false
isis.persistor.datanucleus.impl.datanucleus.schema.validateTables=false
isis.persistor.datanucleus.impl.datanucleus.schema.validateColumns=false
isis.persistor.datanucleus.impl.datanucleus.schema.validateConstraints=false

Here the implementation of the class:
(Continue reading)

Dan Haywood (JIRA | 19 Jul 13:25 2016
Picon

[jira] [Comment Edited] (ISIS-1471) Integrate Flyway or Liquibase or something similar


    [
https://issues.apache.org/jira/browse/ISIS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383975#comment-15383975
] 

Dan Haywood edited comment on ISIS-1471 at 7/19/16 11:25 AM:
-------------------------------------------------------------

Oscar wrote:

Hi, Jeroen.

Nice to know you drop the constraints when upgrading.

I’ve also noticed that they get duplicated. Seems DN does not detect they’re already created and
re-create them.
In my case the db is PostgreSQL. As you’re using MS SQL Server in Estatio, seems it can be a generic issue.

It’s strange DN does not have addressed it. 

Please, confirm me if that’s the issue causing you to delete the constraints and I would create a issue in
the DN ticketing system.

Thanks,

Oscar

was (Author: danhaywood):
Oscar:
Hi, Jeroen.
(Continue reading)

Dan Haywood (JIRA | 19 Jul 13:25 2016
Picon

[jira] [Comment Edited] (ISIS-1471) Integrate Flyway or Liquibase or something similar


    [
https://issues.apache.org/jira/browse/ISIS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383976#comment-15383976
] 

Dan Haywood edited comment on ISIS-1471 at 7/19/16 11:25 AM:
-------------------------------------------------------------

Jeroen wrote:

Hi Oscar,

We're dropping the constraints because it makes it easier to handle migrations and were then 100% sure that
no retired constraint stays behind. I've not seen the error that you are referring to. We're also running
some other Apache Isis applications on PostgreSQL so it might be something else that is causing your issue.

Cheers,

Jeroen 

was (Author: danhaywood):
Jeroen:

Hi Oscar,

We're dropping the constraints because it makes it easier to handle migrations and were then 100% sure that
no retired constraint stays behind. I've not seen the error that you are referring to. We're also running
some other Apache Isis applications on PostgreSQL so it might be something else that is causing your issue.

Cheers,
(Continue reading)

Dan Haywood (JIRA | 19 Jul 13:24 2016
Picon

[jira] [Commented] (ISIS-1471) Integrate Flyway or Liquibase or something similar


    [
https://issues.apache.org/jira/browse/ISIS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383976#comment-15383976
] 

Dan Haywood commented on ISIS-1471:
-----------------------------------

Jeroen:

Hi Oscar,

We're dropping the constraints because it makes it easier to handle migrations and were then 100% sure that
no retired constraint stays behind. I've not seen the error that you are referring to. We're also running
some other Apache Isis applications on PostgreSQL so it might be something else that is causing your issue.

Cheers,

Jeroen 

> Integrate Flyway or Liquibase or something similar
> --------------------------------------------------
>
>                 Key: ISIS-1471
>                 URL: https://issues.apache.org/jira/browse/ISIS-1471
>             Project: Isis
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 1.13.0
>            Reporter: Dan Haywood
(Continue reading)

Dan Haywood (JIRA | 19 Jul 13:23 2016
Picon

[jira] [Created] (ISIS-1471) Integrate Flyway or Liquibase or something similar

Dan Haywood created ISIS-1471:
---------------------------------

             Summary: Integrate Flyway or Liquibase or something similar
                 Key: ISIS-1471
                 URL: https://issues.apache.org/jira/browse/ISIS-1471
             Project: Isis
          Issue Type: New Feature
          Components: Core
    Affects Versions: 1.13.0
            Reporter: Dan Haywood
            Assignee: Dan Haywood
             Fix For: 1.14.0

from Kambiz:

Hi,

in our non-Isis projects, we use FlyWay [1] for DB migrations and I
would like to integrate it into our Isis workflow. The simplest path to
do so would be a DomainService with a PostConstruct annotated init
method:

 <at> PostConstruct
public void init(final Map<String, String> properties) {
    Flyway flyway = new Flyway();

    // Point it to the database
    String jdbcUrl = properties.get("isis.persistor.datanucleus.impl.javax.jdo.option.ConnectionURL");
    String user = properties.get("isis.persistor.datanucleus.impl.javax.jdo.option.ConnectionUserName");
(Continue reading)


Gmane