Oscar Bou (JIRA | 30 Aug 16:33 2014
Picon

[jira] [Updated] (ISIS-871) NPE - ActionInvocationFacetForInteractionAbstract passes Null to "ObjectSpecification.isViewModelCloneable"


     [
https://issues.apache.org/jira/browse/ISIS-871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oscar Bou updated ISIS-871:
---------------------------

    Attachment: patch_ISIS-871.diff

Patch file.

> NPE - ActionInvocationFacetForInteractionAbstract passes Null to "ObjectSpecification.isViewModelCloneable"
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: ISIS-871
>                 URL: https://issues.apache.org/jira/browse/ISIS-871
>             Project: Isis
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: core-1.6.0
>            Reporter: Oscar Bou
>            Assignee: Dan Haywood
>         Attachments: patch_ISIS-871.diff
>
>
> As it passes a null value, a NPE is thrown afterwards (the ObjectAdapter is null).
> See attached patch file.

--
This message was sent by Atlassian JIRA
(Continue reading)

Oscar Bou (JIRA | 30 Aug 16:31 2014
Picon

[jira] [Created] (ISIS-871) NPE - ActionInvocationFacetForInteractionAbstract passes Null to "ObjectSpecification.isViewModelCloneable"

Oscar Bou created ISIS-871:
------------------------------

             Summary: NPE - ActionInvocationFacetForInteractionAbstract passes Null to "ObjectSpecification.isViewModelCloneable"
                 Key: ISIS-871
                 URL: https://issues.apache.org/jira/browse/ISIS-871
             Project: Isis
          Issue Type: Bug
          Components: Core
    Affects Versions: core-1.6.0
            Reporter: Oscar Bou
            Assignee: Dan Haywood

As it passes a null value, a NPE is thrown afterwards (the ObjectAdapter is null).

See attached patch file.

--
This message was sent by Atlassian JIRA
(v6.2#6252)

Dan Haywood (JIRA | 22 Aug 20:42 2014
Picon

[jira] [Created] (ISIS-870) Settings service (isisaddons) should support obfuscare passwords. This will require some support from Core.

Dan Haywood created ISIS-870:
--------------------------------

             Summary: Settings service (isisaddons) should support obfuscare passwords.  This will require some
support from Core.
                 Key: ISIS-870
                 URL: https://issues.apache.org/jira/browse/ISIS-870
             Project: Isis
          Issue Type: New Feature
          Components: Core, Viewer: Wicket
    Affects Versions: core-1.6.0, viewer-wicket-1.6.0
            Reporter: Dan Haywood
            Assignee: Dan Haywood
            Priority: Minor
             Fix For: viewer-wicket-1.7.0, core-1.7.0

--
This message was sent by Atlassian JIRA
(v6.2#6252)

Dan Haywood (JIRA | 22 Aug 20:40 2014
Picon

[jira] [Created] (ISIS-869) Domain service (probably isisaddons) to wrap HttpSession.

Dan Haywood created ISIS-869:
--------------------------------

             Summary: Domain service (probably isisaddons) to wrap HttpSession.
                 Key: ISIS-869
                 URL: https://issues.apache.org/jira/browse/ISIS-869
             Project: Isis
          Issue Type: New Feature
          Components: Core
    Affects Versions: core-1.6.0
            Reporter: Dan Haywood
            Assignee: Dan Haywood
            Priority: Minor
             Fix For: core-1.7.0

--
This message was sent by Atlassian JIRA
(v6.2#6252)

Dan Haywood (JIRA | 22 Aug 20:38 2014
Picon

[jira] [Created] (ISIS-868) Domain service (probably isisaddons) to provide a toggle service (wrap togglz)

Dan Haywood created ISIS-868:
--------------------------------

             Summary: Domain service (probably isisaddons) to provide a toggle service (wrap togglz)
                 Key: ISIS-868
                 URL: https://issues.apache.org/jira/browse/ISIS-868
             Project: Isis
          Issue Type: New Feature
          Components: Core
    Affects Versions: core-1.6.0
            Reporter: Dan Haywood
            Assignee: Dan Haywood
            Priority: Minor
             Fix For: core-1.7.0

http://www.togglz.org/

--
This message was sent by Atlassian JIRA
(v6.2#6252)

Dan Haywood (JIRA | 22 Aug 20:38 2014
Picon

[jira] [Created] (ISIS-867) Domain service (probably in isisaddons) to automatically maintain lastUpdatedAt and lastUpdatedBy on any entity.

Dan Haywood created ISIS-867:
--------------------------------

             Summary: Domain service (probably in isisaddons) to automatically maintain lastUpdatedAt and
lastUpdatedBy on any entity.
                 Key: ISIS-867
                 URL: https://issues.apache.org/jira/browse/ISIS-867
             Project: Isis
          Issue Type: New Feature
          Components: Core
    Affects Versions: core-1.6.0
            Reporter: Dan Haywood
            Assignee: Dan Haywood
            Priority: Minor
             Fix For: core-1.7.0

using ISIS-865.

Define:
interface Updateable {
     <at> Programmatic
    public void updatedBy(String userName);
     <at> Programmatic
    publc void updatedAt(DateTime dt);
}

Install a JDO StoreLifecycleListener on the PersistenceManager when request starts, call in preStore.

Should double-check plays well with auditing service.  (Should be ok, since even if this listener and Isis'
global listener are called in indeterminate order, even then we only hit the auditing service just prior
(Continue reading)

Dan Haywood (JIRA | 22 Aug 20:32 2014
Picon

[jira] [Created] (ISIS-866) Request-scoped service should be told when the request is starting and stopping.

Dan Haywood created ISIS-866:
--------------------------------

             Summary: Request-scoped service should be told when the request is starting and stopping.
                 Key: ISIS-866
                 URL: https://issues.apache.org/jira/browse/ISIS-866
             Project: Isis
          Issue Type: Improvement
          Components: Core
    Affects Versions: core-1.6.0
            Reporter: Dan Haywood
            Assignee: Dan Haywood
            Priority: Minor
             Fix For: core-1.7.0

For  <at> RequestScoped services, Isis creates a proxy that implements the RequestScopedService interface
(in Isis core-runtime), which defines __isis_startRequest and __isis_stopRequest.  These methods are
then called when the Isis session (=request scope) is created so that the proxy can instantiate a service
for the duration of the request, bound to the thread-local.

HOWEVER...

The underlying service doesn't actually know it has been created/a request is started.  It isn't possible
to put logic in the constructor, because that stuff is also called by the proxy wrapper.

SO...

Define a new interface (in applib) that can be optionally implemented by  <at> RequestScoped services (or
might even be an equivalent facet); if the service implements, then have the proxy wrapper call it.  eg:

(Continue reading)

Dan Haywood (JIRA | 22 Aug 20:18 2014
Picon

[jira] [Commented] (ISIS-766) ISIS Service / ViewModel method calling twice when this method processing BLOB type


    [
https://issues.apache.org/jira/browse/ISIS-766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107229#comment-14107229
] 

Dan Haywood commented on ISIS-766:
----------------------------------

Sorry, I guess I didn't explain myself well enough about ExceptionRecogniser service.   If you are getting
some new sort of exception then we *want* that exception to be recognized, so that it can be rendered like a
validation error in the prompt.

So, rather than remove the service, what I'd like you to do is see if you can figure out what that exception you
are seeing is.  Then we could extend the ExceptionRecogniser service to recognise this new exception type
and thus not cause the problem.  Hence, try adding a breakpoint in your IDE on *any* exception thrown.

Meanwhile, I am using the big xlsx file (1.6Mb), have uploaded it 4 times in succession, no errors.

> ISIS Service / ViewModel method calling twice when this method processing BLOB type
> -----------------------------------------------------------------------------------
>
>                 Key: ISIS-766
>                 URL: https://issues.apache.org/jira/browse/ISIS-766
>             Project: Isis
>          Issue Type: Bug
>          Components: Viewer: Wicket
>    Affects Versions: viewer-wicket-1.4.1
>            Reporter: Ranganath Chittari
>            Assignee: Dan Haywood
>            Priority: Blocker
(Continue reading)

Ranganath Chittari (JIRA | 22 Aug 20:06 2014
Picon

[jira] [Commented] (ISIS-766) ISIS Service / ViewModel method calling twice when this method processing BLOB type


    [
https://issues.apache.org/jira/browse/ISIS-766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107209#comment-14107209
] 

Ranganath Chittari commented on ISIS-766:
-----------------------------------------

can you please try with big xlsx file as well if the issue can be reproducible.

Please try multiple times to reproduce it. I don't know if it is reproducing inconsistently at your side

> ISIS Service / ViewModel method calling twice when this method processing BLOB type
> -----------------------------------------------------------------------------------
>
>                 Key: ISIS-766
>                 URL: https://issues.apache.org/jira/browse/ISIS-766
>             Project: Isis
>          Issue Type: Bug
>          Components: Viewer: Wicket
>    Affects Versions: viewer-wicket-1.4.1
>            Reporter: Ranganath Chittari
>            Assignee: Dan Haywood
>            Priority: Blocker
>             Fix For: viewer-wicket-1.7.0
>
>         Attachments: BBY Provisioning Template V1 12.3.xlsx, BBY Provisioning Template V1
12.3_smaller.xlsx, Behaviour-Rejected-Error.log, Files.zip,
Postgresql_Audit_trigger_91plus.sql, Upload-Invocation-Failed.log, dom.zip
>
(Continue reading)

Dan Haywood (JIRA | 22 Aug 20:04 2014
Picon

[jira] [Created] (ISIS-865) Either warn or fail-fast if an action is annotated with safe semantics but nevertheless results in dirty objects in the xactn.

Dan Haywood created ISIS-865:
--------------------------------

             Summary: Either warn or fail-fast if an action is annotated with safe semantics but nevertheless results
in dirty objects in the xactn.
                 Key: ISIS-865
                 URL: https://issues.apache.org/jira/browse/ISIS-865
             Project: Isis
          Issue Type: New Feature
    Affects Versions: core-1.6.0
            Reporter: Dan Haywood
            Assignee: Dan Haywood
             Fix For: core-1.7.0

Following on/inspired by ISIS-864.

Needs some discussion to decide on how to configure.  Warning could just be logging, while fail-fast could
mean throw an exception.

--
This message was sent by Atlassian JIRA
(v6.2#6252)

Dan Haywood (JIRA | 22 Aug 20:02 2014
Picon

[jira] [Created] (ISIS-864) Command should be persisted if any dirty objects enlisted into transaction, in order to ensure no accidental orphans.

Dan Haywood created ISIS-864:
--------------------------------

             Summary: Command should be persisted if any dirty objects enlisted into transaction, in order to ensure no
accidental orphans.
                 Key: ISIS-864
                 URL: https://issues.apache.org/jira/browse/ISIS-864
             Project: Isis
          Issue Type: Improvement
          Components: Core
    Affects Versions: core-1.6.0
            Reporter: Dan Haywood
            Assignee: Dan Haywood
             Fix For: core-1.7.0

adding:
isis.services.command.actions=ignoreQueryOnly
means that commands are not persisted for any query-only actions.  But that means that if an action is
incorrectly annotated with query-only semantics (ie  <at> ActionSemantics(Of.SAFE)) and then dirties
objects, then we can end up with audit entries for those dirty objects that are orphaned.

So, this enhancement is for Isis core to always persist a command whenever an object has been dirtied, even
if from an action that has SAFE semantics.

then 

--
This message was sent by Atlassian JIRA
(v6.2#6252)

(Continue reading)


Gmane