Martin Grigorov | 29 Jul 23:01 2015
Picon

Re: isis git commit: ISIS-1182: spiking using fast-classpath-scanner.

On Jul 29, 2015 11:27 PM, <danhaywood@...> wrote:
>
> Repository: isis
> Updated Branches:
>   refs/heads/ISIS-1182 [created] f311839c2
>
>
> ISIS-1182: spiking using fast-classpath-scanner.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/isis/repo
> Commit: http://git-wip-us.apache.org/repos/asf/isis/commit/f311839c
> Tree: http://git-wip-us.apache.org/repos/asf/isis/tree/f311839c
> Diff: http://git-wip-us.apache.org/repos/asf/isis/diff/f311839c
>
> Branch: refs/heads/ISIS-1182
> Commit: f311839c2fecef433bfd8dd6e1e3427bc5facf64
> Parents: c3d3480
> Author: Dan Haywood <dan@...>
> Authored: Wed Jul 29 21:26:38 2015 +0100
> Committer: Dan Haywood <dan@...>
> Committed: Wed Jul 29 21:26:38 2015 +0100
>
> ----------------------------------------------------------------------
>  core/applib/pom.xml                             | 13 ++++
>  ...scoveryServiceUsingFastClasspathScanner.java | 68 +++++++++++++++++
>  .../ClassDiscoveryServiceUsingReflections.java  | 14 +---
>  .../ServicesInstallerFromAnnotation.java        | 77 +++++++++++++++++++-
>  4 files changed, 157 insertions(+), 15 deletions(-)
> ----------------------------------------------------------------------
(Continue reading)

Picon

[jira] [Commented] (ISIS-1182) Use different classpath scanner to reduce time to boot.


    [
https://issues.apache.org/jira/browse/ISIS-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14646703#comment-14646703
] 

ASF subversion and git services commented on ISIS-1182:
-------------------------------------------------------

Commit f311839c2fecef433bfd8dd6e1e3427bc5facf64 in isis's branch refs/heads/ISIS-1182 from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f311839 ]

ISIS-1182: spiking using fast-classpath-scanner.

> Use different classpath scanner to reduce time to boot.
> -------------------------------------------------------
>
>                 Key: ISIS-1182
>                 URL: https://issues.apache.org/jira/browse/ISIS-1182
>             Project: Isis
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: core-1.8.0
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>            Priority: Minor
>             Fix For: 1.9.0
>
>

--
(Continue reading)

Dan Haywood (JIRA | 29 Jul 22:26 2015
Picon

[jira] [Created] (ISIS-1182) Use different classpath scanner to reduce time to boot.

Dan Haywood created ISIS-1182:
---------------------------------

             Summary: Use different classpath scanner to reduce time to boot.
                 Key: ISIS-1182
                 URL: https://issues.apache.org/jira/browse/ISIS-1182
             Project: Isis
          Issue Type: Improvement
          Components: Core
    Affects Versions: core-1.8.0
            Reporter: Dan Haywood
            Assignee: Dan Haywood
            Priority: Minor
             Fix For: 1.9.0

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Dan Haywood (JIRA | 29 Jul 20:38 2015
Picon

[jira] [Resolved] (ISIS-1051) performance fix: LayoutMetadataReaderFromJson is called too often


     [
https://issues.apache.org/jira/browse/ISIS-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Haywood resolved ISIS-1051.
-------------------------------
    Resolution: Fixed

> performance fix: LayoutMetadataReaderFromJson is called too often
> -----------------------------------------------------------------
>
>                 Key: ISIS-1051
>                 URL: https://issues.apache.org/jira/browse/ISIS-1051
>             Project: Isis
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: core-1.7.0
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>             Fix For: 1.9.0
>
>
> Taken from a comment by Martin on ISIS-931:
> While debugging ISIS-911 I've noticed that
org.apache.isis.core.metamodel.layoutmetadata.json.LayoutMetadataReaderFromJson#asProperties
is expensive. It is called at start time and tries to load .layout.json file for every introspected
method. This includes JRE classes, JDO classes, and many more. I think it should be called only for
objects/entities. The expensiveness is that it tries to find a file in the classpath and if it is not found
then it throws
org.apache.isis.core.metamodel.layoutmetadata.LayoutMetadataReader.ReaderException. The
(Continue reading)

Picon

[jira] [Commented] (ISIS-1051) performance fix: LayoutMetadataReaderFromJson is called too often


    [
https://issues.apache.org/jira/browse/ISIS-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14646572#comment-14646572
] 

ASF subversion and git services commented on ISIS-1051:
-------------------------------------------------------

Commit 405d0ddaf5eb71993822a9a66515ecdbb4b87e54 in isis's branch refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=405d0dd ]

ISIS-1051: FacetMethodsBuilder uses new LayoutMetadataReader2 interface to ask reader whether to
attempt to load metadata for class.  In addition...

In addition, the LayoutMetadataReaderFromJson now remembers whether it was able to find a layout.json
file for a given class, and won't attempt to in future.  Also doesn't use throw/catch of exceptions for
control flow.

> performance fix: LayoutMetadataReaderFromJson is called too often
> -----------------------------------------------------------------
>
>                 Key: ISIS-1051
>                 URL: https://issues.apache.org/jira/browse/ISIS-1051
>             Project: Isis
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: core-1.7.0
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>             Fix For: 1.9.0
(Continue reading)

Picon

[jira] [Commented] (ISIS-1051) performance fix: LayoutMetadataReaderFromJson is called too often


    [
https://issues.apache.org/jira/browse/ISIS-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14646573#comment-14646573
] 

ASF subversion and git services commented on ISIS-1051:
-------------------------------------------------------

Commit c3d348088b03f7399a630fb784706a53bc604fc9 in isis's branch refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=c3d3480 ]

ISIS-1051: updating doc for LayoutMetadataReader2.

> performance fix: LayoutMetadataReaderFromJson is called too often
> -----------------------------------------------------------------
>
>                 Key: ISIS-1051
>                 URL: https://issues.apache.org/jira/browse/ISIS-1051
>             Project: Isis
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: core-1.7.0
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>             Fix For: 1.9.0
>
>
> Taken from a comment by Martin on ISIS-931:
> While debugging ISIS-911 I've noticed that
org.apache.isis.core.metamodel.layoutmetadata.json.LayoutMetadataReaderFromJson#asProperties
(Continue reading)

Vladimir Nisevic (JIRA | 29 Jul 15:03 2015
Picon

[jira] [Created] (ISIS-1181) Isis Documentaion - broken link

Vladimir Nisevic created ISIS-1181:
--------------------------------------

             Summary: Isis Documentaion - broken link
                 Key: ISIS-1181
                 URL: https://issues.apache.org/jira/browse/ISIS-1181
             Project: Isis
          Issue Type: Bug
          Components: Website and Docs
            Reporter: Vladimir Nisevic
            Assignee: Dan Haywood
            Priority: Minor

There is a broken link under name  "simpleapp archetype:"  in the main page https://isis.apache.org/

......
Getting started

Start developing your own Apache Isis application using our simpleapp archetype:
...............

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Picon

[jira] [Created] (ISIS-1180) Make it possible to declare some object type properties display as values only

Alexander Stephen Cameron created ISIS-1180:
-----------------------------------------------

             Summary: Make it possible to declare some object type properties display as values only
                 Key: ISIS-1180
                 URL: https://issues.apache.org/jira/browse/ISIS-1180
             Project: Isis
          Issue Type: Improvement
          Components: Core: Viewer: Wicket
            Reporter: Alexander Stephen Cameron
            Assignee: Dan Haywood
            Priority: Minor

It makes sense to define code-list entries as objects so that they can be managed in the same way as other
kinds of objects in Isis. However, such objects (e.g Color, Region, Salutation) are likely to have only
one property, the code 'value' or 'name'. If another type of complex object has a property of type Color
say, it makes no sense to display the assigned Color as an object (with an icon and a link), as there is no
reason to navigate to that code-list entry object, all we want to see is the title(), which will be the value.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Dan Haywood (JIRA | 29 Jul 08:00 2015
Picon

[jira] [Resolved] (ISIS-1179) Prevent the defaultXxx(...) being called multiple times when invoke an action.


     [
https://issues.apache.org/jira/browse/ISIS-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Haywood resolved ISIS-1179.
-------------------------------
    Resolution: Fixed

> Prevent the defaultXxx(...) being called multiple times when invoke an action.
> ------------------------------------------------------------------------------
>
>                 Key: ISIS-1179
>                 URL: https://issues.apache.org/jira/browse/ISIS-1179
>             Project: Isis
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: core-1.8.0
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>            Priority: Minor
>             Fix For: 1.9.0
>
>         Attachments: first-call.png, second-call.png
>
>
> Looking into the code, we seem to call reset() - which is the method that utlimately calls the defaultXxx()
methods - twice, once when we construct the ScalarModel and then again later when we make a call to clearArgs.
> Seems to be easy enough to call it just once.

--
(Continue reading)

Picon

[jira] [Commented] (ISIS-1173) Split out responsibilities of FixtureScript class so that framework can provide a default implementation, and be configured through an alternative.


    [
https://issues.apache.org/jira/browse/ISIS-1173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14645497#comment-14645497
] 

ASF subversion and git services commented on ISIS-1173:
-------------------------------------------------------

Commit 1bdd35c7ae717869b68ab5628d39cba88be0fd90 in isis's branch refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=1bdd35c ]

ISIS-1173: menu separators were not appearing correctly on prototyping menu when the
FixtureScriptsSpecificationProvider in use

Possibly an interaction with fix for ISIS-1175, or more likely just as result of missing annotations in the
fallback FixtureScriptsDefault.

> Split out responsibilities of FixtureScript class so that framework can provide a default
implementation, and be configured through an alternative.
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: ISIS-1173
>                 URL: https://issues.apache.org/jira/browse/ISIS-1173
>             Project: Isis
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: core-1.8.0
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>            Priority: Minor
(Continue reading)

Picon

[jira] [Commented] (ISIS-1179) Prevent the defaultXxx(...) being called multiple times when invoke an action.


    [
https://issues.apache.org/jira/browse/ISIS-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14645499#comment-14645499
] 

ASF subversion and git services commented on ISIS-1179:
-------------------------------------------------------

Commit ceddc2c5b38b449b9f9b0ba7fbc2eec593278447 in isis's branch refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ceddc2c ]

ISIS-1179: only call defaultXxx(...) once for action parameters.

> Prevent the defaultXxx(...) being called multiple times when invoke an action.
> ------------------------------------------------------------------------------
>
>                 Key: ISIS-1179
>                 URL: https://issues.apache.org/jira/browse/ISIS-1179
>             Project: Isis
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: core-1.8.0
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>            Priority: Minor
>             Fix For: 1.9.0
>
>         Attachments: first-call.png, second-call.png
>
>
(Continue reading)


Gmane