Picon

[jira] [Commented] (ISIS-1129) SudoService to allow the current user to be temporarily switched (for fixture scripts and integ tests)


    [
https://issues.apache.org/jira/browse/ISIS-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503439#comment-14503439
] 

ASF subversion and git services commented on ISIS-1129:
-------------------------------------------------------

Commit 081d47b057d337fdb3dfb0603bca516436629d22 in isis's branch refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=081d47b ]

ISIS-1129: move SudoServiceDefault package; use stack

> SudoService to allow the current user to be temporarily switched (for fixture scripts and integ tests)
> ------------------------------------------------------------------------------------------------------
>
>                 Key: ISIS-1129
>                 URL: https://issues.apache.org/jira/browse/ISIS-1129
>             Project: Isis
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: core-1.8.0
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>            Priority: Minor
>             Fix For: 1.9.0
>
>

--
(Continue reading)

Picon

[jira] [Commented] (ISIS-1052) Isis 1.9.0 release tasks


    [
https://issues.apache.org/jira/browse/ISIS-1052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503437#comment-14503437
] 

ASF subversion and git services commented on ISIS-1052:
-------------------------------------------------------

Commit f69eaf43fddbbe10e09767d031fdc6dc593cfd6c in isis's branch refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f69eaf4 ]

ISIS-1052: converted assertions to AssertJ

> Isis 1.9.0 release tasks
> ------------------------
>
>                 Key: ISIS-1052
>                 URL: https://issues.apache.org/jira/browse/ISIS-1052
>             Project: Isis
>          Issue Type: Task
>          Components: Core
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>            Priority: Minor
>             Fix For: 1.9.0
>
>

--
This message was sent by Atlassian JIRA
(Continue reading)

Picon

[jira] [Commented] (ISIS-1052) Isis 1.9.0 release tasks


    [
https://issues.apache.org/jira/browse/ISIS-1052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503438#comment-14503438
] 

ASF subversion and git services commented on ISIS-1052:
-------------------------------------------------------

Commit 28e4dbf763df60eef1a1d25e67cc19a7404b23ab in isis's branch refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=28e4dbf ]

ISIS-1052: recreating simpleapp archetype

> Isis 1.9.0 release tasks
> ------------------------
>
>                 Key: ISIS-1052
>                 URL: https://issues.apache.org/jira/browse/ISIS-1052
>             Project: Isis
>          Issue Type: Task
>          Components: Core
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>            Priority: Minor
>             Fix For: 1.9.0
>
>

--
This message was sent by Atlassian JIRA
(Continue reading)

Picon

[jira] [Commented] (ISIS-1129) SudoService to allow the current user to be temporarily switched (for fixture scripts and integ tests)


    [
https://issues.apache.org/jira/browse/ISIS-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503440#comment-14503440
] 

ASF subversion and git services commented on ISIS-1129:
-------------------------------------------------------

Commit 9a931d8573cb2ac5433de3b9b6b1714c1c30b8cb in isis's branch refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=9a931d8 ]

ISIS-1129: convert ThreadLocal to be a stack (so use can be nested)

> SudoService to allow the current user to be temporarily switched (for fixture scripts and integ tests)
> ------------------------------------------------------------------------------------------------------
>
>                 Key: ISIS-1129
>                 URL: https://issues.apache.org/jira/browse/ISIS-1129
>             Project: Isis
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: core-1.8.0
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>            Priority: Minor
>             Fix For: 1.9.0
>
>

--
(Continue reading)

Picon

[jira] [Commented] (ISIS-1052) Isis 1.9.0 release tasks


    [
https://issues.apache.org/jira/browse/ISIS-1052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503436#comment-14503436
] 

ASF subversion and git services commented on ISIS-1052:
-------------------------------------------------------

Commit d5999f83fd8da4882836db21e9e0ba5452f7f72c in isis's branch refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d5999f8 ]

ISIS-1052: converting simpleapp to use AssertJ

> Isis 1.9.0 release tasks
> ------------------------
>
>                 Key: ISIS-1052
>                 URL: https://issues.apache.org/jira/browse/ISIS-1052
>             Project: Isis
>          Issue Type: Task
>          Components: Core
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>            Priority: Minor
>             Fix For: 1.9.0
>
>

--
This message was sent by Atlassian JIRA
(Continue reading)

Martin Grigorov (JIRA | 17 Apr 23:07 2015
Picon

[jira] [Commented] (ISIS-1134) DN connections leak due to non-closed queries (?!)


    [
https://issues.apache.org/jira/browse/ISIS-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14500668#comment-14500668
] 

Martin Grigorov commented on
ISIS-1134:
---------------------------------------

org.apache.isis.core.metamodel.services.container.DomainObjectContainerDefault#firstMatch(org.apache.isis.applib.query.Query<T>)
starts with flush() call.
Why this is needed? Why by default?
It looks like a custom transaction isolation mechanism.

Removing this #flush() call fixes the issue above and my app seems to work fine. But I'm sure some
applications' use cases must be broken now.

> DN connections leak due to non-closed queries (?!)
> --------------------------------------------------
>
>                 Key: ISIS-1134
>                 URL: https://issues.apache.org/jira/browse/ISIS-1134
>             Project: Isis
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: core-1.8.0
>            Reporter: Martin Grigorov
>            Assignee: Dan Haywood
>
> My application failed twice with OutOfMemoryError in heap space so I've dumped a .hprof of its memory
(Continue reading)

Martin Grigorov (JIRA | 17 Apr 22:46 2015
Picon

[jira] [Commented] (ISIS-1134) DN connections leak due to non-closed queries (?!)


    [
https://issues.apache.org/jira/browse/ISIS-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14500638#comment-14500638
] 

Martin Grigorov commented on ISIS-1134:
---------------------------------------

After reading some more JDO documents and articles in the web I believe this two commits should be the proper
fix here.
Unfortunately now isis-module-security fails during executing its seeds:

Caused by: javax.jdo.JDODataStoreException: Insert of object
"org.isisaddons.module.security.dom.role.ApplicationRole <at> 556a5b6c" using statement "INSERT
INTO IsisAddonsSecurity."ApplicationRole" ("name","description") VALUES (?,?)" failed :
integrity constraint violation: unique constraint or index violation; "ApplicationRole_name_UNQ"
table: "ApplicationRole"
NestedThrowables:
java.sql.SQLIntegrityConstraintViolationException: integrity constraint violation: unique
constraint or index violation; "ApplicationRole_name_UNQ" table: "ApplicationRole"
	at org.datanucleus.api.jdo.NucleusJDOHelper.getJDOExceptionForNucleusException(NucleusJDOHelper.java:451)
	at org.datanucleus.api.jdo.JDOPersistenceManager.jdoMakePersistent(JDOPersistenceManager.java:732)
	at org.datanucleus.api.jdo.JDOPersistenceManager.makePersistent(JDOPersistenceManager.java:752)
	at org.apache.isis.objectstore.jdo.datanucleus.persistence.commands.DataNucleusCreateObjectCommand.execute(DataNucleusCreateObjectCommand.java:54)
	at org.apache.isis.objectstore.jdo.datanucleus.DataNucleusObjectStore.executeCommands(DataNucleusObjectStore.java:361)
	at org.apache.isis.objectstore.jdo.datanucleus.DataNucleusObjectStore.execute(DataNucleusObjectStore.java:355)
	at org.apache.isis.core.runtime.system.transaction.IsisTransaction.doFlush(IsisTransaction.java:521)
	at org.apache.isis.core.runtime.system.transaction.IsisTransaction.flush(IsisTransaction.java:467)
	at org.apache.isis.core.runtime.system.transaction.IsisTransactionManager.flushTransaction(IsisTransactionManager.java:392)
	at org.apache.isis.core.runtime.persistence.internal.RuntimeContextFromSession$7.flush(RuntimeContextFromSession.java:238)
(Continue reading)

Picon

[jira] [Commented] (ISIS-1134) DN connections leak due to non-closed queries (?!)


    [
https://issues.apache.org/jira/browse/ISIS-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14500632#comment-14500632
] 

ASF subversion and git services commented on ISIS-1134:
-------------------------------------------------------

Commit 57fb39590168d5f701bc63b7b2e261fdbb3e73f6 in isis's branch
refs/heads/ISIS-1134-leaking-queryresults from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=57fb395 ]

ISIS-1134 Consume the resultset in one more place

> DN connections leak due to non-closed queries (?!)
> --------------------------------------------------
>
>                 Key: ISIS-1134
>                 URL: https://issues.apache.org/jira/browse/ISIS-1134
>             Project: Isis
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: core-1.8.0
>            Reporter: Martin Grigorov
>            Assignee: Dan Haywood
>
> My application failed twice with OutOfMemoryError in heap space so I've dumped a .hprof of its memory
(jmap -dump:format=b,file=some-file.hprof) and analyzed it with Eclipse MAT (https://eclipse.org/mat/).
> It appears that there are many org.datanucleus.store.rdbms.query.JDOQLQuery$2 objects.
> JDOQLQuery$2 appears to be ManagedConnectionResourceListener ( https://github.com/datanucleus/datanucleus-rdbms/blob/651c77ff3b2af76ada97d14b537cd41fb0524a0c/src/java/org/datanucleus/store/rdbms/query/JDOQLQuery.java#L740).
(Continue reading)

Picon

[jira] [Commented] (ISIS-1134) DN connections leak due to non-closed queries (?!)


    [
https://issues.apache.org/jira/browse/ISIS-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14500618#comment-14500618
] 

ASF subversion and git services commented on ISIS-1134:
-------------------------------------------------------

Commit b126214a7b0e32676ad1ecc0556d228e099dc70e in isis's branch
refs/heads/ISIS-1134-leaking-queryresults from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b126214 ]

ISIS-1134 Close the JDOQuery after executing it and consuming its resultset

> DN connections leak due to non-closed queries (?!)
> --------------------------------------------------
>
>                 Key: ISIS-1134
>                 URL: https://issues.apache.org/jira/browse/ISIS-1134
>             Project: Isis
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: core-1.8.0
>            Reporter: Martin Grigorov
>            Assignee: Dan Haywood
>
> My application failed twice with OutOfMemoryError in heap space so I've dumped a .hprof of its memory
(jmap -dump:format=b,file=some-file.hprof) and analyzed it with Eclipse MAT (https://eclipse.org/mat/).
> It appears that there are many org.datanucleus.store.rdbms.query.JDOQLQuery$2 objects.
> JDOQLQuery$2 appears to be ManagedConnectionResourceListener ( https://github.com/datanucleus/datanucleus-rdbms/blob/651c77ff3b2af76ada97d14b537cd41fb0524a0c/src/java/org/datanucleus/store/rdbms/query/JDOQLQuery.java#L740).
(Continue reading)

Dan Haywood | 16 Apr 20:45 2015

Any objections to me merging in ISIS-789 (the DataNucleus 4 stuff) to master?

Hi folks

For those running off -SNAPSHOT, this will impact you:

*I'd like to merge in ISIS-789, the DataNucleus 4 stuff to master.*

If you are running against -SNAPSHOT, it will require some minor updates to
existing pom.xml files.  (I intend to prepare an update doc on the website;
will be in the 1.9.0 release notes).

More importantly, though, this is a major upgrade of DN4 and, so, should be
considered as quite high risk.  I recommend that it is kept away from
production for a little while, at least.

If you are using -SNAPSHOT in production, my recommendation is that you can
create a stable branch for yourself and build from that.

~~~
Let me know ... will assume silent consensus.

Thx
Dan
Dan Haywood | 16 Apr 10:05 2015

Asciidoc website starting to take shape

I've started work on porting over our documentation to use Asciidoc, as per
ISIS-1133 [1]

See staging site [2] which corresponds to this asciidoc source [3].  The
README [4] explains how publishing is done

~~~

Most of the content there is skeleton, but you can review:

* my fancy table-of-contents handling as it works for the user guide  [4]
* the first "real" content, namely the updated IntelliJ setup guide [4]

All feedback welcome.

Also, everyone can now fork the repo and start to contribute doc patches
etc.

Thanks
Dan

[1] https://issues.apache.org/jira/browse/ISIS-1133
[2] http://isis.staging.apache.org/docs/
[3] https://github.com/apache/isis/tree/master/adocs/documentation
[4] https://github.com/apache/isis/blob/master/adocs/documentation/README.md
[5] http://isis.staging.apache.org/docs/user-guide/user-guide.html
[6]
http://isis.staging.apache.org/docs/getting-started/development-environment/intellij-idea/intellij-idea.html

Gmane